Python client renames related to session file upload/download#44114
Merged
dargilco merged 7 commits intoJun 23, 2026
Merged
Conversation
dargilco
requested review from
balapv,
glecaros,
johanste,
qubitron and
trrwilson
as code owners
Next Steps to MergeImportant checks have failed. As of today they are not blocking this PR, but in near future they may.Addressing the following failures is highly recommended:
Comment generated by summarize-checks workflow run. |
…rgilco/updates-to-support-python-file-upload-download
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
howieleung
approved these changes
Jun 22, 2026
…rgilco/updates-to-support-python-file-upload-download
dargilco
deleted the
dargilco/updates-to-support-python-file-upload-download
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does not affect the REST API spec. I allows emitted clients (Python in this case) to update the name of uploaded file path in the sandbox from "path" to something more descriptive like "remote_path". Python client will also have a method to read file directly from disk, and that file name will be called "file_path", so I would like to distinguish between local path to read and target (report) path where it will be stored.
Unfortunately the only way to do this rename in a separate client.tsp file is to define all the request element in a separate TypeSpec model and reference it when defining the operations. That's what I'm doing here for the file session operations.
I'll make a feature request from the emitter team to be able to directly rename an input argument of an operation, without the need to first declare it in a TypeSpec model.