Switch PAT to GitHub Apps#44257
Closed
chidozieononiwu wants to merge 2 commits into
Closed
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Comment generated by summarize-checks workflow run. |
chidozieononiwu
force-pushed
the
pat-to-github-apps
branch
2 times, most recently
from
9f95764 to
b2e8032
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
github-actions
Bot
added
TypeSpec
raych1
reviewed
Jun 29, 2026
raych1
reviewed
Jun 29, 2026
chidozieononiwu
force-pushed
the
pat-to-github-apps
branch
3 times, most recently
from
577b376 to
65c3732
Compare
chidozieononiwu
force-pushed
the
pat-to-github-apps
branch
from
65c3732 to
24963f4
Compare
raych1
reviewed
Jun 30, 2026
| - ${{ if and(eq(variables['System.TeamProject'], 'internal'), endsWith(variables['Build.Repository.Name'], '-pr')) }}: | ||
| - checkout: self | ||
| displayName: 'Sparse checkout eng/common/scripts for GitHub login' | ||
| path: s/_login_scripts |
Member
There was a problem hiding this comment.
I'd prefer no custom path to avoid cleanup step.
raych1
reviewed
Jun 30, 2026
| displayName: "Validate and update SDK repository commitish" | ||
|
|
||
| - ${{ if and(eq(variables['System.TeamProject'], 'internal'), endsWith(variables['Build.Repository.Name'], '-pr')) }}: | ||
| - checkout: self |
Member
There was a problem hiding this comment.
checkout: none + check: self is undocumented usage. It might not work with agent update.
raych1
reviewed
Jun 30, 2026
| Write-Host "##vso[task.setvariable variable=ReleasePlanInfo]$releasePlanInfo" | ||
| Write-Host "Release Plan Info: $releasePlanInfo" | ||
|
|
||
| - template: /eng/common/pipelines/templates/steps/git-push-changes.yml |
raych1
reviewed
Jun 30, 2026
|
|
||
| - ${{ if and(eq(variables['System.TeamProject'], 'internal'), eq(parameters.CreatePullRequest, true), ne(variables['Build.Reason'], 'PullRequest')) }}: | ||
| - template: /eng/common/pipelines/templates/steps/login-to-github.yml | ||
|
|
Member
There was a problem hiding this comment.
script path would need to be specified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Azure Pipelines archetype spec-gen SDK YAML template to improve GitHub authentication handling and standardize the use of authentication tokens. The main changes involve switching from the
azuresdk-github-patvariable toGH_TOKENfor GitHub authentication and ensuring the login step is explicitly included where needed.Authentication improvements:
azuresdk-github-patvariable withGH_TOKENfor GitHub authentication in steps that require repository access or pull request creation. [1] [2]Pipeline step updates:
/eng/common/pipelines/templates/steps/login-to-github.ymltemplate to relevant pipeline stages to ensure proper GitHub login when running in internal projects or when creating pull requests. [1] [2]