Skip to content

Commit 21e019a

Browse files
Copilotxinlian12
andcommitted
Migrate OfferQueryTest, ReadFeedOffersTest, ResourceTokenTest, GatewayServiceConfigurationReaderTest to rx.TestSuiteBase
Co-authored-by: xinlian12 <64233642+xinlian12@users.noreply.github.com>
1 parent 0162329 commit 21e019a

5 files changed

Lines changed: 16 additions & 16 deletions

File tree

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/directconnectivity/GatewayServiceConfigurationReaderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
import com.azure.cosmos.implementation.LifeCycleUtils;
1919
import com.azure.cosmos.implementation.RxDocumentClientImpl;
2020
import com.azure.cosmos.implementation.TestConfigurations;
21-
import com.azure.cosmos.implementation.TestSuiteBase;
21+
import com.azure.cosmos.rx.TestSuiteBase;
2222
import com.azure.cosmos.implementation.http.HttpClient;
2323
import org.mockito.ArgumentMatchers;
2424
import org.mockito.Mockito;
@@ -43,7 +43,7 @@ public class GatewayServiceConfigurationReaderTest extends TestSuiteBase {
4343
private String databaseAccountJson;
4444
private DatabaseAccount expectedDatabaseAccount;
4545

46-
@Factory(dataProvider = "clientBuilders")
46+
@Factory(dataProvider = "internalClientBuilders")
4747
public GatewayServiceConfigurationReaderTest(Builder clientBuilder) {
4848
super(clientBuilder);
4949
}

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/OfferQueryTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import com.azure.cosmos.implementation.QueryFeedOperationState;
1818
import com.azure.cosmos.implementation.ResourceType;
1919
import com.azure.cosmos.implementation.TestConfigurations;
20-
import com.azure.cosmos.implementation.TestSuiteBase;
2120
import com.azure.cosmos.implementation.TestUtils;
2221
import com.azure.cosmos.models.FeedResponse;
2322
import com.azure.cosmos.models.ModelBridgeInternal;
@@ -50,7 +49,7 @@ private String getDatabaseLink() {
5049
return TestUtils.getDatabaseNameLink(databaseId);
5150
}
5251

53-
@Factory(dataProvider = "clientBuilders")
52+
@Factory(dataProvider = "internalClientBuilders")
5453
public OfferQueryTest(Builder clientBuilder) {
5554
super(clientBuilder);
5655
}

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ReadFeedOffersTest.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import com.azure.cosmos.implementation.FeedResponseListValidator;
2323
import com.azure.cosmos.implementation.FeedResponseValidator;
2424
import com.azure.cosmos.implementation.Offer;
25-
import com.azure.cosmos.implementation.TestSuiteBase;
2625
import org.testng.annotations.AfterClass;
2726
import org.testng.annotations.BeforeClass;
2827
import org.testng.annotations.Factory;
@@ -35,7 +34,6 @@
3534
import java.util.UUID;
3635
import java.util.stream.Collectors;
3736

38-
//TODO: change to use external TestSuiteBase
3937
public class ReadFeedOffersTest extends TestSuiteBase {
4038

4139
protected static final int FEED_TIMEOUT = 60000;
@@ -49,7 +47,7 @@ public class ReadFeedOffersTest extends TestSuiteBase {
4947

5048
private AsyncDocumentClient client;
5149

52-
@Factory(dataProvider = "clientBuilders")
50+
@Factory(dataProvider = "internalClientBuilders")
5351
public ReadFeedOffersTest(AsyncDocumentClient.Builder clientBuilder) {
5452
super(clientBuilder);
5553
}

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/ResourceTokenTest.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
import com.azure.cosmos.implementation.ResourceResponse;
2424
import com.azure.cosmos.implementation.ResourceResponseValidator;
2525
import com.azure.cosmos.implementation.TestConfigurations;
26-
import com.azure.cosmos.implementation.TestSuiteBase;
2726
import com.azure.cosmos.implementation.TestUtils;
2827
import com.azure.cosmos.implementation.User;
2928
import com.azure.cosmos.models.CosmosQueryRequestOptions;
@@ -51,7 +50,6 @@
5150
*
5251
*/
5352

54-
// TODO change to use external TestSuiteBase
5553
public class ResourceTokenTest extends TestSuiteBase {
5654
public final String databaseId = DatabaseForTest.generateId();
5755

@@ -96,7 +94,7 @@ public class ResourceTokenTest extends TestSuiteBase {
9694
private static final String PERMISSION_FOR_DOC = "PermissionForDoc";
9795
private static final String PERMISSION_FOR_DOC_WITH_NAME = "PermissionForDocWithName";
9896

99-
@Factory(dataProvider = "clientBuilders")
97+
@Factory(dataProvider = "internalClientBuilders")
10098
public ResourceTokenTest(AsyncDocumentClient.Builder clientBuilder) {
10199
super(clientBuilder);
102100
}
@@ -277,7 +275,7 @@ public void readCollectionFromPermissionFeed(String collectionUrl, Permission pe
277275

278276
ResourceResponseValidator<DocumentCollection> validator = new ResourceResponseValidator.Builder<DocumentCollection>()
279277
.withId(createdCollection.getId()).build();
280-
validateSuccess(readObservable, validator);
278+
validateResourceResponseSuccess(readObservable, validator);
281279
} finally {
282280
safeClose(asyncClientResourceToken);
283281
}
@@ -319,7 +317,7 @@ public void readDocumentFromPermissionFeed(String documentUrl, Permission permis
319317
.readDocument(documentUrl, options);
320318
ResourceResponseValidator<Document> validator = new ResourceResponseValidator.Builder<Document>()
321319
.withId(documentId).build();
322-
validateSuccess(readObservable, validator);
320+
validateResourceResponseSuccess(readObservable, validator);
323321
} finally {
324322
safeClose(asyncClientResourceToken);
325323
}
@@ -350,7 +348,7 @@ public void readDocumentFromResouceToken(String resourceToken) throws Exception
350348
.readDocument(createdDocument.getSelfLink(), options);
351349
ResourceResponseValidator<Document> validator = new ResourceResponseValidator.Builder<Document>()
352350
.withId(createdDocument.getId()).build();
353-
validateSuccess(readObservable, validator);
351+
validateResourceResponseSuccess(readObservable, validator);
354352
} finally {
355353
safeClose(asyncClientResourceToken);
356354
}
@@ -386,7 +384,7 @@ public void readDocumentOfParKeyFromTwoCollPermissionWithDiffPartitionKeys(Strin
386384
.readDocument(documentUrl, options);
387385
ResourceResponseValidator<Document> validator = new ResourceResponseValidator.Builder<Document>()
388386
.withId(documentId).build();
389-
validateSuccess(readObservable, validator);
387+
validateResourceResponseSuccess(readObservable, validator);
390388
} finally {
391389
safeClose(asyncClientResourceToken);
392390
}
@@ -422,7 +420,7 @@ public void readDocumentFromCollPermissionWithDiffPartitionKey_ResourceNotFound(
422420
Mono<ResourceResponse<Document>> readObservable = asyncClientResourceToken
423421
.readDocument(documentUrl, options);
424422
FailureValidator validator = new FailureValidator.Builder().resourceNotFound().build();
425-
validateFailure(readObservable, validator);
423+
validateResourceResponseFailure(readObservable, validator);
426424
} finally {
427425
safeClose(asyncClientResourceToken);
428426
}
@@ -454,7 +452,7 @@ public void readDocumentFromCollPermissionWithDiffPartitionKey_WithException() t
454452
Mono<ResourceResponse<Document>> readObservable = asyncClientResourceToken
455453
.readDocument(createdDocumentWithPartitionKey.getSelfLink(), options);
456454
FailureValidator validator = new FailureValidator.Builder().resourceTokenNotFound().build();
457-
validateFailure(readObservable, validator);
455+
validateResourceResponseFailure(readObservable, validator);
458456
} finally {
459457
safeClose(asyncClientResourceToken);
460458
}

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/rx/TestSuiteBase.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,11 @@ public void beforeSuite() {
269269
SHARED_MULTI_PARTITION_COLLECTION_WITH_ID_AS_PARTITION_KEY = createCollection(SHARED_DATABASE, getCollectionDefinitionWithRangeRangeIndexWithIdAsPartitionKey(), options, 10100);
270270
SHARED_MULTI_PARTITION_COLLECTION_WITH_COMPOSITE_AND_SPATIAL_INDEXES = createCollection(SHARED_DATABASE, getCollectionDefinitionMultiPartitionWithCompositeAndSpatialIndexes(), options);
271271
SHARED_SINGLE_PARTITION_COLLECTION = createCollection(SHARED_DATABASE, getCollectionDefinitionWithRangeRangeIndex(), options, 6000);
272+
273+
// Initialize internal shared database for tests that use AsyncDocumentClient
274+
Database internalDb = new Database();
275+
internalDb.setId(SHARED_DATABASE.getId());
276+
SHARED_DATABASE_FOR_INTERNAL_CLIENT = internalDb;
272277
}
273278
}
274279

0 commit comments

Comments
 (0)