Removing boxed types for nregion property check (#48656)

* Removing boxed types for nregion property check

* updating javadoc and adding changelog

Author: mbhaskar

sdk/cosmos/azure-cosmos/CHANGELOG.md

@@ -7,6 +7,7 @@
 #### Breaking Changes
 
 #### Bugs Fixed
+Fixing an NPE caused due to boxed Boolean conversion. - See [PR 48656](https://github.com/Azure/azure-sdk-for-java/pull/48656/)
 
 #### Other Changes
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DatabaseAccount.java

@@ -302,19 +302,19 @@ public Boolean isPerPartitionFailoverBehaviorEnabled() {
 
     /**
      * Returns true if the account supports N region synchronous commit,
-     * false if enableNRegionSynchronousCommit evaluates to null or false.
+     * false otherwise
      * <p>
-     * If enableNRegionSynchronousCommit property does not exist in account metadata JSON payload, null is returned.
+     * If enableNRegionSynchronousCommit property does not exist in account metadata JSON payload, false is returned
      *
      * @return true if the account supports N region synchronous commit, false otherwise.
      */
-    public Boolean isNRegionSynchronousCommitEnabled() {
+    public boolean isNRegionSynchronousCommitEnabled() {
 
         if (super.has(Constants.Properties.ENABLE_N_REGION_SYNCHRONOUS_COMMIT)) {
             return ObjectUtils.defaultIfNull(super.getBoolean(Constants.Properties.ENABLE_N_REGION_SYNCHRONOUS_COMMIT), false);
         }
 
-        return null;
+        return false;
     }
 
     public void setIsPerPartitionFailoverBehaviorEnabled(boolean value) {

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/DocumentServiceRequestContext.java

@@ -275,7 +275,7 @@ public boolean getNRegionSynchronousCommitEnabled() {
         return nRegionSynchronousCommitEnabled;
     }
 
-    public void setNRegionSynchronousCommitEnabled(Boolean nRegionSynchronousCommitEnabled) {
+    public void setNRegionSynchronousCommitEnabled(boolean nRegionSynchronousCommitEnabled) {
         this.nRegionSynchronousCommitEnabled = nRegionSynchronousCommitEnabled;
     }
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/GlobalEndpointManager.java

@@ -438,11 +438,11 @@ public void setPerPartitionAutomaticFailoverConfigModifier(Consumer<DatabaseAcco
         this.perPartitionAutomaticFailoverConfigModifier = perPartitionAutomaticFailoverConfigModifier;
     }
 
-    public Boolean getNRegionSynchronousCommitEnabled() {
+    public boolean getNRegionSynchronousCommitEnabled() {
         this.databaseAccountReadLock.lock();
         try {
             if (this.latestDatabaseAccount == null) {
-                return null;
+                return false;
             }
             return this.latestDatabaseAccount.isNRegionSynchronousCommitEnabled();
         } finally {