Skip to content

Commit 4debc5f

Browse files
committed
Address PR review feedback for Spring workflow migration
1 parent cd0a5a2 commit 4debc5f

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

.github/workflows/update-spring-cloud-azure-support-file.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,11 @@ jobs:
3232
with:
3333
script: |
3434
const prTitle = process.env.PR_TITLE;
35-
const { data: pullRequests } = await github.rest.pulls.list({
35+
const pullRequests = await github.paginate(github.rest.pulls.list, {
3636
owner: context.repo.owner,
3737
repo: context.repo.repo,
38-
state: 'open'
38+
state: 'open',
39+
per_page: 100
3940
});
4041
4142
const openPRs = pullRequests.filter(pr => pr.title === prTitle);

sdk/spring/scripts/generate_spring_cloud_azure_support_file.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@ def main():
145145
cloud_version = existing.get("spring-cloud-version")
146146
if existing.get("supportStatus") != "END_OF_LIFE":
147147
cloud_version = find_compatible_spring_cloud_version(version, spring_cloud_ranges)
148+
if cloud_version == NONE_SUPPORTED and support_status == "SUPPORTED":
149+
# Keep matrix entries non-supported when Initializr does not provide a compatible Spring Cloud BOM.
150+
support_status = "TODO"
148151

149152
current_items.append(
150153
{

sdk/spring/scripts/generate_spring_versions_and_pr_description.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import argparse
55
import html
66
import json
7-
import os
87
import re
98
import urllib.error
109
import urllib.request

0 commit comments

Comments
 (0)