Address Copilot review: fix 3 missed static final fields, long lines, stale docs

- Removed remaining static final accessor fields in
  DocumentQueryExecutionContextFactory, CosmosQueryRequestOptionsBase,
  CosmosQueryRequestOptionsImpl
- Extracted local variables for long inline accessor chains in
  SessionTokenMismatchRetryPolicy, RxDocumentClientImpl,
  CosmosPagedFluxDefaultImpl
- Updated test Javadoc to reflect lazy accessor approach (not Class.forName)
- Reduced child JVM runs from 3 to 1 (invocationCount=5 provides repetition)
- Fixed CHANGELOG PR link to #48689

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: jeet1995

sdk/cosmos/azure-cosmos-tests/src/test/java/com/azure/cosmos/implementation/ImplementationBridgeHelpersTest.java

@@ -148,7 +148,7 @@ public void concurrentAccessorInitializationShouldNotDeadlock() throws Exception
         command.add(ConcurrentClinitChildProcess.class.getName());
 
         int timeoutSeconds = 30;
-        int runs = 3;
+        int runs = 1;
 
         for (int run = 1; run <= runs; run++) {
             final int currentRun = run;
@@ -286,15 +286,15 @@ public static void main(String[] args) {
     }
 
     /**
-     * Enforces that every class targeted by {@code ensureClassInitialized()} in
+     * Enforces that every {@code *Helper} inner class in
      * {@link ImplementationBridgeHelpers} registers its accessor during {@code <clinit>}
      * (i.e., has a {@code static { initialize(); }} block).
      * <p>
      * Verification is behavioral, not source-based: a forked child JVM iterates every
-     * {@code *Helper} inner class, calls each {@code getXxxAccessor()} getter (which triggers
-     * {@code Class.forName()} → {@code <clinit>}), and checks the accessor is non-null
-     * via reflection. If a class is missing {@code static { initialize(); }}, the accessor
-     * remains null and this test fails.
+     * {@code *Helper} inner class, calls each {@code getXxxAccessor()} getter (which
+     * lazily resolves the accessor), and checks the accessor is non-null via reflection.
+     * If a class is missing {@code static { initialize(); }}, the accessor remains null
+     * and this test fails.
      */
     @Test(groups = { "unit" })
     public void allAccessorClassesMustHaveStaticInitializerBlock() throws Exception {
@@ -361,8 +361,8 @@ public void allAccessorClassesMustHaveStaticInitializerBlock() throws Exception
     public static final class AccessorRegistrationChildProcess {
         public static void main(String[] args) throws Exception {
             // Iterate all *Helper inner classes in ImplementationBridgeHelpers.
-            // For each, call the getXxxAccessor() getter which triggers ensureClassInitialized()
-            // → Class.forName() → <clinit>. Then verify the accessor field is non-null.
+            // For each, call the getXxxAccessor() getter which lazily resolves the
+            // accessor (triggering <clinit> if needed). Then verify the accessor field is non-null.
 
             Class<?>[] helpers = ImplementationBridgeHelpers.class.getDeclaredClasses();
             List<String> failures = new ArrayList<>();
@@ -396,10 +396,10 @@ public static void main(String[] args) throws Exception {
                     continue;
                 }
 
-                // Find the target class name by looking for a getXxxAccessor method that calls
-                // ensureClassInitialized. We can't easily extract the string constant, so instead
+                // Find the target class name by looking for a getXxxAccessor method that lazily
+                // resolves the accessor. We can't easily extract the string constant, so instead
                 // we call the getter and check if the accessor becomes non-null.
-                // The getter calls ensureClassInitialized() → Class.forName() → <clinit>.
+                // The getter lazily triggers <clinit> of the target class if needed.
                 // If <clinit> calls initialize(), the accessor is registered.
                 java.lang.reflect.Method getterMethod = null;
                 for (java.lang.reflect.Method m : helper.getDeclaredMethods()) {

sdk/cosmos/azure-cosmos/CHANGELOG.md

@@ -8,7 +8,7 @@
 
 #### Bugs Fixed
 * Fixing an NPE caused due to boxed Boolean conversion. - See [PR 48656](https://github.com/Azure/azure-sdk-for-java/pull/48656/)
-* Fixed JVM `<clinit>` deadlock when multiple threads concurrently trigger Cosmos SDK class loading for the first time. - See [PR 48667](https://github.com/Azure/azure-sdk-for-java/pull/48667)
+* Fixed JVM `<clinit>` deadlock when multiple threads concurrently trigger Cosmos SDK class loading for the first time. - See [PR 48689](https://github.com/Azure/azure-sdk-for-java/pull/48689)
 
 #### Other Changes
 

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosQueryRequestOptionsBase.java

@@ -29,9 +29,6 @@
  * in the Azure Cosmos DB database service.
  */
 public abstract class CosmosQueryRequestOptionsBase<T extends CosmosQueryRequestOptionsBase<?>> implements OverridableRequestOptions {
-    private final static ImplementationBridgeHelpers.CosmosDiagnosticsThresholdsHelper.CosmosDiagnosticsThresholdsAccessor thresholdsAccessor =
-        ImplementationBridgeHelpers.CosmosDiagnosticsThresholdsHelper.getCosmosDiagnosticsThresholdsAccessor();
-
     private ConsistencyLevel consistencyLevel;
     private ReadConsistencyStrategy readConsistencyStrategy;
     private String sessionToken;
@@ -373,7 +370,9 @@ public Duration getThresholdForDiagnosticsOnTracer() {
             return CosmosDiagnosticsThresholds.DEFAULT_NON_POINT_OPERATION_LATENCY_THRESHOLD;
         }
 
-        return thresholdsAccessor.getNonPointReadLatencyThreshold(this.thresholds);
+        return ImplementationBridgeHelpers.CosmosDiagnosticsThresholdsHelper
+            .getCosmosDiagnosticsThresholdsAccessor()
+            .getNonPointReadLatencyThreshold(this.thresholds);
     }
 
     /**

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/CosmosQueryRequestOptionsImpl.java

@@ -13,8 +13,6 @@
 import java.util.List;
 
 public final class CosmosQueryRequestOptionsImpl extends CosmosQueryRequestOptionsBase<CosmosQueryRequestOptionsImpl> {
-    private final static ImplementationBridgeHelpers.CosmosDiagnosticsThresholdsHelper.CosmosDiagnosticsThresholdsAccessor thresholdsAccessor =
-        ImplementationBridgeHelpers.CosmosDiagnosticsThresholdsHelper.getCosmosDiagnosticsThresholdsAccessor();
     private String partitionKeyRangeId;
     private Boolean scanInQueryEnabled;
     private Boolean emitVerboseTracesInQuery;