Skip to content

Commit 67d6dcb

Browse files
ronniegeraghtyCopilot
authored andcommitted
Fix semantic skill-to-instruction mappings after deep review
Changes based on semantic analysis of skill/instruction purpose alignment: - check-package-validation: Remove incorrect related_skill reference to generate-sdk-locally. Validation is a narrow sub-step; pointing users at the full generation workflow is misleading. Added redundancy note instead. - typespec-to-sdk: Add missing pipeline-troubleshooting and apiview-feedback-resolution skills to the orchestrator. This is the entry point where users discover their options after TypeSpec work is merged — all journey skills should be discoverable here. Also added inline references at the exact workflow steps where those skills apply. - create-release-plan: Add missing frontmatter with related_skill (had blockquote but no structured metadata). - copilot/sdk-release: Add missing frontmatter with related_skill (had blockquote but no structured metadata). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 91588b4 commit 67d6dcb

4 files changed

Lines changed: 20 additions & 4 deletions

File tree

eng/common/instructions/azsdk-tools/check-package-validation.instructions.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
---
22
description: 'Run the package validation checks for the SDK package.'
3-
related_skill: "azsdk-common-generate-sdk-locally"
43
---
54

6-
> **Related Skill:** See `.github/skills/azsdk-common-generate-sdk-locally/SKILL.md` — package validation is Step 5 of the generate-build-test workflow.
5+
> **Note:** This instruction file covers package validation in isolation. For the full
6+
> generate → build → customize → validate → test → metadata workflow, see
7+
> `local-sdk-workflow.instructions.md` or the `azsdk-common-generate-sdk-locally` skill.
8+
> This file may be redundant if all its guidance is already covered by that skill (Step 5).
79
810
## Goal
911
Run the validation checks for the SDK package by collecting the required information from the user and executing the `azsdk_package_run_check` tool.

eng/common/instructions/azsdk-tools/create-release-plan.instructions.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
---
2+
description: 'Create and manage release plans for Azure SDK releases'
3+
related_skill: "azsdk-common-prepare-release-plan"
4+
---
5+
16
> **Related Skill:** See `.github/skills/azsdk-common-prepare-release-plan/SKILL.md` for the high-level release plan workflow and MCP tool reference. This instruction file provides the detailed step-by-step interaction flow.
27
38
> **CRITICAL INSTRUCTIONS FOR LLM**

eng/common/instructions/azsdk-tools/typespec-to-sdk.instructions.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,16 @@ related_skills:
44
- "azsdk-common-generate-sdk-locally"
55
- "azsdk-common-prepare-release-plan"
66
- "azsdk-common-sdk-release"
7+
- "azsdk-common-pipeline-troubleshooting"
8+
- "azsdk-common-apiview-feedback-resolution"
79
---
810

911
> **Related Skills:** This orchestration workflow references multiple shared skills:
1012
> - `.github/skills/azsdk-common-generate-sdk-locally/SKILL.md` — SDK generation, build, and test
1113
> - `.github/skills/azsdk-common-prepare-release-plan/SKILL.md` — Release plan creation and management
1214
> - `.github/skills/azsdk-common-sdk-release/SKILL.md` — Release readiness checks and publishing
15+
> - `.github/skills/azsdk-common-pipeline-troubleshooting/SKILL.md` — CI/generation pipeline failure diagnosis
16+
> - `.github/skills/azsdk-common-apiview-feedback-resolution/SKILL.md` — Resolve APIView review feedback on SDK PRs
1317
1418
Your goal is to guide the user through the process of generating SDKs from TypeSpec projects. **Before starting**, show all the high level steps to the user and ask:
1519

@@ -61,8 +65,8 @@ Follow the steps in #file:local-sdk-workflow.instructions.md to generate and bui
6165
For data plane: `Python`, `.NET`, `JavaScript`, `Java`
6266
- Each SDK generation tool call should show a label to indicate the language being generated.
6367
2. Monitor pipeline status after 15 minutes and provide updates. If pipeline is in progress, inform user that it may take additional time and check the status later.
64-
3. Display generated SDK PR links when available. If pipeline fails, inform user with error details and suggest to check pipeline logs for more information.
65-
4. If SDK pull request is available for all languages, ask user to review generated SDK pull request and mark them as ready for review when they are ready to get them reviewed and merged.
68+
3. Display generated SDK PR links when available. If pipeline fails, inform user with error details and suggest to check pipeline logs for more information. Use the `azsdk-common-pipeline-troubleshooting` skill to diagnose and resolve pipeline failures.
69+
4. If SDK pull request is available for all languages, ask user to review generated SDK pull request and mark them as ready for review when they are ready to get them reviewed and merged. If APIView feedback is received, use the `azsdk-common-apiview-feedback-resolution` skill to analyze and resolve review comments.
6670
5. Inform the user that they can checkout generated SDK pull request locally and add more tests, samples or code customizations if needed using local SDK generation tools.
6771
6. If SDK pull request was created for test purposes, inform user to close the test SDK pull request.
6872
**Success Criteria**: SDK generation pipeline initiated and SDKs generated

eng/common/instructions/copilot/sdk-release.instructions.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
---
2+
description: 'SDK release readiness and publishing'
3+
related_skill: "azsdk-common-sdk-release"
4+
---
5+
16
# SDK release
27

38
> **Related Skill:** See `.github/skills/azsdk-common-sdk-release/SKILL.md` for the complete release workflow with step-by-step guidance and troubleshooting.

0 commit comments

Comments
 (0)