privatedns: migrate azure-resourcemanager-privatedns from Swagger to TypeSpec (#48807)

Author: weidongxu-microsoft

eng/lintingconfigs/revapi/track2/revapi.json

@@ -1686,6 +1686,14 @@
             "match": "method .* com\\.azure\\.resourcemanager\\.msi\\.models\\.OperationDisplay\\:\\:with.*\\(.*\\).*"
           },
           "justification": "Output-only immutable models' setters are removed if no explicit usage."
+        },
+        {
+          "code": "java.class.removed",
+          "old" : {
+            "matcher": "regex",
+            "match": "class com\\.azure\\.resourcemanager\\.privatedns\\.models\\.(PrivateZoneListResult|RecordSetListResult|VirtualNetworkLinkListResult)"
+          },
+          "justification": "Pageable models moved to implementation package. Unlikely used by user."
         }
       ]
     }

sdk/privatedns/azure-resourcemanager-privatedns/README.md

@@ -18,7 +18,7 @@ For documentation on how to use this package, please see [Azure Management Libra
 <dependency>
     <groupId>com.azure.resourcemanager</groupId>
     <artifactId>azure-resourcemanager-privatedns</artifactId>
-    <version>2.53.1</version>
+    <version>2.54.0-beta.1</version>
 </dependency>
 ```
 [//]: # ({x-version-update-end})

sdk/privatedns/azure-resourcemanager-privatedns/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "java",
   "TagPrefix": "java/privatedns/azure-resourcemanager-privatedns",
-  "Tag": "java/privatedns/azure-resourcemanager-privatedns_10a66c0c1b"
+  "Tag": "java/privatedns/azure-resourcemanager-privatedns_0b06b6a1db"
 }

sdk/privatedns/azure-resourcemanager-privatedns/src/main/java/com/azure/resourcemanager/privatedns/fluent/PrivateDnsManagementClient.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
-// Code generated by Microsoft (R) AutoRest Code Generator.
+// Code generated by Microsoft (R) TypeSpec Code Generator.
 
 package com.azure.resourcemanager.privatedns.fluent;
 
@@ -12,27 +12,26 @@
  */
 public interface PrivateDnsManagementClient {
     /**
-     * Gets Gets subscription credentials which uniquely identify Microsoft Azure subscription. The subscription ID
-     * forms part of the URI for every service call.
-     * 
-     * @return the subscriptionId value.
-     */
-    String getSubscriptionId();
-
-    /**
-     * Gets server parameter.
+     * Gets Service host.
      * 
      * @return the endpoint value.
      */
     String getEndpoint();
 
     /**
-     * Gets Api Version.
+     * Gets Version parameter.
      * 
      * @return the apiVersion value.
      */
     String getApiVersion();
 
+    /**
+     * Gets The ID of the target subscription. The value must be an UUID.
+     * 
+     * @return the subscriptionId value.
+     */
+    String getSubscriptionId();
+
     /**
      * Gets The HTTP pipeline to send requests through.
      * 
@@ -47,6 +46,13 @@ public interface PrivateDnsManagementClient {
      */
     Duration getDefaultPollInterval();
 
+    /**
+     * Gets the RecordSetsClient object to access its operations.
+     * 
+     * @return the RecordSetsClient object.
+     */
+    RecordSetsClient getRecordSets();
+
     /**
      * Gets the PrivateZonesClient object to access its operations.
      * 
@@ -60,11 +66,4 @@ public interface PrivateDnsManagementClient {
      * @return the VirtualNetworkLinksClient object.
      */
     VirtualNetworkLinksClient getVirtualNetworkLinks();
-
-    /**
-     * Gets the RecordSetsClient object to access its operations.
-     * 
-     * @return the RecordSetsClient object.
-     */
-    RecordSetsClient getRecordSets();
 }

sdk/privatedns/azure-resourcemanager-privatedns/src/main/java/com/azure/resourcemanager/privatedns/fluent/PrivateZonesClient.java

@@ -1,12 +1,12 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
-// Code generated by Microsoft (R) AutoRest Code Generator.
+// Code generated by Microsoft (R) TypeSpec Code Generator.
 
 package com.azure.resourcemanager.privatedns.fluent.models;
 
 import com.azure.core.annotation.Fluent;
 import com.azure.core.management.Resource;
-import com.azure.core.util.logging.ClientLogger;
+import com.azure.core.management.SystemData;
 import com.azure.json.JsonReader;
 import com.azure.json.JsonToken;
 import com.azure.json.JsonWriter;
@@ -19,15 +19,30 @@
  */
 @Fluent
 public final class PrivateZoneInner extends Resource {
+    /*
+     * Properties of the Private DNS zone.
+     */
+    private PrivateZoneProperties innerProperties;
+
+    /*
+     * Resource tags.
+     */
+    private Map<String, String> tags;
+
+    /*
+     * The Azure Region where the resource lives
+     */
+    private String location;
+
     /*
      * The ETag of the zone.
      */
     private String etag;
 
     /*
-     * Properties of the Private DNS zone.
+     * Azure Resource Manager metadata containing createdBy and modifiedBy information.
      */
-    private PrivateZoneProperties innerProperties;
+    private SystemData systemData;
 
     /*
      * The type of the resource.
@@ -50,6 +65,55 @@ public final class PrivateZoneInner extends Resource {
     public PrivateZoneInner() {
     }
 
+    /**
+     * Get the innerProperties property: Properties of the Private DNS zone.
+     * 
+     * @return the innerProperties value.
+     */
+    private PrivateZoneProperties innerProperties() {
+        return this.innerProperties;
+    }
+
+    /**
+     * Get the tags property: Resource tags.
+     * 
+     * @return the tags value.
+     */
+    public Map<String, String> tags() {
+        return this.tags;
+    }
+
+    /**
+     * Set the tags property: Resource tags.
+     * 
+     * @param tags the tags value to set.
+     * @return the PrivateZoneInner object itself.
+     */
+    public PrivateZoneInner withTags(Map<String, String> tags) {
+        this.tags = tags;
+        return this;
+    }
+
+    /**
+     * Get the location property: The Azure Region where the resource lives.
+     * 
+     * @return the location value.
+     */
+    public String location() {
+        return this.location;
+    }
+
+    /**
+     * Set the location property: The Azure Region where the resource lives.
+     * 
+     * @param location the location value to set.
+     * @return the PrivateZoneInner object itself.
+     */
+    public PrivateZoneInner withLocation(String location) {
+        this.location = location;
+        return this;
+    }
+
     /**
      * Get the etag property: The ETag of the zone.
      * 
@@ -71,12 +135,12 @@ public PrivateZoneInner withEtag(String etag) {
     }
 
     /**
-     * Get the innerProperties property: Properties of the Private DNS zone.
+     * Get the systemData property: Azure Resource Manager metadata containing createdBy and modifiedBy information.
      * 
-     * @return the innerProperties value.
+     * @return the systemData value.
      */
-    private PrivateZoneProperties innerProperties() {
-        return this.innerProperties;
+    public SystemData systemData() {
+        return this.systemData;
     }
 
     /**
@@ -109,24 +173,6 @@ public String id() {
         return this.id;
     }
 
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public PrivateZoneInner withLocation(String location) {
-        super.withLocation(location);
-        return this;
-    }
-
-    /**
-     * {@inheritDoc}
-     */
-    @Override
-    public PrivateZoneInner withTags(Map<String, String> tags) {
-        super.withTags(tags);
-        return this;
-    }
-
     /**
      * Get the maxNumberOfRecordSets property: The maximum number of record sets that can be created in this Private DNS
      * zone. This is a read-only property and any attempt to set this value will be ignored.
@@ -221,24 +267,18 @@ public void validate() {
         if (innerProperties() != null) {
             innerProperties().validate();
         }
-        if (location() == null) {
-            throw LOGGER.atError()
-                .log(new IllegalArgumentException("Missing required property location in model PrivateZoneInner"));
-        }
     }
 
-    private static final ClientLogger LOGGER = new ClientLogger(PrivateZoneInner.class);
-
     /**
      * {@inheritDoc}
      */
     @Override
     public JsonWriter toJson(JsonWriter jsonWriter) throws IOException {
         jsonWriter.writeStartObject();
-        jsonWriter.writeStringField("location", location());
-        jsonWriter.writeMapField("tags", tags(), (writer, element) -> writer.writeString(element));
-        jsonWriter.writeStringField("etag", this.etag);
         jsonWriter.writeJsonField("properties", this.innerProperties);
+        jsonWriter.writeMapField("tags", this.tags, (writer, element) -> writer.writeString(element));
+        jsonWriter.writeStringField("location", this.location);
+        jsonWriter.writeStringField("etag", this.etag);
         return jsonWriter.writeEndObject();
     }
 
@@ -264,15 +304,17 @@ public static PrivateZoneInner fromJson(JsonReader jsonReader) throws IOExceptio
                     deserializedPrivateZoneInner.name = reader.getString();
                 } else if ("type".equals(fieldName)) {
                     deserializedPrivateZoneInner.type = reader.getString();
-                } else if ("location".equals(fieldName)) {
-                    deserializedPrivateZoneInner.withLocation(reader.getString());
+                } else if ("properties".equals(fieldName)) {
+                    deserializedPrivateZoneInner.innerProperties = PrivateZoneProperties.fromJson(reader);
                 } else if ("tags".equals(fieldName)) {
                     Map<String, String> tags = reader.readMap(reader1 -> reader1.getString());
-                    deserializedPrivateZoneInner.withTags(tags);
+                    deserializedPrivateZoneInner.tags = tags;
+                } else if ("location".equals(fieldName)) {
+                    deserializedPrivateZoneInner.location = reader.getString();
                 } else if ("etag".equals(fieldName)) {
                     deserializedPrivateZoneInner.etag = reader.getString();
-                } else if ("properties".equals(fieldName)) {
-                    deserializedPrivateZoneInner.innerProperties = PrivateZoneProperties.fromJson(reader);
+                } else if ("systemData".equals(fieldName)) {
+                    deserializedPrivateZoneInner.systemData = SystemData.fromJson(reader);
                 } else {
                     reader.skipChildren();
                 }

sdk/privatedns/azure-resourcemanager-privatedns/src/main/java/com/azure/resourcemanager/privatedns/fluent/RecordSetsClient.java

@@ -1,6 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
-// Code generated by Microsoft (R) AutoRest Code Generator.
+// Code generated by Microsoft (R) TypeSpec Code Generator.
 
 package com.azure.resourcemanager.privatedns.fluent.models;