You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+14-12Lines changed: 14 additions & 12 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,9 +11,9 @@ Thank you for your interest in contributing to Azure SDK for Java.
11
11
12
12
- After cloning the repo, copy the [pre-commit hooks file](https://github.com/Azure/azure-sdk-for-java/tree/main/eng/scripts/pre-commit) (located at `eng/scripts/pre-commit`) to your local `.git/hooks/` directory. This will run some validations before your changes are committed.
13
13
14
-
- Refer to the [wiki](https://github.com/Azure/azure-sdk-for-java/wiki/Building#testing-for-spotbugs-and-checkstyle-issues) to learn about how Azure SDK for java generates CheckStyle, SpotBugs, Jacoco, and JavaDoc reports.
14
+
- Refer to the [Code Quality guide](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/docs/contributor/code-quality.md) to learn about how Azure SDK for Java generates CheckStyle, SpotBugs, JaCoCo, and JavaDoc reports.
15
15
16
-
- There are two Maven projects in the repo. Refer to the [wiki](https://github.com/Azure/azure-sdk-for-java/wiki/Building#pomclientxml-vs-pomdataxml) to learn about project structure for each.
16
+
- There are two Maven projects in the repo. Refer to the [Building guide](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/docs/contributor/building.md) to learn about project structure for each.
See [Getting Started](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/docs/contributor/getting-started.md) for detailed environment setup instructions.
55
+
54
56
>**Note:** If you ran into "long path" issue on `Windows`, enable paths longer than 260 characters by: <br><br>
55
57
1.- Run this as Administrator on a command prompt:<br>
56
58
`REG ADD HKLM\SYSTEM\CurrentControlSet\Control\FileSystem /v LongPathsEnabled /t REG_DWORD /d 1`<br>*(might need to type `yes` to override key if it already exists)*<br><br>
@@ -147,9 +149,9 @@ If you encounter a `401 Unauthorized` error when running Maven commands:
147
149
148
150
### Building and Unit Testing
149
151
150
-
Refer to the [build wiki](https://github.com/Azure/azure-sdk-for-java/wiki/Building) for learning how to build Java SDKs
151
-
and the [unit testing wiki](https://github.com/Azure/azure-sdk-for-java/wiki/Unit-Testing) for guidelines on unit
152
-
testing.
152
+
Refer to the [Building guide](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/docs/contributor/building.md) for Maven commands to build the SDK,
153
+
and the [Unit Testing guide](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/docs/contributor/unit-testing.md) for guidelines on writing and running unit tests.
154
+
153
155
154
156
### Live testing
155
157
@@ -162,7 +164,7 @@ To see what resources will be deployed for a live service, check the
162
164
`test-resources.json` ARM template files in the service you wish to deploy for
163
165
testing, for example `sdk\keyvault\test-resources.json`.
164
166
165
-
To deploy live resources for testing use the steps documented in [`Example 1 of New-TestResources.ps1`](https://github.com/Azure/azure-sdk-for-java/blob/main/eng/common/TestResources/New-TestResources.ps1.md#example-1)
167
+
To deploy live resources for testing use the steps documented in [`Example 1 of New-TestResources.ps1`](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/eng/common/TestResources/New-TestResources.ps1.md#example-1)
166
168
to set up a service principal and deploy live testing resources.
167
169
168
170
The script will provide instructions for setting environment variables before
@@ -180,7 +182,7 @@ information or instructions.
180
182
181
183
## Versions and versioning
182
184
183
-
Tooling has been introduced to centralize versioning and help ease the pain of updating artifact versions in POM and README files. Under the eng\versioning directory there exists a version text file for libraries ([version_client.txt](https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/version_client.txt)).
185
+
Tooling has been introduced to centralize versioning and help ease the pain of updating artifact versions in POM and README files. Under the eng\versioning directory there exists a version text file for libraries ([version_client.txt](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/eng/versioning/version_client.txt)).
@@ -240,7 +242,7 @@ Similarly, libraries built as part of the same pipeline, that have interdependen
240
242
azure-batch pipeline when `com.azure:azure-storage-blob` is declared as a dependency of `com.azure:azure-storage-blob-batch` it should be the *Current* version.
241
243
242
244
**An example of an Unreleased Dependency version:** Additive, not breaking, API changes have been made to `com.azure:azure-core`. `com.azure:azure-storage-blob` has a dependency on `com.azure:azure-core` and requires the additive
243
-
API change that has not yet been released. An unreleased entry needs to be created in [version_client.txt](https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/version_client.txt), under the unreleased section, with the following format: `unreleased_<groupId>:<artifactId>;dependency-version`,
245
+
API change that has not yet been released. An unreleased entry needs to be created in [version_client.txt](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/eng/versioning/version_client.txt), under the unreleased section, with the following format: `unreleased_<groupId>:<artifactId>;dependency-version`,
244
246
in this example that would be `unreleased_com.azure:azure-core;1.2.0` (this should match the 'current' version of core). The dependency update tags in the pom files that required this dependency would now reference
245
247
`{x-version-update;unreleased_com.azure:azure-core;dependency}`. Once the updated library has been released the unreleased dependency version should be removed and the POM file update tags should be referencing the released version.
246
248
@@ -284,7 +286,7 @@ Let's say we've GA'd and I need to tick up the version of azure-storage librarie
284
286
1. I'd open up eng\versioning\version_client.txt and update the current-versions of the libraries that are built and released as part of the azure storage pipeline. This list can be found in pom.service.xml under the sdk/storage directory.
285
287
It's worth noting that any module entry starting with "../" are external module dependencies and not something that's released as part of the pipeline. Dependencies for library components outside a given area would be downloading the
286
288
appropriate dependency from Maven like we do for external dependencies.
287
-
2. Execute the update_versions python script from the root of the enlistment. The exact syntax and commands will vary based upon what is being changed and some examples can be found in the use cases in the [update_versions.py](https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/update_versions.py#L6) file.
289
+
2. Execute the update_versions python script from the root of the enlistment. The exact syntax and commands will vary based upon what is being changed and some examples can be found in the use cases in the [update_versions.py](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/eng/versioning/update_versions.py#L6) file.
288
290
3. Review and submit a PR with the modified files.
289
291
290
292
### Next steps: Management plane
@@ -296,11 +298,11 @@ Let's say we've GA'd and I need to tick up the version of azure-storage librarie
296
298
This is where the `unreleased_` dependency tags come into play. Using the Unreleased Dependency example above, where `com.azure:azure-storage-blob` has a dependency on an unreleased `com.azure:azure-core`:
297
299
298
300
-[ ] Make the additive changes to `com.azure:azure-core`
299
-
-[ ] In [version_client.txt](https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/version_client.txt) add the entry for the unreleased azure core in the unreleased section at the bottom of the file. The entry would look like `unreleased_com.azure:azure-core;<version>`.
301
+
-[ ] In [version_client.txt](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/eng/versioning/version_client.txt) add the entry for the unreleased azure core in the unreleased section at the bottom of the file. The entry would look like `unreleased_com.azure:azure-core;<version>`.
300
302
Note: The version of the library referenced in the unreleased version tag should match the current version of that library.
301
303
-[ ] In the pom.xml file for `com.azure:azure-storage-blob`, the dependency tag for `com.azure:azure-core` which was originally `{x-version-update;com.azure:azure-core-test;dependency}` would now become `{x-version-update;unreleased_com.azure:azure-core-test;dependency}`
302
304
After the unreleased version of `com.azure:azure-core` was released but before `com.azure:azure-storage-blob` has been released.
303
-
-[ ] In [version_client.txt](https://github.com/Azure/azure-sdk-for-java/blob/main/eng/versioning/version_client.txt) the dependency version of `com.azure:azure-core` would become the released version and the "unreleased_" entry, at this time, would be removed.
305
+
-[ ] In [version_client.txt](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/eng/versioning/version_client.txt) the dependency version of `com.azure:azure-core` would become the released version and the "unreleased_" entry, at this time, would be removed.
304
306
-[ ] In the pom.xml file for `com.azure:azure-storage-blob`, the dependency tag for `com.azure:azure-core` would get changed back to `{x-version-update;com.azure:azure-core-test;dependency}`
Copy file name to clipboardExpand all lines: README.md
+4-7Lines changed: 4 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -67,6 +67,8 @@ Format of the release tags are `<package-name>_<package-version>`. For more info
67
67
68
68
For details on contributing to this repository, see the [contributing guide](https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.md).
69
69
70
+
The consolidated documentation hub for contributors (building, testing, versioning, release checklist, etc.) is at [`docs/`](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/docs/README.md).
71
+
70
72
This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, view [Microsoft's CLA](https://cla.microsoft.com).
71
73
72
74
When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repositories using our CLA.
@@ -78,7 +80,7 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
78
80
Many people all over the world have helped make this project better. You'll want to check out:
79
81
80
82
-[What are some good first issues for new contributors to the repo?](https://github.com/azure/azure-sdk-for-java/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22)
81
-
-[How to build and test your change](https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.md#developer-guide)
83
+
-[How to build and test your change](https://github.com/g2vinay/azure-sdk-for-java/blob/consolidate-docs-v2/docs/contributor/building.md)
82
84
-[How you can make a change happen!](https://github.com/Azure/azure-sdk-for-java/blob/main/CONTRIBUTING.md#pull-requests)
83
85
- Frequently Asked Questions (FAQ) and Conceptual Topics in the detailed [Azure SDK for Java wiki](https://github.com/azure/azure-sdk-for-java/wiki).
84
86
@@ -92,12 +94,7 @@ Azure SDK for Java is licensed under the [MIT](https://github.com/Azure/azure-sd
0 commit comments