Skip to content

regen w new SHA + customizations#48479

Open
idickerson7 wants to merge 36 commits intomainfrom
idickers/2026-04-01-java-sdk
Open

regen w new SHA + customizations#48479
idickerson7 wants to merge 36 commits intomainfrom
idickers/2026-04-01-java-sdk

Conversation

@idickerson7
Copy link
Copy Markdown
Member

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samvaity, what's the latest guidance for service / SDK specific tools in the repository again?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the breaking changes in this file a one-time thing? If not, we may need to discuss this across languages to just mark the unsupported values as deprecated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure:azure-search-documents

@idickerson7 idickerson7 marked this pull request as ready for review March 25, 2026 18:57
@idickerson7 idickerson7 requested review from a team as code owners March 25, 2026 18:57
Copilot AI review requested due to automatic review settings March 25, 2026 18:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to regenerate the Azure Search Documents SDK from an updated spec/tag and apply customizations, resulting in a large set of model/API surface changes and newly generated request “Accept” enums.

Changes:

  • Updated generated models and service versioning (adds 2026-04-01, changes multiple model fields/types).
  • Removed a number of previously-generated types/properties (debug, indexing, knowledge-store, SharePoint-related, etc.).
  • Added many generated “Accept” header enums in both public models and implementation.models packages.

Reviewed changes

Copilot reviewed 165 out of 201 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/SearchDocumentsResult.java Removes debug/query-rewrite related fields and deserialization branches.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/QuerySpellerType.java Deletes speller enum model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/QueryRewritesValuesDebugInfo.java Deletes query rewrite debug info model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/QueryRewritesType.java Deletes query rewrites type enum model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/QueryRewritesDebugInfo.java Deletes query rewrite debug info model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/QueryResultDocumentSemanticField.java Deletes semantic field debug model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/QueryResultDocumentRerankerInput.java Deletes reranker input debug model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/QueryResultDocumentInnerHit.java Deletes inner-hit debug model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/HybridCountAndFacetMode.java Deletes hybrid count/facet mode enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/FacetResult.java Removes metric/nested facet fields from facet result parsing and API.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/DocumentDebugInfo.java Removes semantic/innerHits debug info from document debug payload.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/DebugInfo.java Removes query rewrite debug info from overall debug payload.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept1.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept2.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept4.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept6.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept7.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept8.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept9.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept10.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept11.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept12.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept14.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept15.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept16.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept17.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept19.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept20.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept21.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept22.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept24.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept25.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept26.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept27.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept28.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept29.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept31.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept32.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept34.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept35.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept36.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept38.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept39.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept41.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept42.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept44.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept45.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept47.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CreateOrUpdateRequestAccept48.java Adds generated Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CountRequestAccept.java Adds generated count Accept enum (public models).
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CountRequestAccept2.java Adds generated count Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CountRequestAccept3.java Adds generated count Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CountRequestAccept5.java Adds generated count Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/models/CountRequestAccept8.java Adds generated count Accept enum (public models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/WebKnowledgeSourceParams.java Removes alwaysQuerySource from JSON and fluent overrides.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/SynchronizationState.java Adds errors collection, changes to @Fluent, updates JSON handling.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/SearchIndexKnowledgeSourceParams.java Removes alwaysQuerySource from JSON and fluent overrides.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeSourceStatus.java Adds kind field to status payload and fluent accessors.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeSourceParams.java Removes alwaysQuerySource and some discriminators from deserialization.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeRetrievalReasoningEffortKind.java Removes LOW/MEDIUM constants.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeRetrievalReasoningEffort.java Narrows constructor to protected, removes low/medium subtypes from discriminator.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeRetrievalOutputMode.java Deletes retrieval output mode enum model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeRetrievalMinimalReasoningEffort.java Makes constructor private (instantiation controlled by class).
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeRetrievalLowReasoningEffort.java Deletes low reasoning effort subtype.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeRetrievalMediumReasoningEffort.java Deletes medium reasoning effort subtype.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseReferenceType.java Removes SharePoint reference type constants.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseReference.java Removes SharePoint subtypes from discriminator deserialization.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseModelQueryPlanningActivityRecord.java Deletes activity record subtype.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseModelAnswerSynthesisActivityRecord.java Deletes activity record subtype.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseIndexedSharePointReference.java Deletes SharePoint reference subtype.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseActivityRecordType.java Removes SharePoint/model activity constants.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/KnowledgeBaseActivityRecord.java Removes discriminator branches for model planning/synthesis subtypes.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/IndexedOneLakeKnowledgeSourceParams.java Removes alwaysQuerySource from JSON and fluent overrides.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/knowledgebases/models/AzureBlobKnowledgeSourceParams.java Removes alwaysQuerySource from JSON and fluent overrides.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/VectorSearchVectorizer.java Removes aiServicesVision vectorizer discriminator branch.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SplitSkillUnit.java Deletes split skill unit enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SplitSkillEncoderModelName.java Deletes tokenizer model name enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SplitSkill.java Removes unit/tokenizer parameters from model and JSON.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SentimentSkillV3.java Changes defaultLanguageCode from String to SentimentSkillLanguage.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SentimentSkillLanguage.java Adds typed language codes enum for Sentiment skill.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SemanticConfiguration.java Removes flightingOptIn flag from model and JSON.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchServiceStatistics.java Removes indexersRuntime from model and JSON parsing.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndexerStatus.java Removes runtime and currentState from indexer status model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndexerSkill.java Removes AML/Vision skill discriminator branches.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndexerKnowledgeStoreParameters.java Deletes knowledge store parameters model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndexerKnowledgeStore.java Removes knowledge store parameters field from model and JSON.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndexer.java Removes cache field from model and JSON.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndexPermissionFilterOption.java Deletes permission filter option enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchIndex.java Removes permission filtering and Purview flags.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/SearchField.java Removes permissionFilter and sensitivityLabel fields.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/PermissionFilter.java Deletes permission filter enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/KnowledgeSourceKind.java Removes SharePoint knowledge source kinds.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/KnowledgeSource.java Removes SharePoint subtypes from discriminator deserialization.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/IndexingMode.java Deletes indexing mode enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/IndexerPermissionOption.java Deletes indexer permission enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/IndexerExecutionStatusDetail.java Deletes execution status detail enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/IndexerExecutionResult.java Removes statusDetail and mode from execution result.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/IndexedSharePointKnowledgeSource.java Deletes SharePoint knowledge source subtype.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/IndexedSharePointContainerName.java Deletes SharePoint container selector enum.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/IndexStatisticsSummary.java Deletes index statistics summary model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/EntityCategory.java Adds entity category enum model.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/ChatCompletionExtraParametersBehavior.java Changes serialized value for PASS_THROUGH behavior.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/AzureOpenAIModelName.java Removes several GPT model names; adds GPT-5.4 variants.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/AIServicesVisionVectorizer.java Deletes AI Services Vision vectorizer subtype.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/AIServicesAccountKey.java Updates Javadoc wording for subdomain URL.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/AIServicesAccountIdentity.java Updates Javadoc wording for subdomain URL.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/indexes/models/AIFoundryModelCatalogName.java Renames constants; re-adds OpenAI CLIP entries with new names.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept.java Adds generated Accept enum (implementation models).
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept3.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept5.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept13.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept18.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept23.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept30.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept33.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept37.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept40.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept43.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CreateOrUpdateRequestAccept46.java Adds generated Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CountRequestAccept1.java Adds generated count Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CountRequestAccept4.java Adds generated count Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CountRequestAccept6.java Adds generated count Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/models/CountRequestAccept7.java Adds generated count Accept enum (implementation models) with numeric suffix.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/SearchUtils.java Removes header injection and drops several SearchOptions mappings.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/implementation/FieldBuilder.java Removes mapping for permission filtering and sensitivity labeling.
sdk/search/azure-search-documents/src/main/java/com/azure/search/documents/SearchServiceVersion.java Adds new service version and updates getLatest().
sdk/search/azure-search-documents/customizations/src/main/java/SearchCustomizations.java Adjusts customization of service version enum backfill and enum constant casing.
sdk/search/azure-search-documents/assets.json Updates assets tag to new SHA.

Comment on lines 117 to 119
entries.add(0, new EnumConstantDeclaration(enumName)
.addArgument(new StringLiteralExpr(version))
.setJavadocComment("Enum value " + version + "."));
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This customization unconditionally prepends enum constants for versions, including 2025-11-01-preview which is already present in SearchServiceVersion in this PR. If the constant already exists, adding it again will cause a compilation error due to duplicate enum constants. Suggestion: before entries.add(0, ...), check whether an entry with the same name already exists, and only add missing versions.

Suggested change
entries.add(0, new EnumConstantDeclaration(enumName)
.addArgument(new StringLiteralExpr(version))
.setJavadocComment("Enum value " + version + "."));
boolean alreadyExists = entries.stream()
.anyMatch(entry -> entry.getNameAsString().equals(enumName));
if (!alreadyExists) {
entries.add(0, new EnumConstantDeclaration(enumName)
.addArgument(new StringLiteralExpr(version))
.setJavadocComment("Enum value " + version + "."));
}

Copilot uses AI. Check for mistakes.
/**
* Defines values for CreateOrUpdateRequestAccept48.
*/
public enum CreateOrUpdateRequestAccept48 {
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Public API is being polluted with many nearly-identical CreateOrUpdateRequestAccept<N> enums that differ only by a numeric suffix. This is confusing for customers and makes the surface area brittle. These Accept-header enums should be internal-only (implementation package) and/or deduplicated into a single shared type (or represented as a String constant) so users aren’t exposed to dozens of numbered variants.

Suggested change
public enum CreateOrUpdateRequestAccept48 {
enum CreateOrUpdateRequestAccept48 {

Copilot uses AI. Check for mistakes.
*/
@Generated
private String defaultLanguageCode;
private SentimentSkillLanguage defaultLanguageCode;
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing defaultLanguageCode from String to SentimentSkillLanguage (and changing the getter/setter signatures) is a source-breaking change for existing customers. To preserve compatibility, consider keeping the original String getter/setter as overloads (mark them @Deprecated if desired) and delegate to the typed enum via SentimentSkillLanguage.fromString(...) and toString().

Copilot uses AI. Check for mistakes.
Comment on lines +76 to 78
public SentimentSkillLanguage getDefaultLanguageCode() {
return this.defaultLanguageCode;
}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing defaultLanguageCode from String to SentimentSkillLanguage (and changing the getter/setter signatures) is a source-breaking change for existing customers. To preserve compatibility, consider keeping the original String getter/setter as overloads (mark them @Deprecated if desired) and delegate to the typed enum via SentimentSkillLanguage.fromString(...) and toString().

Copilot uses AI. Check for mistakes.
Comment on lines +247 to +250
public SentimentSkillV3 setDefaultLanguageCode(SentimentSkillLanguage defaultLanguageCode) {
this.defaultLanguageCode = defaultLanguageCode;
return this;
}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing defaultLanguageCode from String to SentimentSkillLanguage (and changing the getter/setter signatures) is a source-breaking change for existing customers. To preserve compatibility, consider keeping the original String getter/setter as overloads (mark them @Deprecated if desired) and delegate to the typed enum via SentimentSkillLanguage.fromString(...) and toString().

Copilot uses AI. Check for mistakes.
Comment on lines 66 to 69
public static RequestOptions addSearchHeaders(RequestOptions requestOptions, SearchOptions searchOptions) {
// If SearchOptions is null or is both query source authorization and enable elevated read aren't set
// return requestOptions as-is.
if (searchOptions == null
|| (CoreUtils.isNullOrEmpty(searchOptions.getQuerySourceAuthorization())
&& searchOptions.isEnableElevatedRead() == null)) {
return requestOptions;
}

if (requestOptions == null) {
requestOptions = new RequestOptions();
}

if (!CoreUtils.isNullOrEmpty(searchOptions.getQuerySourceAuthorization())) {
requestOptions.setHeader(X_MS_QUERY_SOURCE_AUTHORIZATION, searchOptions.getQuerySourceAuthorization());
}

if (searchOptions.isEnableElevatedRead() != null) {
requestOptions.setHeader(X_MS_ENABLE_ELEVATED_READ, Boolean.toString(searchOptions.isEnableElevatedRead()));
}

return requestOptions;
}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addSearchHeaders is now a complete no-op but its name and Javadoc imply it mutates/augments headers. This invites subtle bugs at call sites (they may rely on headers being set). If the feature was removed intentionally, consider removing this method (and call sites) or renaming it to reflect no-op behavior; if it’s still supported, restore the header-setting logic.

Copilot uses AI. Check for mistakes.
*/
@Generated
public static final ChatCompletionExtraParametersBehavior PASS_THROUGH = fromString("pass-through");
public static final ChatCompletionExtraParametersBehavior PASS_THROUGH = fromString("passThrough");
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wire value for PASS_THROUGH changed from pass-through to passThrough. If the service still expects the former, this will silently send a different value and alter behavior. Please verify the exact serialized string in the spec; if both are accepted, consider retaining a deprecated alias constant for the old spelling to reduce upgrade friction.

Suggested change
public static final ChatCompletionExtraParametersBehavior PASS_THROUGH = fromString("passThrough");
public static final ChatCompletionExtraParametersBehavior PASS_THROUGH = fromString("pass-through");

Copilot uses AI. Check for mistakes.
public static final AIFoundryModelCatalogName OPEN_AI_CLIP_IMAGE_TEXT_EMBEDDINGS_VIT_BASE_PATCH32
= fromString("OpenAI-CLIP-Image-Text-Embeddings-vit-base-patch32");

/**
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constants were renamed (old names removed, new names added). Even though the underlying string values are unchanged, removing the old constants is a source-breaking change for customers. Suggestion: keep the old constant names as @Deprecated aliases pointing at the same fromString(...) values.

Suggested change
/**
/**
* OpenAI-CLIP-Image-Text-Embeddings-vit-base-patch32.
*
* @deprecated Use {@link #OPEN_AI_CLIP_IMAGE_TEXT_EMBEDDINGS_VIT_BASE_PATCH32} instead.
*/
@Generated
@Deprecated
public static final AIFoundryModelCatalogName OPEN_AI_CLIP_IMAGE_TEXT_EMBEDDINGS_VI_TBASE_PATCH32
= fromString("OpenAI-CLIP-Image-Text-Embeddings-vit-base-patch32");
/**

Copilot uses AI. Check for mistakes.
*/
@Generated
public static final AIFoundryModelCatalogName OPEN_AI_CLIP_IMAGE_TEXT_EMBEDDINGS_VI_TLARGE_PATCH14_336
= fromString("OpenAI-CLIP-Image-Text-Embeddings-ViT-Large-Patch14-336");
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constants were renamed (old names removed, new names added). Even though the underlying string values are unchanged, removing the old constants is a source-breaking change for customers. Suggestion: keep the old constant names as @Deprecated aliases pointing at the same fromString(...) values.

Suggested change
= fromString("OpenAI-CLIP-Image-Text-Embeddings-ViT-Large-Patch14-336");
= fromString("OpenAI-CLIP-Image-Text-Embeddings-ViT-Large-Patch14-336");
/**
* OpenAI-CLIP-Image-Text-Embeddings-ViT-Large-Patch14-336.
*
* @deprecated Use {@link #OPEN_AI_CLIP_IMAGE_TEXT_EMBEDDINGS_VI_TLARGE_PATCH14_336} instead.
*/
@Generated
@Deprecated
public static final AIFoundryModelCatalogName OPEN_AI_CLIP_IMAGE_TEXT_EMBEDDINGS_VIT_LARGE_PATCH14_336
= OPEN_AI_CLIP_IMAGE_TEXT_EMBEDDINGS_VI_TLARGE_PATCH14_336;

Copilot uses AI. Check for mistakes.
Comment on lines 57 to 59
public static SearchServiceVersion getLatest() {
return V2025_11_01_PREVIEW;
return V2026_04_01;
}
Copy link

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is still the template and doesn’t explain the scope/impact of the regeneration, especially the significant public surface area changes (many types/properties removed, new service version added, behavior changes in SearchUtils). Please update the PR description and checklist to reflect the actual changes and call out any breaking changes and verification steps.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 25, 2026

@idickerson7 I've opened a new pull request, #48582, to work on those changes. Once the pull request is ready, I'll request review from you.

@idickerson7 idickerson7 force-pushed the idickers/2026-04-01-java-sdk branch from 70968d0 to 30ee780 Compare March 26, 2026 22:48
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any update on these extra generated models?

@efrainretana
Copy link
Copy Markdown
Member

Did you update the changelog ? I dont see it in the PR. Also the API version seems to point to 12.0.0-beta instead of just 12.0.0

@idickerson7 idickerson7 force-pushed the idickers/2026-04-01-java-sdk branch from dcf520c to ce63137 Compare April 10, 2026 22:18
@idickerson7 idickerson7 force-pushed the idickers/2026-04-01-java-sdk branch from ce63137 to fc76b7b Compare April 10, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

6 participants