[ServiceBus] Migrate azure-resourcemanager-servicebus to TypeSpec#48724
Open
weidongxu-microsoft wants to merge 3 commits intoAzure:mainfrom
Open
[ServiceBus] Migrate azure-resourcemanager-servicebus to TypeSpec#48724weidongxu-microsoft wants to merge 3 commits intoAzure:mainfrom
weidongxu-microsoft wants to merge 3 commits intoAzure:mainfrom
Conversation
- Generate SDK from TypeSpec spec - Add module-info.java opens for implementation.models - Add revapi suppressions for: - ListResult classes moved to implementation - Read-only model constructor/setter changes - Action nowFinal + SqlRuleAction removed (redundant allOf wrapper) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
weidongxu-microsoft
added
the
Mgmt
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
weidongxu-microsoft
requested review from
JonathanGiles and
alzimmermsft
as code owners
weidongxu-microsoft
requested review from
a team,
ArthurMa1978,
Netyyyy,
XiaofeiCao,
haolingdong-msft,
moarychan,
rujche,
saragluna and
srnagar
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates azure-resourcemanager-servicebus from Swagger/AutoRest to TypeSpec-generated code, including new models and updated client interfaces for the latest Service Bus RP surface (e.g., NSP).
Changes:
- Adds TypeSpec configuration (
tsp-location.yaml) and updates generated code headers/packages to TypeSpec. - Introduces new models/enums (TLS version, public network access, NSP-related types, geo-replication, failover, confidential compute) and moves pageable list-result models to
implementation.models. - Updates client builder/service interfaces, native-image proxy config, README version, and RevAPI suppressions for the breaking changes from regeneration.
Reviewed changes
Copilot reviewed 137 out of 211 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/servicebus/azure-resourcemanager-servicebus/tsp-location.yaml | Adds TypeSpec spec-location metadata for code generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-servicebus/proxy-config.json | Updates native-image proxy configuration with new generated service proxies. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/module-info.java | Opens additional implementation models package for reflection/serialization. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/package-info.java | Updates package docs to TypeSpec-generated naming. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/package-info.java | Updates models package docs to TypeSpec-generated naming. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/UserAssignedIdentityProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/UserAssignedIdentity.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/UnavailableReason.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/TlsVersion.java | Adds new expandable enum for TLS versions. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/Subnet.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/SqlRuleAction.java | Removes redundant Swagger allOf wrapper model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/SqlFilter.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/SkuTier.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/SkuName.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/SBSku.java | Updates docs for capacity semantics in Premium namespaces. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/SBNamespaceUpdateParameters.java | Adds SystemData and adjusts resource metadata field ordering/serialization. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/SBClientAffineProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/RoleDisasterRecovery.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ResourceNamespacePatch.java | Adds SystemData support and adjusts resource metadata field ordering/serialization. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ResourceAssociationAccessMode.java | Adds new expandable enum for NSP resource association access mode. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/RegenerateAccessKeyParameters.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/PublicNetworkAccessFlag.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/PublicNetworkAccess.java | Adds new expandable enum for PublicNetworkAccess. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ProvisioningStateDR.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ProvisioningIssueProperties.java | Adds new immutable model for NSP provisioning issue properties. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ProvisioningIssue.java | Adds new immutable model describing NSP provisioning issues. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/PrivateLinkResource.java | Makes output-only model immutable and removes setters. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/PrivateLinkConnectionStatus.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/PrivateEndpoint.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/PlatformCapabilities.java | Adds new model for platform capabilities (confidential compute). |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/OperationDisplay.java | Makes output-only model immutable (private constructor). |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NspAccessRulePropertiesSubscriptionsItem.java | Adds subscription-id model for NSP access rules. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NspAccessRuleProperties.java | Adds NSP access rule properties model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NspAccessRuleDirection.java | Adds new expandable enum for NSP access rule direction. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NspAccessRule.java | Adds NSP access rule model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NetworkSecurityPerimeterConfigurationProvisioningState.java | Adds provisioning-state enum for NSP configuration propagation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NetworkSecurityPerimeterConfigurationPropertiesResourceAssociation.java | Adds NSP resource association info model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NetworkSecurityPerimeterConfigurationPropertiesProfile.java | Adds NSP current network profile model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NetworkSecurityPerimeter.java | Adds NSP perimeter reference model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NetworkRuleIpAction.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NamespaceReplicaLocation.java | Adds geo-replication replica location model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NWRuleSetVirtualNetworkRules.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/NWRuleSetIpRules.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/Mode.java | Adds expandable enum for confidential compute enable/disable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/MigrationConfigurationName.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/MessageCountDetails.java | Makes output-only model immutable (private constructor). |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ManagedServiceIdentityType.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/KeyVaultProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/KeyType.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/KeySource.java | Updates KeySource docstring. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/Identity.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/GeoDataReplicationProperties.java | Adds geo-replication properties model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/GeoDRRoleType.java | Adds expandable enum for GeoDR role type. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/FilterType.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/FailoverProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/FailOver.java | Adds FailOver wrapper model around inner failover properties. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/EntityStatus.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/EndPointProvisioningState.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/Encryption.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/DefaultAction.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/CorrelationFilter.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ConnectionState.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/ConfidentialCompute.java | Adds confidential compute model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/CheckNameAvailability.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/Action.java | Makes Action final after removing SqlRuleAction subtype. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/models/AccessRights.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/SBTopicListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/SBSubscriptionListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/SBQueueListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/SBNamespaceListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/SBAuthorizationRuleListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/RuleListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/PrivateEndpointConnectionListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/OperationListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/NetworkSecurityPerimeterConfigurationList.java | Adds pageable list result model for NSP configurations. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/NetworkRuleSetListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/MigrationConfigListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/models/ArmDisasterRecoveryListResult.java | Moves pageable result model to implementation package and makes immutable. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/ServiceBusManagementClientBuilder.java | Updates builder params and client construction order for endpoint/subscriptionId. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/PrivateLinkResourcesClientImpl.java | Updates host parameter naming and parameter ordering for TypeSpec generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/implementation/OperationsClientImpl.java | Updates service interface naming and imports to moved OperationListResult model. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/package-info.java | Updates fluent package docs to new naming. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/package-info.java | Updates fluent models package docs to new naming. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBTopicProperties.java | Adds user metadata field and updates JSON serialization. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBTopicInner.java | Reorders resource metadata fields and adds user metadata passthrough. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBSubscriptionProperties.java | Adds user metadata and updates duration serialization for lockDuration. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBSubscriptionInner.java | Reorders resource metadata fields and adds user metadata passthrough. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBQueueProperties.java | Adds user metadata field and updates JSON serialization. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBQueueInner.java | Reorders resource metadata fields and adds user metadata passthrough. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBNamespaceUpdateProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBAuthorizationRuleProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/SBAuthorizationRuleInner.java | Reorders resource metadata fields for TypeSpec generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/Ruleproperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/RuleInner.java | Reorders resource metadata fields for TypeSpec generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/PrivateLinkResourcesListResultInner.java | Makes list-result immutable and adds required-property validation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/PrivateLinkResourceProperties.java | Makes output-only model immutable and removes setters. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/PrivateEndpointConnectionProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/PrivateEndpointConnectionInner.java | Reorders resource metadata fields for TypeSpec generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/OperationInner.java | Makes output-only model immutable and adjusts JSON writing for properties. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/NetworkRuleSetProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/NetworkRuleSetInner.java | Reorders resource metadata fields for TypeSpec generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/MigrationConfigPropertiesProperties.java | Updates TypeSpec-generated docs (provisioningState). |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/MigrationConfigPropertiesInner.java | Reorders resource metadata fields and updates docs. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/FailoverPropertiesProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/FailOverProperties.java | Adds TypeSpec-generated inner model for failover request properties. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/CheckNameAvailabilityResultInner.java | Makes output-only model immutable and removes setters. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/ArmDisasterRecoveryProperties.java | Updates generated header to TypeSpec. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/ArmDisasterRecoveryInner.java | Reorders resource metadata fields for TypeSpec generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/models/AccessKeysInner.java | Makes output-only model immutable (private constructor). |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/ServiceBusManagementClient.java | Reorders accessors and adds new NSP-related clients. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/PrivateLinkResourcesClient.java | Updates Javadoc for resourceGroupName parameter. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/OperationsClient.java | Updates Javadoc phrasing per TypeSpec generation. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/NetworkSecurityPerimeterConfigurationsClient.java | Adds new fluent client interface for NSP configuration operations. |
| sdk/servicebus/azure-resourcemanager-servicebus/src/main/java/com/azure/resourcemanager/servicebus/fluent/NetworkSecurityPerimeterConfigurationOperationsClient.java | Adds new pageable fluent client interface for listing NSP configurations. |
| sdk/servicebus/azure-resourcemanager-servicebus/assets.json | Updates assets tag to new generated snapshot. |
| sdk/servicebus/azure-resourcemanager-servicebus/README.md | Updates dependency version to 2.54.0-beta.1. |
| eng/lintingconfigs/revapi/track2/revapi.json | Adds RevAPI suppressions for generated breaking changes (moved classes, removed setters, visibility). |
| @Override | ||
| public JsonWriter toJson(JsonWriter jsonWriter) throws IOException { | ||
| jsonWriter.writeStartObject(); | ||
| jsonWriter.writeStringField("name", this.name); |
There was a problem hiding this comment.
ProvisioningIssue.fromJson reads the "properties" field, but toJson never writes it, which will drop data when the model is serialized. Please include the "properties" field in toJson (e.g., writeJsonField("properties", this.properties)).
Suggested change
| jsonWriter.writeStringField("name", this.name); | |
| jsonWriter.writeStringField("name", this.name); | |
| jsonWriter.writeJsonField("properties", this.properties); |
| jsonWriter.writeStringField("direction", this.direction == null ? null : this.direction.toString()); | ||
| jsonWriter.writeArrayField("addressPrefixes", this.addressPrefixes, | ||
| (writer, element) -> writer.writeString(element)); | ||
| jsonWriter.writeArrayField("subscriptions", this.subscriptions, (writer, element) -> writer.writeJson(element)); |
There was a problem hiding this comment.
NspAccessRuleProperties.fromJson supports "networkSecurityPerimeters" and "fullyQualifiedDomainNames", but toJson does not write either field. This makes round-tripping lossy and can break requests if this model is used in a payload. Please serialize both fields in toJson (writeArrayField for each).
Suggested change
| jsonWriter.writeArrayField("subscriptions", this.subscriptions, (writer, element) -> writer.writeJson(element)); | |
| jsonWriter.writeArrayField("subscriptions", this.subscriptions, (writer, element) -> writer.writeJson(element)); | |
| jsonWriter.writeArrayField("networkSecurityPerimeters", this.networkSecurityPerimeters, | |
| (writer, element) -> writer.writeJson(element)); | |
| jsonWriter.writeArrayField("fullyQualifiedDomainNames", this.fullyQualifiedDomainNames, | |
| (writer, element) -> writer.writeString(element)); |
| jsonWriter.writeStartObject(); | ||
| jsonWriter.writeStringField("id", this.id); | ||
| jsonWriter.writeStringField("name", this.name); | ||
| jsonWriter.writeStringField("type", this.type); |
There was a problem hiding this comment.
NspAccessRule.fromJson reads the "properties" field, but toJson never writes it. Please include "properties" in toJson to avoid silent data loss during serialization.
Suggested change
| jsonWriter.writeStringField("type", this.type); | |
| jsonWriter.writeStringField("type", this.type); | |
| jsonWriter.writeJsonField("properties", this.properties); |
| implements JsonSerializable<MigrationConfigPropertiesProperties> { | ||
| /* | ||
| * Provisioning state of Migration Configuration | ||
| * Provisioning state of Migration ConfigurationProvisioning state of Migration Configuration |
There was a problem hiding this comment.
The Javadoc appears to contain duplicated text ("Provisioning state of Migration Configuration" repeated). Please correct the wording to a single, grammatical sentence (e.g., "Provisioning state of the migration configuration.") to avoid publishing malformed docs.
| directory: specification/servicebus/resource-manager/Microsoft.ServiceBus/ServiceBus | ||
| commit: c772c8d80387b6ffa8ddfaabb7b0fc7bb4e792f1 | ||
| repo: Azure/azure-rest-api-specs | ||
| additionalDirectories: |
There was a problem hiding this comment.
additionalDirectories is present but has no value. If the tooling expects a sequence, this may be interpreted as null rather than an empty list. Consider either removing the key entirely or setting it to an explicit empty list (e.g., additionalDirectories: []).
Suggested change
| additionalDirectories: | |
| additionalDirectories: [] |
Comment on lines
+32
to
+33
| Mono<Response<NetworkSecurityPerimeterConfigurationInner>> getResourceAssociationNameWithResponseAsync( | ||
| String resourceGroupName, String namespaceName, String resourceAssociationName); |
There was a problem hiding this comment.
The method name "getResourceAssociationNameWithResponseAsync" is awkward and reads like it's returning a name rather than getting a resource by name. If possible, adjust the TypeSpec operationId/name so generation produces idiomatic overloads such as getWithResponseAsync(...) / getAsync(...), keeping the resourceAssociationName as a parameter rather than embedding it into the method name.
| private Boolean enableExpress; | ||
|
|
||
| /* | ||
| * Gets and Sets Metadata of User. |
There was a problem hiding this comment.
The new userMetadata field documentation is ungrammatical ("Gets and Sets Metadata of User") and inconsistent with typical SDK wording. Consider updating it to something clearer like "User-provided metadata." / "Gets the user metadata." to improve generated Javadocs.
Suggested change
| * Gets and Sets Metadata of User. | |
| * User-provided metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate azure-resourcemanager-servicebus from Swagger to TypeSpec.
Spec PR: Azure/azure-rest-api-specs#42200