Skip to content

eng, fix analyze, move mvn auth step before verify typespec step#48843

Merged
raych1 merged 2 commits intomainfrom
eng_fix-analyze
Apr 17, 2026
Merged

eng, fix analyze, move mvn auth step before verify typespec step#48843
raych1 merged 2 commits intomainfrom
eng_fix-analyze

Conversation

@weidongxu-microsoft
Copy link
Copy Markdown
Member

@weidongxu-microsoft weidongxu-microsoft commented Apr 17, 2026

verify pipeline https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6169732&view=logs&s=6884a131-87da-5381-61f3-d7acc3b91d76&j=b70e5e73-bbb6-5567-0939-8415943fadb9

Description

fix analyze, move mvn auth step before verify typespec step

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@weidongxu-microsoft weidongxu-microsoft marked this pull request as ready for review April 17, 2026 02:52
Copilot AI review requested due to automatic review settings April 17, 2026 02:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the CI Analyze job pipeline to ensure Maven feed authentication happens before running the Swagger/TypeSpec code generation verification step, which invokes Maven during TypeSpec regeneration.

Changes:

  • Move the /eng/pipelines/templates/steps/maven-authenticate.yml step earlier in the Analyze job, ahead of Compare-CurrentToCodegeneration.ps1.
  • Ensure Maven is authenticated before TypeSpec verification runs mvn codesnippet:update-codesnippet.

Comment thread eng/pipelines/templates/jobs/ci.yml
@weidongxu-microsoft weidongxu-microsoft changed the title eng, fix analyze, move mvn auth before verify typespec eng, fix analyze, move mvn auth step before verify typespec step Apr 17, 2026
@raych1 raych1 merged commit 0f824ef into main Apr 17, 2026
11 checks passed
@raych1 raych1 deleted the eng_fix-analyze branch April 17, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants