mgmt, update compute to 2025-11-01#48844
Conversation
github-actions
bot
added
the
Mgmt
weidongxu-microsoft
requested review from
a team,
ArthurMa1978 and
haolingdong-msft
as code owners
There was a problem hiding this comment.
Pull request overview
This PR updates the Azure Resource Manager Compute Java SDK to align with the Microsoft.Compute 2025-11-01 swagger/spec version, regenerating clients/models and updating generated samples accordingly.
Changes:
- Bumped the
tsp-location.yamlspec commit reference used for generation. - Updated generated client code to use
apiVersion = "2025-11-01"and adjusted method signatures where the REST API changed (e.g., VM deallocate addsforceDeallocate). - Added/updated generated models, enums, and samples for newly supported scenarios (e.g., VMSS lifecycle hook events; storage fault domain alignment fields).
Reviewed changes
Copilot reviewed 78 out of 268 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/compute/azure-resourcemanager-compute/tsp-location.yaml | Points generation at the newer azure-rest-api-specs commit. |
| sdk/compute/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/implementation/* | Updates generated clients to 2025-11-01 api-version and new parameters. |
| sdk/compute/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/models/* | Adds new enums/fields surfaced by the updated swagger (e.g., Standard securityType, storage alignment). |
| sdk/compute/azure-resourcemanager-compute/src/main/java/com/azure/resourcemanager/compute/fluent/ComputeManagementClient* | Adds a new lifecycle hook events client accessor. |
| sdk/compute/azure-resourcemanager-compute/src/samples/java/... | Updates sample provenance to 2025-11-01 and adds new samples for new operations. |
| directory: specification/compute/resource-manager/Microsoft.Compute/Compute | ||
| commit: a6de97d4e9caec8fb976c9c4b430fd01a15d2e8e | ||
| commit: 40f196da0154477506dafd25d99e80bcbfc04ac2 |
There was a problem hiding this comment.
The PR description is still the default template and doesn’t explain what changed (e.g., api-version bump to 2025-11-01, new lifecycle hook events client/models) or how to verify. Please replace it with a short summary, motivation, and validation steps, and link the source swagger/spec PR if applicable.
| directory: specification/compute/resource-manager/Microsoft.Compute/Compute | ||
| commit: a6de97d4e9caec8fb976c9c4b430fd01a15d2e8e | ||
| commit: 40f196da0154477506dafd25d99e80bcbfc04ac2 |
There was a problem hiding this comment.
This api-version/spec update appears to introduce new public surface area (e.g., new models/enums and VMSS lifecycle hook events client), but the module CHANGELOG doesn’t mention the update (no 2025-11-01 entry). Please add an entry under the current (Unreleased) section describing the api-version bump and notable additions/behavior changes.
| * Get the securityType property: Specifies the SecurityType of the virtual machine. It has to be set to any | ||
| * specified value to enable UefiSettings. The default behavior is: UefiSettings will not be enabled unless this | ||
| * property is set. | ||
| * property is set and is not Standard. If not specified, Standard will be returned starting api version 2025-11-01. | ||
| * |
There was a problem hiding this comment.
Line exceeds the repo’s 120 character Checkstyle limit (see eng/lintingconfigs/checkstyle/track2/checkstyle.xml LineLength max=120). Please wrap/reflow this JavaDoc line to avoid Checkstyle failures.
| * Set the securityType property: Specifies the SecurityType of the virtual machine. It has to be set to any | ||
| * specified value to enable UefiSettings. The default behavior is: UefiSettings will not be enabled unless this | ||
| * property is set. | ||
| * property is set and is not Standard. If not specified, Standard will be returned starting api version 2025-11-01. | ||
| * |
There was a problem hiding this comment.
Line exceeds the repo’s 120 character Checkstyle limit (see eng/lintingconfigs/checkstyle/track2/checkstyle.xml LineLength max=120). Please wrap/reflow this JavaDoc line to avoid Checkstyle failures.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines