Storage - Stg104 MD5/CRC64 Combined Return #49177
Open
browndav-msft wants to merge 20 commits into
Open
Conversation
ae26ca1 to
e2225d6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds CRC64 exposure alongside existing MD5 information for blob upload-related responses in azure-storage-blob, with tests gated for service version 2026-10-06+.
Changes:
- Adds
getContentCrc64()to append, block, and page blob item models. - Maps
x-ms-content-crc64response headers into those models for selected upload operations. - Updates tests and recordings to validate CRC64 response mapping for several sync/async upload paths.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
sdk/storage/azure-storage-blob/swagger/README.md |
Updates swagger input file source/version. |
sdk/storage/azure-storage-blob/assets.json |
Updates test asset recording tag. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/AppendBlobItem.java |
Adds CRC64 storage and getter. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/BlockBlobItem.java |
Adds CRC64 storage and getter. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/models/PageBlobItem.java |
Adds CRC64 storage and getter. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/accesshelpers/AppendBlobItemConstructorProxy.java |
Adds internal constructor accessor for append blob CRC64. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/accesshelpers/BlockBlobItemConstructorProxy.java |
Adds internal constructor accessor for block blob CRC64. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/accesshelpers/PageBlobItemConstructorProxy.java |
Adds internal constructor accessor for page blob CRC64. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/models/BlockBlobsUploadHeaders.java |
Parses x-ms-content-crc64 for block blob upload responses. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/implementation/models/BlockBlobsPutBlobFromUrlHeaders.java |
Parses x-ms-content-crc64 for block blob upload-from-URL responses. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/AppendBlobAsyncClient.java |
Maps append upload CRC64 headers into AppendBlobItem. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlockBlobAsyncClient.java |
Maps block upload CRC64 headers into BlockBlobItem. |
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/PageBlobAsyncClient.java |
Maps page upload CRC64 headers into PageBlobItem. |
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/AppendBlobApiTests.java |
Adds sync append CRC64 assertions. |
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/AppendBlobAsyncApiTests.java |
Adds async append CRC64 assertions. |
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/BlockBlobApiTests.java |
Adds sync block CRC64 assertions. |
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/BlockBlobAsyncApiTests.java |
Adds async block CRC64 assertions. |
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/PageBlobApiTests.java |
Adds sync page CRC64 assertions. |
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/PageBlobAsyncApiTests.java |
Adds async page CRC64 assertions. |
ibrandes
reviewed
May 19, 2026
ibrandes
approved these changes
May 20, 2026
Member
ibrandes
left a comment
There was a problem hiding this comment.
looks good! just a couple nits / questions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the service to return both MD5 and CRC64 checksum values for blob upload APIs when the client provides a Content-MD5 header, instead of returning only MD5.
The behavior is gated behind API version 2026-10-06+, and is designed to support ODSP’s migration from MD5 → CRC64 without requiring additional read-backs.
Goal of this change:
Allow clients to obtain both checksums in a single request
Simplify MD5 → CRC64 migration
Eliminate unnecessary blob reads