Skip to content

Storage - STG104 Live Test Cleanup#49919

Open
ibrandes wants to merge 8 commits into
Azure:feature/storage/stg104basefrom
ibrandes:stg104/cleanupAndTestOOMIssue
Open

Storage - STG104 Live Test Cleanup#49919
ibrandes wants to merge 8 commits into
Azure:feature/storage/stg104basefrom
ibrandes:stg104/cleanupAndTestOOMIssue

Conversation

@ibrandes

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added Azure.Core azure-core Storage Storage Service (Queues, Blobs, Files) labels Jul 23, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
33 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@ibrandes

Copy link
Copy Markdown
Member Author

/azp run java - storage - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@ibrandes

Copy link
Copy Markdown
Member Author

/azp run java - storage - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

@ibrandes

Copy link
Copy Markdown
Member Author

/azp run java - storage - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces flakiness and resource pressure (disk/heap) in Storage live and unit tests by eagerly cleaning up large temp files and trimming oversized parameterized test cases, while also stabilizing a few race-prone live scenarios.

Changes:

  • Eagerly delete multi-GB temp files created by large upload/download live tests instead of relying on deleteOnExit().
  • Reduce large in-memory test vectors (multi-MB/100s-of-MB cases) that were intermittently causing OOMs and large heap dumps in CI.
  • Improve live-test stability by isolating concurrency-sensitive tests and guarding abort-copy assertions when the service completes the copy too quickly.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdk/storage/azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/LargeFileTests.java Ensures large (~GiB) temp source file is deleted in finally to avoid filling agent disk.
sdk/storage/azure-storage-common/src/test/java/com/azure/storage/common/implementation/contentvalidation/StructuredMessageEncoderTests.java Renames test class to match file and trims oversized parameterized cases; adds a focused supplier for direct-buffer coverage.
sdk/storage/azure-storage-common/src/test/java/com/azure/storage/common/implementation/contentvalidation/StorageCrc64CalculatorTests.java Replaces extremely large allocation test cases with smaller ones that still exercise non-uniform composition.
sdk/storage/azure-storage-common/src/test/java/com/azure/storage/common/implementation/BufferStagingAreaTests.java Reduces buffer sizes in parameterized tests while preserving repartitioning coverage.
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/RetryTests.java Marks the retry test class @Isolated to avoid interference under parallel execution.
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/LargeBlobTests.java Ensures large (~GiB) temp source file is deleted in finally to avoid filling agent disk.
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationDownloadTests.java Adds eager temp file cleanup helper and uses it to prevent large fuzzy payloads accumulating on disk.
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationAsyncUploadTests.java Refactors append-blob live test to a single reactive pipeline (no blocking), preserving cleanup semantics.
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationAsyncDownloadTests.java Mirrors eager temp file cleanup for async fuzzy round-trip download cases.
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobApiTests.java Stabilizes abort-copy live tests by widening the “copy pending” window and skipping when the service finishes too quickly.
sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/PageBlobClient.java Removes @ServiceMethod from getBlobOutputStream overloads.
sdk/parents/azure-client-sdk-parent/pom.xml Removes an extra blank line in banned dependencies configuration.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@ibrandes
ibrandes marked this pull request as ready for review July 24, 2026 02:56
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
33 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@browndav-msft browndav-msft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good. Good catch on the piling up files in assertParallelDownloadFuzzyRoundTripAsync.

@browndav-msft browndav-msft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed something when I initially approved.

@ibrandes
ibrandes requested a review from browndav-msft July 24, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core azure-core Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants