Storage - STG104 Live Test Cleanup#49919
Open
ibrandes wants to merge 8 commits into
Open
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). 33 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/azp run java - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - storage - tests |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces flakiness and resource pressure (disk/heap) in Storage live and unit tests by eagerly cleaning up large temp files and trimming oversized parameterized test cases, while also stabilizing a few race-prone live scenarios.
Changes:
- Eagerly delete multi-GB temp files created by large upload/download live tests instead of relying on
deleteOnExit(). - Reduce large in-memory test vectors (multi-MB/100s-of-MB cases) that were intermittently causing OOMs and large heap dumps in CI.
- Improve live-test stability by isolating concurrency-sensitive tests and guarding abort-copy assertions when the service completes the copy too quickly.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-file-datalake/src/test/java/com/azure/storage/file/datalake/LargeFileTests.java | Ensures large (~GiB) temp source file is deleted in finally to avoid filling agent disk. |
| sdk/storage/azure-storage-common/src/test/java/com/azure/storage/common/implementation/contentvalidation/StructuredMessageEncoderTests.java | Renames test class to match file and trims oversized parameterized cases; adds a focused supplier for direct-buffer coverage. |
| sdk/storage/azure-storage-common/src/test/java/com/azure/storage/common/implementation/contentvalidation/StorageCrc64CalculatorTests.java | Replaces extremely large allocation test cases with smaller ones that still exercise non-uniform composition. |
| sdk/storage/azure-storage-common/src/test/java/com/azure/storage/common/implementation/BufferStagingAreaTests.java | Reduces buffer sizes in parameterized tests while preserving repartitioning coverage. |
| sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/RetryTests.java | Marks the retry test class @Isolated to avoid interference under parallel execution. |
| sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/LargeBlobTests.java | Ensures large (~GiB) temp source file is deleted in finally to avoid filling agent disk. |
| sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationDownloadTests.java | Adds eager temp file cleanup helper and uses it to prevent large fuzzy payloads accumulating on disk. |
| sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationAsyncUploadTests.java | Refactors append-blob live test to a single reactive pipeline (no blocking), preserving cleanup semantics. |
| sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobContentValidationAsyncDownloadTests.java | Mirrors eager temp file cleanup for async fuzzy round-trip download cases. |
| sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobApiTests.java | Stabilizes abort-copy live tests by widening the “copy pending” window and skipping when the service finishes too quickly. |
| sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/PageBlobClient.java | Removes @ServiceMethod from getBlobOutputStream overloads. |
| sdk/parents/azure-client-sdk-parent/pom.xml | Removes an extra blank line in banned dependencies configuration. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
ibrandes
marked this pull request as ready for review
July 24, 2026 02:56
ibrandes
requested review from
a team,
JonathanGiles,
alzimmermsft,
browndav-msft,
gunjansingh-msft,
kyleknap,
samvaity and
seanmcc-msft
as code owners
July 24, 2026 02:56
|
Azure Pipelines: Successfully started running 1 pipeline(s). 33 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
browndav-msft
left a comment
Member
There was a problem hiding this comment.
I think it looks good. Good catch on the piling up files in assertParallelDownloadFuzzyRoundTripAsync.
browndav-msft
approved these changes
Jul 24, 2026
browndav-msft
requested changes
Jul 24, 2026
browndav-msft
left a comment
Member
There was a problem hiding this comment.
Sorry I missed something when I initially approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.