Add tests for multiple sync tokens scenarios#38538
Open
linglingye001 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for sync token response headers that contain whitespace after commas (which can occur when HTTP intermediaries join duplicate sync-token headers), and adds tests covering multi-token scenarios.
Changes:
- Trim each comma-separated segment before parsing in
SyncTokens.addSyncTokenFromHeaderValueso values like"a=v;sn=1, b=v;sn=2"parse correctly. - Add unit tests for multiple sync tokens in a single header and for tokens with spaces after commas.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/appconfiguration/app-configuration/src/internal/syncTokenPolicy.ts | Trim each token segment after splitting on , before parsing. |
| sdk/appconfiguration/app-configuration/test/internal/node/http.spec.ts | New tests for multi-token responses and space-after-comma joined headers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists