[test] update test recorder to ignore "Cache-Control" and "Pragma" headers#38570
Open
jeremymeng wants to merge 4 commits into
Open
[test] update test recorder to ignore "Cache-Control" and "Pragma" headers#38570jeremymeng wants to merge 4 commits into
jeremymeng wants to merge 4 commits into
Conversation
…nd "Pragma" headers After upgrading playwright to 1.60.0, the template-dpg browser tests start failing with the following error: >[vitest] FAIL chromium dist-test/browser/test/public/widgetService.spec.js > WidgetServiceClient > Widgets CRUD > should delete a widget [vitest] RecorderError: Unable to find a record for the request POST https://Sanitized.azconfig.io/widgets?api-version=1.0.0 [vitest] Header differences: [vitest] <Cache-Control> is absent in record, value <no-cache> [vitest] <Pragma> is absent in record, value <no-cache> [vitest] Body differences: These new headers don't matter to our tests. This PR ignores them for playback testing.
jeremymeng
requested review from
a team,
benbp,
mikeharder and
weshaggard
as code owners
github-actions
Bot
added
the
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the template-dpg browser test recorder configuration to tolerate additional no-cache headers introduced by the Playwright upgrade, preventing playback mismatches and unblocking the weekly dependency update pipeline.
Changes:
- Ignore
Cache-ControlandPragmaheaders during test-proxy request matching in playback fortemplate-dpgbrowser tests. - Bump the workspace
playwrightversion in thetestingcatalog to^1.60.0.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/template/template-dpg/test/public/widgetService.spec.ts | Configures the recorder matcher to exclude Cache-Control/Pragma so Playwright-added headers don’t break playback matching. |
| pnpm-workspace.yaml | Updates the testing catalog to use Playwright ^1.60.0. |
Member
|
This only fixes template though doesn't it? What about all the other packages? |
Member
Author
Good point! We probably will need a fix in recorder |
jeremymeng
changed the title
Member
Author
Updated test recorder to ignore them |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading playwright to 1.60.0, browser tests start failing with the following error:
These new headers don't matter to our tests. This PR ignores them for playback testing.