Skip to content

[Engsys] remove vitest.esm.config and update vitest.browser.config#38583

Open
kazrael2119 wants to merge 1 commit into
Azure:mainfrom
kazrael2119:update-config
Open

[Engsys] remove vitest.esm.config and update vitest.browser.config#38583
kazrael2119 wants to merge 1 commit into
Azure:mainfrom
kazrael2119:update-config

Conversation

@kazrael2119
Copy link
Copy Markdown
Member

@kazrael2119 kazrael2119 commented May 19, 2026

Azure/autorest.typescript#3938 (comment)
image
these features in not fully updated in sdk repo, so create a pr to update them

Copilot AI review requested due to automatic review settings May 19, 2026 03:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@kazrael2119
Copy link
Copy Markdown
Member Author

kazrael2119 commented May 19, 2026

@jeremymeng could you help review this pr? thanks

Another issue need confirm with you: Since we remove vitest.esm.config, do we also need to remove this script "test:node:esm": "dev-tool run test:vitest --esm", from packageJson in both sdk and codegen side?

@jeremymeng
Copy link
Copy Markdown
Member

Another issue need confirm with you: Since we remove vitest.esm.config, do we also need to remove this script "test:node:esm": "dev-tool run test:vitest --esm", from packageJson in both sdk and codegen side?

That's right, we no longer use "test:node:esm"

Copy link
Copy Markdown
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Untriaged
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants