Skip to content

Commit 375d6ed

Browse files
haiyuazhangCopilot
andcommitted
Fix resource-name override diagnostic wording
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 4ff812a commit 375d6ed

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

eng/packages/http-client-csharp-mgmt/emitter/src/resource-metadata.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ export function applyResourceNameOverrides(
631631
if (typeof override === "string") {
632632
if (group.length > 1) {
633633
diagnosticReporter?.(
634-
`@@clientOption(..., "${resourceNameKey}", "${override}", ...) is a plain string but its Read operation produces ${group.length} resources (expandable {parentType}). Use a Record<resourceType, name> map form instead.`
634+
`@@clientOption(..., "${resourceNameKey}", "${override}", ...) is a plain string but its Read operation produces ${group.length} resources (expandable {parentType}). Use a Record<enumValue, name> map form instead.`
635635
);
636636
continue;
637637
}

eng/packages/http-client-csharp-mgmt/emitter/test/resource-detection.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5001,8 +5001,10 @@ interface PrivateEndpointConnections {
50015001
);
50025002

50035003
const diagnostics: readonly Diagnostic[] = program.diagnostics;
5004-
const misuseWarning = diagnostics.find((d) =>
5005-
d.message.includes("plain string but its Read operation produces")
5004+
const misuseWarning = diagnostics.find(
5005+
(d) =>
5006+
d.message.includes("plain string but its Read operation produces") &&
5007+
d.message.includes("Record<enumValue, name>")
50065008
);
50075009
ok(
50085010
misuseWarning,

0 commit comments

Comments
 (0)