Emit the new code and push corresponding fixes.#59346
Open
nick863 wants to merge 3 commits into
Open
Conversation
dargilco
approved these changes
May 19, 2026
nick863
requested review from
a team,
glharper,
jsquire,
trangevi and
trrwilson
as code owners
m-nash
reviewed
May 20, 2026
| MembersMustExist : Member 'protected Azure.AI.Extensions.OpenAI.MemoryToolSearchItem Azure.AI.Extensions.OpenAI.MemoryToolSearchItem.PersistableModelCreateCore(System.BinaryData, System.ClientModel.Primitives.ModelReaderWriterOptions)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'protected System.BinaryData Azure.AI.Extensions.OpenAI.MemoryToolSearchItem.PersistableModelWriteCore(System.ClientModel.Primitives.ModelReaderWriterOptions)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'protected void Azure.AI.Extensions.OpenAI.MemoryToolSearchItem.JsonModelWriteCore(System.Text.Json.Utf8JsonWriter, System.ClientModel.Primitives.ModelReaderWriterOptions)' does not exist in the implementation but it does exist in the contract. | ||
| MembersMustExist : Member 'public Azure.AI.Extensions.OpenAI.MemoryOutputItem Azure.AI.Extensions.OpenAI.MemoryToolSearchItem.MemoryItem.get()' does not exist in the implementation but it does exist in the contract. |
Member
There was a problem hiding this comment.
It does not appear this was an experimental Type or Member if I look at the released version of this item.
Am I missing something?
Same result for the other compat overrides added in this PR.
Member
Author
There was a problem hiding this comment.
All the Memory* classes belong to the AIProjectMemoryStores client ecosystem, marked as experimental. We did not mark all the classes as experimental, though.
For example MemoryToolSearchItem is the item, returned in the response, when MemorySearch tool is being used. This tool enables Agent to search memory store. the operations on Memory stores also require the preview header.
dargilco
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.