Shorten generated collection result names#59364
Draft
haiyuazhang wants to merge 1 commit into
Draft
Conversation
Add an MPG visitor that compacts overlong CollectionResult type names with a deterministic hash suffix before generation emits file paths. Add a local TypeSpec repro for a long operation name and unit coverage for the name visitor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
CodeGen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58996
Summary
CollectionResultNameVisitorthat compacts overlong generatedCollectionResulttype names with a deterministic SHA256 hash suffix.Mgmt-TypeSpecrepro for a long collection-result name and unit coverage for the visitor.Validation
npm run test:generatoreng\packages\http-client-csharp-mgmt\eng\scripts\Generate.ps1 -filter Mgmt-TypeSpecCollectionResultspaths do not exceed the base-49 path-length budget.