Merge branch 'main' into copilot/optimize-breaking-changes-checker-performance

Author: msyyc

.github/skills/generate-api-markdown/SKILL.md

@@ -0,0 +1,23 @@
+---
+name: generate-api-markdown
+description: Generate an API markdown file and token file using ApiView. Use this when the user wants to generate an API markdown file and review API changes.
+---
+
+# Generate API Markdown
+
+## Prerequisites
+
+1. Activate your virtual environment with a Python version that is strictly less than the version limit specified in `eng/tools/azure-sdk-tools/azpysdk/apistub.py`.
+2. Install the required dependencies:
+   ```bash
+   cd <repo_root>
+   pip install -e ./eng/tools/azure-sdk-tools
+   ```
+
+## Instructions
+
+1. Navigate to the desired package directory
+2. Run the command:
+   ```bash
+   azpysdk apistub --md .
+3. The command outputs the location of the generated markdown file. Provide this file to the user for review.

eng/common/scripts/azsdk_tool_telemetry.ps1

@@ -2,7 +2,6 @@ $ErrorActionPreference = "SilentlyContinue"
 . (Join-Path $PSScriptRoot '..' 'scripts' 'Helpers' 'AzSdkTool-Helpers.ps1')
 
 $cliPath = Get-CommonInstallDirectory
-
 # check for azsdk.exe on Windows or azsdk on Linux/Mac in the install directory
 if ($IsWindows)
 {
@@ -54,8 +53,15 @@ try
     Write-Success
 }
 
-$toolName = $inputData.toolName
-if (-not $toolName)
+$toolName = $null
+$sessionId = $null
+
+# Get tool name. Both vscode and copilot-cli uses different property names, so check for both.
+if ($inputData.PSObject.Properties['toolName'])
+{
+    $toolName = $inputData.toolName
+}
+if (-not $toolName -and $inputData.PSObject.Properties['tool_name'])
 {
     $toolName = $inputData.tool_name
 }
@@ -72,20 +78,27 @@ if ($toolsToIgnore -contains $toolName)
     Write-Success
 }
 
-$sessionId = $inputData.sessionId
-if (-not $sessionId) {
+# Session id
+if ($inputData.PSObject.Properties['sessionId'])
+{
+    $sessionId = $inputData.sessionId
+}
+if (-not $sessionId -and $inputData.PSObject.Properties['session_id'])
+{
     $sessionId = $inputData.session_id
 }
 
 # Get tool input arguments
-$toolInput = $inputData.toolArgs
-if (-not $toolInput)
+$toolInput = $null
+if ($inputData.PSObject.Properties['toolArgs'])
+{
+    $toolInput = $inputData.toolArgs
+}
+if (-not $toolInput -and $inputData.PSObject.Properties['tool_input'])
 {
     $toolInput = $inputData.tool_input
 }
 
-$timestamp = (Get-Date).ToUniversalTime().ToString("yyyy-MM-ddTHH:mm:ssZ")
-
 # Helper to extract path from tool input (handles 'path', 'filePath', 'file_path')
 function Get-ToolInputPath
 {
@@ -112,11 +125,12 @@ else
     $clientType = "copilot-cli"
 }
 
+
 # Process skill invocations (looking for "azsdk" prefix in skill name)
 if ($toolName -eq "skill")
 {
     $skillName = $toolInput.skill
-    if ($skillName -and $skillName.StartsWith("azsdk"))
+    if ($skillName)
     {
         $eventType = "skill_invocation"
         $shouldTrack = $true
@@ -148,7 +162,6 @@ if ($toolName.StartsWith("mcp_azure-sdk") -or $toolName.StartsWith("azure-sdk-mc
 }
 
 # === STEP 3: Publish event ===
-
 if ($shouldTrack)
 {
     # Build MCP command arguments

eng/tools/azure-sdk-tools/azpysdk/apistub.py

@@ -13,7 +13,7 @@
 from ci_tools.parsing import ParsedSetup
 
 REPO_ROOT = discover_repo_root()
-MAX_PYTHON_VERSION = (3, 11)
+PYTHON_VERSION_LIMIT = (3, 11)  # apistub doesn't support Python 3.11+
 
 
 def get_package_wheel_path(pkg_root: str) -> str:
@@ -76,9 +76,9 @@ def run(self, args: argparse.Namespace) -> int:
         """Run the apistub check command."""
         logger.info("Running apistub check...")
 
-        if sys.version_info > MAX_PYTHON_VERSION:
+        if sys.version_info >= PYTHON_VERSION_LIMIT:
             logger.error(
-                f"Python version {sys.version_info.major}.{sys.version_info.minor} is not supported. Maximum supported version is {MAX_PYTHON_VERSION[0]}.{MAX_PYTHON_VERSION[1]}."
+                f"Python version {sys.version_info.major}.{sys.version_info.minor} is not supported. Version must be less than {PYTHON_VERSION_LIMIT[0]}.{PYTHON_VERSION_LIMIT[1]}."
             )
             return 1
 

eng/tools/azure-sdk-tools/tests/test_apistub.py

@@ -86,7 +86,7 @@ def _make_args(self, dest_dir=None, generate_md=False):
     @patch(
         "azpysdk.apistub.REPO_ROOT", os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "..", ".."))
     )
-    @patch("azpysdk.apistub.MAX_PYTHON_VERSION", (99, 99))
+    @patch("azpysdk.apistub.PYTHON_VERSION_LIMIT", (99, 99))
     @patch("azpysdk.apistub.get_cross_language_mapping_path", return_value=None)
     @patch("azpysdk.apistub.get_package_wheel_path", return_value="/fake/pkg.whl")
     @patch("azpysdk.apistub.create_package_and_install")
@@ -139,7 +139,7 @@ def fake_pwsh(cmd, **kwargs):
     @patch(
         "azpysdk.apistub.REPO_ROOT", os.path.abspath(os.path.join(os.path.dirname(__file__), "..", "..", "..", ".."))
     )
-    @patch("azpysdk.apistub.MAX_PYTHON_VERSION", (99, 99))
+    @patch("azpysdk.apistub.PYTHON_VERSION_LIMIT", (99, 99))
     @patch("azpysdk.apistub.get_cross_language_mapping_path", return_value=None)
     @patch("azpysdk.apistub.get_package_wheel_path", return_value="/fake/pkg.whl")
     @patch("azpysdk.apistub.create_package_and_install")