add

Author: l0lawrence

tools/azure-sdk-tools/linting_tools/lint_test_bench/pylint_agent.py

@@ -56,7 +56,7 @@ def get_test_cases():
     """
     try:
         test_cases = []
-        test_files_dir = Path(__file__).parent / 'test_files_without_comment'
+        test_files_dir = Path(__file__).parent / 'test_files'
 
         # Create test_files directory if it doesn't exist
         test_files_dir.mkdir(exist_ok=True)
@@ -231,6 +231,7 @@ def run_pylint(file_path: str, logger) -> dict:
             file_path = Path(__file__).parent / 'test_files' / test_case['name']
             # file_path = Path(__file__).parent / 'test_files_without_comment' / test_case['name']
 
+            print(f"Processing file: {file_path}")
 
             # Run pylint on both original file
             logger.debug("Running pylint on original file...")

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_client_constructor_missing_kwargs.py

@@ -0,0 +1,15 @@
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# --------------------------------------------------------------------------------------------
+
+# This code violates missing-client-constructor-parameter-kwargs
+class ClassNameClient():
+    def __init__(self, credential: str, *, api_version:str = "2018") -> None:
+        """
+        :param credential: The credential to use for authentication.
+        :type credential: str
+        :keyword api_version: The API version to use.
+        :paramtype api_version: str
+        """
+        self.credential: str = credential
+        self.api_version: str = api_version

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_client_constructor_takes_credential.py

@@ -1,13 +1,14 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
-# This code violates missing-client-constructor-parameter-credential and missing-client-constructor-parameter-kwargs
+# This code violates missing-client-constructor-parameter-credential
 class ClassNameClient():
-    def __init__(self, *, api_version:str = "2018") -> None:
+    def __init__(self, *, api_version:str = "2018", **kwargs) -> None:
         """
         :keyword eight: The eighth parameter.
         :paramtype eight: str
         :keyword api_version: The API version to use.
         :paramtype api_version: str
         """
         self.api_version: str = api_version
+        self.eight: str = kwargs.get("eight")

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_client_method_missing_tracing.py

@@ -0,0 +1,9 @@
+# --------------------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# --------------------------------------------------------------------------------------------
+from typing import List
+# This code violates client-method-missing-tracing-decoration
+class Some2Client():
+    def get_thing(self) -> List[str]:
+        return []

…test_bench/test_files/test_lro_poller.py …st_files/test_lro_poller_uses_polling.pytools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_lro_poller.py renamed to tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_lro_poller_uses_polling.py tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_lro_poller.py renamed to tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_lro_poller_uses_polling.py

@@ -6,22 +6,16 @@
 from azure.core.polling import LROPoller
 from azure.core.tracing.decorator import distributed_trace
 
-# This code violates client-lro-methods-use-polling and client-method-missing-tracing-decoration
+# This code violates client-lro-methods-use-polling
 
 class Some1Client():
+    @distributed_trace
     def begin_thing(self, **kwargs) -> LROPoller:
         return LROPoller(self, kwargs.get("some_key"), kwargs.get("some_other_key"), kwargs.get("some_third_key"))
 
     @distributed_trace
-    def begin_thing2(self, **kwargs) -> LROPoller:
-        return LROPoller(self, kwargs.get("some_key"), kwargs.get("some_other_key"), kwargs.get("some_third_key"))
+    def begin_thing2(self, **kwargs) -> List:
+        return []
 
 
-class Some2Client():
-    def begin_thing(self) -> List[str]:
-        return []
 
-    def begin_thing2(self) -> Dict[str, Any]:
-        return {}
-    def poller(self, **kwargs) -> LROPoller:
-        return LROPoller(self, kwargs.get("some_key"), kwargs.get("some_other_key"), kwargs.get("some_third_key"))