Skip to content

Commit 13e7deb

Browse files
scbeddCopilot
andauthored
Remove cosmos filter from pullrequest build definition (#46425)
* Remove cosmos filter from pullrequest build definition Remove sdk/cosmos/ exclusion from pullrequest.yml trigger paths and ExcludePaths parameter so cosmos changes go through the standard PR validation pipeline. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * leave cosmos excluded from the core build * clean out commit file that was checking triggering * update comment to clarify reality --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent dfdfbb2 commit 13e7deb

1 file changed

Lines changed: 3 additions & 8 deletions

File tree

eng/pipelines/pullrequest.yml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,6 @@ pr:
1010
paths:
1111
include:
1212
- "*"
13-
# Note: The ExcludePaths template below needs to duplicate
14-
# any excludes here. The reason being is that we can't access
15-
# pr->paths->exclude
16-
exclude:
17-
- sdk/cosmos/
18-
1913
parameters:
2014
- name: Service
2115
type: string
@@ -28,7 +22,8 @@ extends:
2822
BuildTargetingString: "*"
2923
TestProxy: true
3024
TestTimeOutInMinutes: 180
31-
# See pr->paths->exclude comment above. Anything added/removed there
32-
# needs to be added/removed here.
25+
# we still exclude cosmos, because of the implicit dependency on the cosmos emulator. Within a pullrequest pipeline we do not
26+
# currently have the ability to inject steps from a different ci.yml, which is required to start the cosmos emulator.
27+
# As such, the pullrequest pipeline itself will not invoke the cosmos tests, but the triggered `python - cosmos - ci` public build WILL.
3328
ExcludePaths:
3429
- sdk/cosmos/

0 commit comments

Comments
 (0)