Skip to content

Commit 17df2fc

Browse files
test(servicebus): subtract clock skew buffer from updated_since boundary
All four updated_since live tests (sync + async, queue + subscription) now use 'datetime.now(timezone.utc) - timedelta(minutes=1)' as the boundary so client/server clock skew can't push the freshly-sent session past the cutoff and cause flakes.
1 parent 00dafed commit 17df2fc

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

sdk/servicebus/azure-servicebus/tests/async_tests/test_list_sessions_async.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import pytest
88
import uuid
9-
from datetime import datetime, timezone
9+
from datetime import datetime, timedelta, timezone
1010

1111
from azure.servicebus import ServiceBusMessage
1212
from azure.servicebus.aio import ServiceBusClient
@@ -102,7 +102,8 @@ async def test_list_queue_sessions_updated_since_async(
102102
logging_enable=False,
103103
uamqp_transport=uamqp_transport,
104104
) as sb_client:
105-
before_send = datetime.now(timezone.utc)
105+
# Use a 1-minute buffer to absorb client/server clock skew.
106+
before_send = datetime.now(timezone.utc) - timedelta(minutes=1)
106107

107108
session_id = str(uuid.uuid4())
108109
async with sb_client.get_queue_sender(servicebus_queue.name) as sender:
@@ -199,7 +200,8 @@ async def test_list_subscription_sessions_updated_since_async(
199200
logging_enable=False,
200201
uamqp_transport=uamqp_transport,
201202
) as sb_client:
202-
before_send = datetime.now(timezone.utc)
203+
# Use a 1-minute buffer to absorb client/server clock skew.
204+
before_send = datetime.now(timezone.utc) - timedelta(minutes=1)
203205

204206
session_id = str(uuid.uuid4())
205207
async with sb_client.get_topic_sender(servicebus_topic.name) as sender:

sdk/servicebus/azure-servicebus/tests/test_list_sessions.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import pytest
88
import uuid
9-
from datetime import datetime, timezone
9+
from datetime import datetime, timedelta, timezone
1010

1111
from azure.servicebus import (
1212
ServiceBusClient,
@@ -136,7 +136,8 @@ def test_list_queue_sessions_updated_since(
136136
logging_enable=False,
137137
uamqp_transport=uamqp_transport,
138138
) as sb_client:
139-
before_send = datetime.now(timezone.utc)
139+
# Use a 1-minute buffer to absorb client/server clock skew.
140+
before_send = datetime.now(timezone.utc) - timedelta(minutes=1)
140141

141142
session_id = str(uuid.uuid4())
142143
with sb_client.get_queue_sender(servicebus_queue.name) as sender:
@@ -197,7 +198,8 @@ def test_list_subscription_sessions_updated_since(
197198
logging_enable=False,
198199
uamqp_transport=uamqp_transport,
199200
) as sb_client:
200-
before_send = datetime.now(timezone.utc)
201+
# Use a 1-minute buffer to absorb client/server clock skew.
202+
before_send = datetime.now(timezone.utc) - timedelta(minutes=1)
201203

202204
session_id = str(uuid.uuid4())
203205
with sb_client.get_topic_sender(servicebus_topic.name) as sender:

0 commit comments

Comments
 (0)