You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@@ -115,7 +113,7 @@ This library is failing two release blocking checks - Mypy and Tests - CI. The l
115
113
## Local SDK Generation and Package Lifecycle (TypeSpec)
116
114
117
115
### AUTHORITATIVE REFERENCE
118
-
For all TypeSpec-based SDK workflows (generation, building, validation, testing, versioning, and release), follow #file:../eng/common/instructions/azsdk-tools/local-sdk-workflow.instructions.md
116
+
For all TypeSpec-based SDK workflows (generation, building, validation, testing, versioning, and release), follow #file:skills/azsdk-common-generate-sdk-locally/SKILL.md
119
117
120
118
### DEFAULT BEHAVIORS
121
119
-**Repository:** Use the current workspace as the local SDK repository unless the user specifies a different path.
@@ -154,6 +152,10 @@ These rules apply to management-plane SDK packages located at `sdk/*/azure-mgmt-
154
152
155
153
### CLIENT SIGNATURE
156
154
- The `__init__` method of the client class in `_client.py` must include the parameters `credential`, `subscription_id`, and `base_url`**in that order**. Default values are not checked.
155
+
- If `subscription_id` is **not** present in the client's `__init__` signature, `pyproject.toml` must contain `no_sub = true`. If it does not, hint the user to add `no_sub = true` in `pyproject.toml` and regenerate the SDK.
156
+
157
+
### CLIENT NAME CONSISTENCY
158
+
- The client class name in `_client.py`, the client name referenced in `README.md`, and the `title` value in `pyproject.toml` must all be the same.
157
159
158
160
### README CODE SNIPPETS
159
161
- Code snippets in `README.md` must follow the real client class signatures and usage patterns. Verify that sample code matches the actual client API.
@@ -162,4 +164,4 @@ These rules apply to management-plane SDK packages located at `sdk/*/azure-mgmt-
162
164
163
165
## SDK release
164
166
165
-
For detailed workflow instructions, see [SDK Release](https://github.com/Azure/azure-sdk-for-python/blob/main/eng/common/instructions/copilot/sdk-release.instructions.md).
167
+
For detailed workflow instructions, see [SDK Release](skills/azsdk-common-sdk-release/SKILL.md).
description: "Analyze and resolve APIView review feedback on Azure SDK PRs. **UTILITY SKILL**. USE FOR: APIView comments, API review feedback, SDK API surface changes. DO NOT USE FOR: general code review, non-APIView feedback. INVOKES: azure-sdk-mcp:azsdk_apiview_get_comments, azure-sdk-mcp:azsdk_typespec_customized_code_update."
8
+
compatibility:
9
+
requires: "azure-sdk-mcp server, SDK pull request with APIView review link"
10
+
---
11
+
12
+
# APIView Feedback Resolution
13
+
14
+
**Prerequisites:** azure-sdk-mcp server required; no CLI fallback. Without MCP, this skill cannot retrieve APIView comments or apply TypeSpec changes. Connect the `azure-sdk-mcp` server before use.
15
+
16
+
## MCP Tools
17
+
18
+
| Tool | Purpose |
19
+
|------|---------|
20
+
|`azure-sdk-mcp:azsdk_apiview_get_comments`| Get APIView comments |
1.**Retrieve** — Get APIView URL from SDK PR, run `azsdk_apiview_get_comments`.
29
+
2.**Categorize** — Group as Critical/Suggestions/Informational per [feedback steps](references/feedback-resolution-steps.md).
30
+
3.**Resolve** — Use `azsdk_typespec_customized_code_update` for TypeSpec changes; delegate via `azsdk_typespec_delegate_apiview_feedback` for complex cases.
31
+
4.**Validate** — Run validation, regenerate SDK, build and test.
32
+
5.**Confirm** — Verify all items addressed. If delegated, follow [post-delegation follow-up](references/feedback-resolution-steps.md#post-delegation-follow-up). Request re-review.
33
+
34
+
## Examples
35
+
36
+
- "Resolve the APIView comments on my SDK pull request"
37
+
- "What feedback did the API reviewer leave?"
38
+
39
+
## Troubleshooting
40
+
41
+
-**No comments**: Verify PR has APIView link and MCP server is connected.
42
+
-**Validation fails**: Re-run after fixing TypeSpec errors.
43
+
-**MCP unavailable**: Requires `azure-sdk-mcp` server; no CLI fallback. Connect the server and retry.
description: Should trigger when user provides an APIView URL without explicitly saying APIView
4
+
inputs:
5
+
prompt: "I have review comments on my SDK PR from this page: https://spa.apiview.dev/review/abc123?activeApiRevisionId=def456 — can you help me resolve them?"
0 commit comments