Skip to content

Commit 4592663

Browse files
Copilotm7md7sien
andauthored
rename not_applicable to pass in _return_not_applicable_result and update tests
Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/e94d600e-75a6-4b62-92cf-420fb1597e29 Co-authored-by: m7md7sien <16615690+m7md7sien@users.noreply.github.com>
1 parent adff374 commit 4592663

3 files changed

Lines changed: 3 additions & 4 deletions

File tree

sdk/evaluation/azure-ai-evaluation/azure/ai/evaluation/_evaluators/_common/_base_prompty_eval.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,6 @@ def _not_applicable_result(
439439

440440
return result
441441

442-
# TODO: After all evaluators output are updated, we can remove the _not_applicable_result method and replace calls to it with _return_not_applicable_result, which returns a "skipped" status instead of "pass" to avoid confusion.
443442
def _return_not_applicable_result(
444443
self, error_message: str, threshold: Union[int, float]
445444
) -> Dict[str, Union[str, float, Dict, None]]:
@@ -455,7 +454,7 @@ def _return_not_applicable_result(
455454
return {
456455
f"{self._result_key}": None,
457456
f"{self._result_key}_score": None,
458-
f"{self._result_key}_result": "not_applicable",
457+
f"{self._result_key}_result": "pass",
459458
f"{self._result_key}_passed": None,
460459
f"{self._result_key}_reason": f"Not applicable: {error_message}",
461460
f"{self._result_key}_status": "skipped",

sdk/evaluation/azure-ai-evaluation/tests/unittests/test_agent_evaluators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def test_tool_call_accuracy_evaluator_missing_inputs(self, mock_model_config):
6767
],
6868
)
6969
assert result[f"{ToolCallAccuracyEvaluator._RESULT_KEY}_score"] is None
70-
assert result[f"{ToolCallAccuracyEvaluator._RESULT_KEY}_result"] == "not_applicable"
70+
assert result[f"{ToolCallAccuracyEvaluator._RESULT_KEY}_result"] == "pass"
7171
assert result[f"{ToolCallAccuracyEvaluator._RESULT_KEY}_status"] == "skipped"
7272
assert (
7373
"not applicable" in result[f"{ToolCallAccuracyEvaluator._RESULT_KEY}_reason"].lower()

sdk/evaluation/azure-ai-evaluation/tests/unittests/test_tool_call_accuracy_evaluator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -338,7 +338,7 @@ def test_evaluate_tools_some_missing_tool_definitions(self, mock_model_config):
338338
key = ToolCallAccuracyEvaluator._RESULT_KEY
339339
assert result is not None
340340
assert result[f"{key}_score"] is None
341-
assert result[f"{key}_result"] == "not_applicable"
341+
assert result[f"{key}_result"] == "pass"
342342
assert result[f"{key}_status"] == "skipped"
343343
assert result[f"{key}_threshold"] == ToolCallAccuracyEvaluator._DEFAULT_TOOL_CALL_ACCURACY_SCORE
344344
assert (

0 commit comments

Comments
 (0)