Skip to content

Commit 49fc574

Browse files
committed
Resolve CI failures
1 parent 0209e28 commit 49fc574

5 files changed

Lines changed: 108 additions & 17 deletions

File tree

.github/cspell.yaml

Lines changed: 50 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,81 @@
11
version: "0.2"
2-
import:
3-
- ../cspell.yaml
42
ignorePaths:
53
- CODEOWNERS*
64
- arm-leases/**
75
- policies/**
6+
- shared/test/fixtures/**
87
- workflows/*.lock.yml
98
- workflows/**/*.md
109
words:
10+
- afec
1111
- azmanager
1212
- azsdk
1313
- brch
1414
- buildid
1515
- byval
16+
- chatmode
17+
- chatmodes
18+
- classsvc
19+
- cleansvc
20+
- cnatestsvc
1621
- contosowidget
1722
- contosowidgetmanager
1823
- dapr
24+
- delsvc
25+
- descrsvc
26+
- efer
27+
- enumsvc
28+
- esbuild
29+
- evals
30+
- exsvc
1931
- fflate
32+
- fmtsvc
33+
- foos
34+
- gadgetsvc
35+
- handwrittensvc
36+
- incompleted
37+
- inlinesvc
38+
- iscai
39+
- itemsvc
40+
- legacysvc
41+
- Liftr
42+
- liftr
43+
- lrosvc
44+
- msyyc
45+
- namingsvc
46+
- nosupprsvc
47+
- npmjs
2048
- oapi
49+
- oavrunnertests
50+
- Pillalamarri
2151
- plcy
52+
- pipefail
53+
- promisified
54+
- proxysvc
2255
- pwsh
56+
- reposting
57+
- reqpropsvc
2358
- retarget
2459
- rhysd
2560
- rpaa
2661
- rpaas
62+
- rpass
63+
- rphelp
64+
- secsupprsvc
65+
- secretsvc
66+
- Swathi
2767
- tsgs
68+
- tspgenservice
69+
- typespec
70+
- typechgsvc
71+
- tseslint
72+
- unlabels
73+
- unshift
2874
- unstub
75+
- vally
2976
- vitest
3077
- whatif
78+
- widgetsvc
3179

3280
overrides:
3381
- filename: "**/.github/chatmodes/api-review-feedback.chatmode.md"

.github/shared/readme.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ This document has two audiences:
1313

1414
## API reference
1515

16-
Each module is published as a subpath export in [`package.json`](./package.json) (for example
16+
Each module is published as a subpath export in [`../package.json`](../package.json) (for example
1717
`@azure-tools/specs-shared/array`). Import directly from the subpath, e.g.:
1818

1919
```js
@@ -165,7 +165,6 @@ Single source of truth for breaking-change and versioning approval label names a
165165
├── perf/ # Performance benchmarks (tinybench)
166166
├── src/ # The shared library source (one module per file)
167167
├── test/ # Vitest unit tests + fixtures and test helpers
168-
├── package.json # Subpath "exports", "bin", scripts, dependencies
169168
├── tsconfig.json # Type-checking config (lint:tsc)
170169
├── eslint.config.js # ESLint config (also re-exported as eslint-base-config)
171170
└── vitest.config.js # Test + coverage config
@@ -174,15 +173,15 @@ Single source of truth for breaking-change and versioning approval label names a
174173
### `src`
175174

176175
The shared library. Each file is a focused module (see the [API reference](#api-reference)) and is
177-
exposed to consumers through a subpath in [`package.json`](./package.json)'s `exports`. See
176+
exposed to consumers through a subpath in [`../package.json`](../package.json)'s `exports`. See
178177
[`src/README.md`](./src/README.md) for notes on consuming the code from TypeScript.
179178

180179
Conventions:
181180

182181
- Plain ESM JavaScript annotated with JSDoc — no separate `.ts` sources or build step. Types are
183182
inferred from JSDoc, so keep annotations accurate.
184183
- Runtime dependencies are kept to an absolute minimum (ideally zero transitive dependencies) for
185-
performance, and must be a subset of the parent [`../package.json`](../package.json).
184+
performance, and must be declared in [`../package.json`](../package.json).
186185

187186
### `test`
188187

@@ -209,14 +208,14 @@ backs `npx spec-model` for dumping a `SpecModel` to JSON.
209208
When adding or changing shared code:
210209

211210
1. **Add the module** under `src` as a single-responsibility file with JSDoc-annotated exports.
212-
2. **Export it** by adding a subpath entry to the `exports` map in [`package.json`](./package.json).
211+
2. **Export it** by adding a subpath entry to the `exports` map in [`../package.json`](../package.json).
213212
3. **Test it** by adding/updating `test/<module>.test.js`; add fixtures under `test/fixtures` if
214213
needed.
215214
4. **Keep dependencies minimal** — avoid new runtime dependencies; any you add must already exist in
216215
[`../package.json`](../package.json).
217216
5. **Document new APIs** by updating the [API reference](#api-reference) above.
218217

219-
Useful scripts (run from `.github/shared`):
218+
Useful scripts (run from `.github`):
220219

221220
| Command | Description |
222221
| ---------------------- | -------------------------------------------------- |
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
## Ruby
2+
3+
These settings apply only when `--ruby` is specified on the command line.
4+
5+
``` yaml $(ruby)
6+
azure-arm: true
7+
namespace: Azure::ServiceLinker
8+
package-name: azure_mgmt_servicelinker
9+
```

.vscode/cspell.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
{
22
"version": "0.2",
3+
"import": [
4+
"../.github/cspell.yaml"
5+
],
36
"language": "en",
47
"languageId": "python",
58
"dictionaries": [

eng/pipelines/templates/jobs/ci.yml

Lines changed: 41 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -236,15 +236,47 @@ jobs:
236236
parameters:
237237
ContinueOnError: false
238238

239-
- template: /eng/common/pipelines/templates/steps/verify-links.yml
240-
parameters:
241-
${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
242-
Directory: ''
243-
Urls: (eng/common/scripts/get-markdown-files-from-changed-files.ps1)
244-
${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
245-
Directory: sdk/${{ parameters.ServiceDirectory }}
246-
CheckLinkGuidance: $true
247-
Condition: succeededOrFailed()
239+
- ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
240+
- task: PowerShell@2
241+
displayName: Link verification check
242+
condition: succeededOrFailed()
243+
inputs:
244+
pwsh: true
245+
workingDirectory: '$(System.DefaultWorkingDirectory)'
246+
filePath: eng/common/scripts/Verify-Links.ps1
247+
arguments: >
248+
-urls (eng/common/scripts/get-markdown-files-from-changed-files.ps1)
249+
-rootUrl "file://$(System.DefaultWorkingDirectory)/"
250+
-recursive: false
251+
-ignoreLinksFile $(Build.SourcesDirectory)/eng/ignore-links.txt
252+
-branchReplaceRegex "^(${env:SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI}(?:\.git)?/(?:blob|tree)/)main(/.*)$"
253+
-branchReplacementName ${env:SYSTEM_PULLREQUEST_SOURCECOMMITID}
254+
-checkLinkGuidance: true
255+
-localBuildRepoName "$env:BUILD_REPOSITORY_NAME"
256+
-localBuildRepoPath $(Build.SourcesDirectory)
257+
-inputCacheFile "https://azuresdkartifacts.blob.core.windows.net/verify-links-cache/verify-links-cache.txt"
258+
-allowRelativeLinksFile "$(Build.SourcesDirectory)/eng/common/scripts/allow-relative-links.txt"
259+
260+
- ${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
261+
- task: PowerShell@2
262+
displayName: Link verification check
263+
condition: succeededOrFailed()
264+
inputs:
265+
pwsh: true
266+
workingDirectory: '$(System.DefaultWorkingDirectory)/sdk/${{ parameters.ServiceDirectory }}'
267+
filePath: eng/common/scripts/Verify-Links.ps1
268+
arguments: >
269+
-urls (Get-ChildItem -Path ./ -Recurse -Include *.md)
270+
-rootUrl "file://$(System.DefaultWorkingDirectory)/sdk/${{ parameters.ServiceDirectory }}"
271+
-recursive: false
272+
-ignoreLinksFile $(Build.SourcesDirectory)/eng/ignore-links.txt
273+
-branchReplaceRegex "^(${env:SYSTEM_PULLREQUEST_SOURCEREPOSITORYURI}(?:\.git)?/(?:blob|tree)/)main(/.*)$"
274+
-branchReplacementName $(Build.SourceVersion)
275+
-checkLinkGuidance: true
276+
-localBuildRepoName "$env:BUILD_REPOSITORY_NAME"
277+
-localBuildRepoPath $(Build.SourcesDirectory)
278+
-inputCacheFile "https://azuresdkartifacts.blob.core.windows.net/verify-links-cache/verify-links-cache.txt"
279+
-allowRelativeLinksFile "$(Build.SourcesDirectory)/eng/common/scripts/allow-relative-links.txt"
248280
249281
- task: DownloadPipelineArtifact@2
250282
condition: succeededOrFailed()

0 commit comments

Comments
 (0)