[Tables] Fix tests (#45101)

* [Tables] Fix tests

Azure Core 1.38.1 introduced a change in URL formatting that impacts the
recordings of four tests.

The recordings were updated for these, and a conditional was added to
ensure that it still passes the mindependency check. These conditionals
can be removed once the minimum dependency of azure-core for this
package is at least 1.38.1.

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* Update setup.py

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

* Add live test condition

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

---------

Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>

Author: pvaneck

sdk/tables/azure-data-tables/assets.json

@@ -2,5 +2,5 @@
   "AssetsRepo": "Azure/azure-sdk-assets",
   "AssetsRepoPrefixPath": "python",
   "TagPrefix": "python/tables/azure-data-tables",
-  "Tag": "python/tables/azure-data-tables_48a9914a75"
+  "Tag": "python/tables/azure-data-tables_afc53b2631"
 }

sdk/tables/azure-data-tables/setup.py

@@ -45,7 +45,7 @@
     url="https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/tables/azure-data-tables",
     keywords="azure, azure sdk",
     classifiers=[
-        "Development Status :: 5 - Production/Stable",
+        "Development Status :: 4 - Beta",
         "Programming Language :: Python",
         "Programming Language :: Python :: 3 :: Only",
         "Programming Language :: Python :: 3",

sdk/tables/azure-data-tables/tests/test_table_service_properties.py

@@ -7,6 +7,7 @@
 # --------------------------------------------------------------------------
 import time
 import pytest
+from packaging.version import Version
 
 from devtools_testutils import AzureRecordedTestCase, recorded_by_proxy
 
@@ -17,6 +18,7 @@
     TableRetentionPolicy,
     TableCorsRule,
 )
+from azure.core import VERSION as core_version
 from azure.core.exceptions import ResourceNotFoundError, HttpResponseError
 
 from _shared.testcase import TableTestCase
@@ -182,15 +184,18 @@ def test_client_with_url_ends_with_table_name(
         assert ("table specified does not exist") in str(exc.value)
         assert ("Please check your account URL.") in str(exc.value)
 
-        with pytest.raises(HttpResponseError) as exc:
-            tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
-        assert ("URI is invalid") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
-
-        with pytest.raises(HttpResponseError) as exc:
-            tsc.get_service_properties()
-        assert ("URI is invalid") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
+        # Azure Core 1.38.1 introduced a change to URL formatting which can cause recording mismatches in
+        # mindependency checks.
+        if Version(core_version) >= Version("1.38.1") or self.is_live:
+            with pytest.raises(HttpResponseError) as exc:
+                tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
+            assert ("URI is invalid") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
+
+            with pytest.raises(HttpResponseError) as exc:
+                tsc.get_service_properties()
+            assert ("URI is invalid") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
 
         tsc.delete_table(table_name)
 

sdk/tables/azure-data-tables/tests/test_table_service_properties_async.py

@@ -5,12 +5,14 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
+from packaging.version import Version
 import time
 import pytest
 
 from devtools_testutils import AzureRecordedTestCase
 from devtools_testutils.aio import recorded_by_proxy_async
 
+from azure.core import VERSION as core_version
 from azure.core.exceptions import ResourceNotFoundError, HttpResponseError
 
 from azure.data.tables import TableAnalyticsLogging, TableMetrics, TableRetentionPolicy, TableCorsRule
@@ -183,15 +185,18 @@ async def test_client_with_url_ends_with_table_name(
         assert ("table specified does not exist") in str(exc.value)
         assert ("Please check your account URL.") in str(exc.value)
 
-        with pytest.raises(HttpResponseError) as exc:
-            await tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
-        assert ("URI is invalid") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
-
-        with pytest.raises(HttpResponseError) as exc:
-            await tsc.get_service_properties()
-        assert ("URI is invalid") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
+        # Azure Core 1.38.1 introduced a change to URL formatting which can cause recording mismatches in
+        # mindependency checks.
+        if Version(core_version) >= Version("1.38.1") or self.is_live:
+            with pytest.raises(HttpResponseError) as exc:
+                await tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
+            assert ("URI is invalid") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
+
+            with pytest.raises(HttpResponseError) as exc:
+                await tsc.get_service_properties()
+            assert ("URI is invalid") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
 
         await tsc.delete_table(table_name)
 

sdk/tables/azure-data-tables/tests/test_table_service_properties_cosmos.py

@@ -5,10 +5,12 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
+from packaging.version import Version
 import pytest
 
 from devtools_testutils import AzureRecordedTestCase, recorded_by_proxy
 
+from azure.core import VERSION as core_version
 from azure.core.exceptions import HttpResponseError
 
 from azure.data.tables import (
@@ -70,15 +72,18 @@ def test_client_with_url_ends_with_table_name(self, tables_cosmos_account_name,
         assert ("Server failed to authenticate the request") in str(exc.value)
         assert ("Please check your account URL.") in str(exc.value)
 
-        with pytest.raises(HttpResponseError) as exc:
-            tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
-        assert ("Server failed to authenticate the request") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
-
-        with pytest.raises(HttpResponseError) as exc:
-            tsc.get_service_properties()
-        assert ("Server failed to authenticate the request") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
+        # Azure Core 1.38.1 introduced a change to URL formatting which can cause recording mismatches in
+        # mindependency checks.
+        if Version(core_version) >= Version("1.38.1") or self.is_live:
+            with pytest.raises(HttpResponseError) as exc:
+                tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
+            assert ("Server failed to authenticate the request") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
+
+            with pytest.raises(HttpResponseError) as exc:
+                tsc.get_service_properties()
+            assert ("Server failed to authenticate the request") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
 
         with pytest.raises(HttpResponseError) as exc:
             tsc.delete_table(table_name)

sdk/tables/azure-data-tables/tests/test_table_service_properties_cosmos_async.py

@@ -5,13 +5,15 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
+from packaging.version import Version
 import pytest
 
 from devtools_testutils import AzureRecordedTestCase
 from devtools_testutils.aio import recorded_by_proxy_async
 
 from azure.data.tables import TableAnalyticsLogging, TableMetrics, TableRetentionPolicy, TableCorsRule
 from azure.data.tables.aio import TableServiceClient
+from azure.core import VERSION as core_version
 from azure.core.exceptions import HttpResponseError
 
 from _shared.asynctestcase import AsyncTableTestCase
@@ -71,15 +73,18 @@ async def test_client_with_url_ends_with_table_name(
         assert ("Server failed to authenticate the request") in str(exc.value)
         assert ("Please check your account URL.") in str(exc.value)
 
-        with pytest.raises(HttpResponseError) as exc:
-            await tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
-        assert ("Server failed to authenticate the request") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
-
-        with pytest.raises(HttpResponseError) as exc:
-            await tsc.get_service_properties()
-        assert ("Server failed to authenticate the request") in str(exc.value)
-        assert ("Please check your account URL.") in str(exc.value)
+        # Azure Core 1.38.1 introduced a change to URL formatting which can cause recording mismatches in
+        # mindependency checks.
+        if Version(core_version) >= Version("1.38.1") or self.is_live:
+            with pytest.raises(HttpResponseError) as exc:
+                await tsc.set_service_properties(analytics_logging=TableAnalyticsLogging(write=True))
+            assert ("Server failed to authenticate the request") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
+
+            with pytest.raises(HttpResponseError) as exc:
+                await tsc.get_service_properties()
+            assert ("Server failed to authenticate the request") in str(exc.value)
+            assert ("Please check your account URL.") in str(exc.value)
 
         with pytest.raises(HttpResponseError) as exc:
             await tsc.delete_table(table_name)