Commit 7dfbd7a
[agentserver] address feedback: tags internal, single shutdown-grace env var, simpler CHANGELOG, simpler README
Per review feedback:
1. **Single shutdown-grace env var.** Removed
AGENTSERVER_TASK_MANAGER_SHUTDOWN_GRACE_SECONDS; the framework now
reads only AGENTSERVER_SHUTDOWN_GRACE_SECONDS.
2. **Tags is internal.** Removed the public 'tags=' keyword from the
@task decorator and Task.options(...). The framework still uses
the internal TaskOptions.tags field for source-stamping; developers
no longer have a way to set arbitrary tags from the public surface.
- Removed: samples/durable_source (only demonstrated the removed
tags= public keyword)
- Removed: tests/durable/test_callable_factories.py (only tested
the removed tags-callable factory feature)
- Removed: tests/durable/test_sample_e2e.py::
test_reserved_tag_cannot_be_overridden
- Updated: tests/durable/test_decorator.py to remove tags= cases
and add 'tags' to the retired-args parametrize list
- Updated: docs/durable-task-guide.md to drop the tags row from the
@task reference table and the 'tags' mention in the recovery-safe
options paragraph
3. **CHANGELOG simplified.** Trimmed the 2.0.0b6 entry to two bullets
(durable-task primitive + httpx removal) — end-developer-facing,
not a duplicate of the guide. Same treatment for invocations
1.0.0b5 (one bullet covering the four durable samples).
4. **README simplified.** Replaced the two durable examples (one with
timeout but no cancellation hook; one storing conversation history
in ctx.metadata — both anti-patterns per our own guide) with a
single minimal example showing the @task decorator and .run() call.
Pointers to the developer guide for streaming/suspend/retry/timeout.
Verified: 433 core tests pass, pylint 10.00/10, mypy 0 new errors.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 24dc2c5 commit 7dfbd7a
12 files changed
Lines changed: 61 additions & 525 deletions
File tree
- sdk/agentserver
- azure-ai-agentserver-core
- azure/ai/agentserver/core
- durable
- docs
- samples/durable_source
- tests/durable
- azure-ai-agentserver-invocations
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
127 | 26 | | |
128 | 27 | | |
129 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
121 | | - | |
122 | | - | |
| 121 | + | |
123 | 122 | | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
| 123 | + | |
129 | 124 | | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
140 | 134 | | |
141 | 135 | | |
142 | 136 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
154 | | - | |
155 | | - | |
156 | | - | |
157 | | - | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
162 | | - | |
| 137 | + | |
163 | 138 | | |
164 | 139 | | |
165 | 140 | | |
| |||
Lines changed: 6 additions & 12 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
51 | 48 | | |
52 | 49 | | |
53 | 50 | | |
54 | 51 | | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
| 52 | + | |
59 | 53 | | |
60 | 54 | | |
61 | 55 | | |
| |||
Lines changed: 2 additions & 31 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1126 | 1126 | | |
1127 | 1127 | | |
1128 | 1128 | | |
1129 | | - | |
1130 | 1129 | | |
1131 | 1130 | | |
1132 | 1131 | | |
| |||
1138 | 1137 | | |
1139 | 1138 | | |
1140 | 1139 | | |
1141 | | - | |
1142 | | - | |
1143 | 1140 | | |
1144 | 1141 | | |
1145 | 1142 | | |
| |||
1151 | 1148 | | |
1152 | 1149 | | |
1153 | 1150 | | |
1154 | | - | |
1155 | | - | |
1156 | | - | |
1157 | | - | |
1158 | | - | |
1159 | | - | |
1160 | | - | |
1161 | | - | |
1162 | | - | |
1163 | | - | |
1164 | | - | |
1165 | | - | |
1166 | | - | |
1167 | | - | |
1168 | | - | |
1169 | | - | |
1170 | | - | |
1171 | 1151 | | |
1172 | 1152 | | |
1173 | 1153 | | |
1174 | | - | |
| 1154 | + | |
1175 | 1155 | | |
1176 | 1156 | | |
1177 | 1157 | | |
| |||
1197 | 1177 | | |
1198 | 1178 | | |
1199 | 1179 | | |
1200 | | - | |
1201 | 1180 | | |
1202 | 1181 | | |
1203 | 1182 | | |
| |||
1214 | 1193 | | |
1215 | 1194 | | |
1216 | 1195 | | |
1217 | | - | |
1218 | 1196 | | |
1219 | 1197 | | |
1220 | 1198 | | |
| |||
1239 | 1217 | | |
1240 | 1218 | | |
1241 | 1219 | | |
1242 | | - | |
1243 | | - | |
1244 | 1220 | | |
1245 | 1221 | | |
1246 | 1222 | | |
| |||
1275 | 1251 | | |
1276 | 1252 | | |
1277 | 1253 | | |
1278 | | - | |
1279 | | - | |
1280 | | - | |
1281 | | - | |
1282 | | - | |
1283 | 1254 | | |
1284 | 1255 | | |
1285 | 1256 | | |
1286 | | - | |
| 1257 | + | |
1287 | 1258 | | |
1288 | 1259 | | |
1289 | 1260 | | |
| |||
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
659 | 659 | | |
660 | 660 | | |
661 | 661 | | |
662 | | - | |
663 | 662 | | |
664 | 663 | | |
665 | 664 | | |
| |||
695 | 694 | | |
696 | 695 | | |
697 | 696 | | |
698 | | - | |
| 697 | + | |
699 | 698 | | |
700 | 699 | | |
701 | 700 | | |
| |||
0 commit comments