Clean up unit tests and bump spec pin

- Drop unit tests that only assert generated surface (inspect.signature
  checks, generated enum values, default api_version from generated
  _configuration.py, generated parent-model serialization).
- Trim test_search_indexer_models.py to the two overload-contract tests
  that guard hand-written @overload signatures in
  indexes/models/_patch.py (SearchIndexerDataSourceConnection,
  SearchResourceEncryptionKey); add a module docstring explaining why.
- Migrate async-test capability gates to aio.SearchClient.search.* and
  AsyncSearchItemPaged.get_debug_info so async tests gate the async
  public surface instead of the sync one.
- Move SearchIndex.{cors_options, permission_filter_option,
  purview_enabled} gates onto test_list_indexes_with_select_forwards_
  paging_kwargs (the test that actually exercises
  _convert_index_response).
- Bump tsp-location.yaml from 4bb11e927c to merge commit 8be8c75d9b
  (squash-merge of the spec PR on main; tree-equivalent under
  specification/search/).

309 unit tests pass; mypy / pylint / black clean.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: hizixin

sdk/search/azure-search-documents/tests/_capabilities.py

@@ -353,7 +353,27 @@ def _client_capabilities() -> Mapping[str, Mapping[str, Any]]:
     "SearchClient.search.query_source_authorization": _surface(
         "azure.search.documents.SearchClient.search", ("query_source_authorization",)
     ),
+    "aio.SearchClient.search.query_rewrites": _surface(
+        "azure.search.documents.aio.SearchClient.search", ("query_rewrites",)
+    ),
+    "aio.SearchClient.search.hybrid_search": _surface(
+        "azure.search.documents.aio.SearchClient.search", ("hybrid_search",)
+    ),
+    "aio.SearchClient.search.semantic_fields": _surface(
+        "azure.search.documents.aio.SearchClient.search", ("semantic_fields",)
+    ),
+    "aio.SearchClient.search.query_language": _surface(
+        "azure.search.documents.aio.SearchClient.search", ("query_language",)
+    ),
+    "aio.SearchClient.search.speller": _surface("azure.search.documents.aio.SearchClient.search", ("speller",)),
+    "aio.SearchClient.search.enable_elevated_read": _surface(
+        "azure.search.documents.aio.SearchClient.search", ("enable_elevated_read",)
+    ),
+    "aio.SearchClient.search.query_source_authorization": _surface(
+        "azure.search.documents.aio.SearchClient.search", ("query_source_authorization",)
+    ),
     "SearchItemPaged.get_debug_info": _surface("azure.search.documents.SearchItemPaged.get_debug_info"),
+    "AsyncSearchItemPaged.get_debug_info": _surface("azure.search.documents.aio.AsyncSearchItemPaged.get_debug_info"),
     "KnowledgeBaseRetrievalClient": _surface("azure.search.documents.knowledgebases.KnowledgeBaseRetrievalClient"),
     "KnowledgeBaseRetrievalClient.aio": _surface(
         "azure.search.documents.knowledgebases.aio.KnowledgeBaseRetrievalClient"

sdk/search/azure-search-documents/tests/test_search_client.py

@@ -257,16 +257,6 @@ def test_search_converts_atsearch_metadata_keys_on_each_result(self, mock_search
         assert document["@search.captions"][0].text == "summary"
         assert document["@search.document_debug_info"] is not None
 
-    @mock.patch("azure.search.documents._operations._operations._SearchClientOperationsMixin._search_post")
-    def test_search_accepts_comma_delimited_select(self, mock_search_post):
-        mock_search_post.return_value = create_search_documents_result()
-        client = create_search_client()
-
-        result = client.search(search_text=SEARCH_TEXT, select="HotelId,HotelName")
-        next(result)
-
-        assert get_search_request(mock_search_post).select == ["HotelId", "HotelName"]
-
     @mock.patch("azure.search.documents._operations._operations._SearchClientOperationsMixin._search_post")
     def test_search_metadata_accessors_fetch_first_page_once_and_clear_continuation(self, mock_search_post):
         search_result = create_search_documents_result()

sdk/search/azure-search-documents/tests/test_search_client_async.py

@@ -180,11 +180,11 @@ async def test_search_passes_query_language_speller_rewrites_semantic_fields_and
         self, mock_search_post
     ):
         require_capability(
-            "SearchClient.search.query_language",
-            "SearchClient.search.speller",
-            "SearchClient.search.query_rewrites",
-            "SearchClient.search.semantic_fields",
-            "SearchClient.search.hybrid_search",
+            "aio.SearchClient.search.query_language",
+            "aio.SearchClient.search.speller",
+            "aio.SearchClient.search.query_rewrites",
+            "aio.SearchClient.search.semantic_fields",
+            "aio.SearchClient.search.hybrid_search",
             "azure.search.documents.models.HybridSearch",
             "azure.search.documents.models.HybridSearch.max_text_recall_size",
             "azure.search.documents.models.HybridSearch.count_and_facet_mode",
@@ -215,8 +215,8 @@ async def test_search_passes_query_language_speller_rewrites_semantic_fields_and
     @mock.patch("azure.search.documents.aio._operations._operations._SearchClientOperationsMixin._search_post")
     async def test_search_translates_legacy_x_ms_kwargs_to_generated_names(self, mock_search_post):
         require_capability(
-            "SearchClient.search.enable_elevated_read",
-            "SearchClient.search.query_source_authorization",
+            "aio.SearchClient.search.enable_elevated_read",
+            "aio.SearchClient.search.query_source_authorization",
         )
         mock_search_post.return_value = create_search_documents_result()
         async with create_search_client() as client:
@@ -260,16 +260,6 @@ async def test_search_converts_atsearch_metadata_keys_on_each_result(self, mock_
         assert document["@search.captions"][0].text == "summary"
         assert document["@search.document_debug_info"] is not None
 
-    @pytest.mark.asyncio
-    @mock.patch("azure.search.documents.aio._operations._operations._SearchClientOperationsMixin._search_post")
-    async def test_search_accepts_comma_delimited_select(self, mock_search_post):
-        mock_search_post.return_value = create_search_documents_result()
-        async with create_search_client() as client:
-            result = await client.search(search_text=SEARCH_TEXT, select="HotelId,HotelName")
-            await result.__anext__()
-
-        assert get_search_request(mock_search_post).select == ["HotelId", "HotelName"]
-
     @pytest.mark.asyncio
     @mock.patch("azure.search.documents.aio._operations._operations._SearchClientOperationsMixin._search_post")
     async def test_search_metadata_accessors_fetch_first_page_once_and_clear_continuation(self, mock_search_post):
@@ -311,7 +301,7 @@ async def test_search_metadata_accessors_return_none_when_metadata_is_absent(sel
     async def test_get_debug_info_returns_response_debug_info(self, mock_search_post):
         require_capability(
             "azure.search.documents.models.DebugInfo",
-            "SearchItemPaged.get_debug_info",
+            "AsyncSearchItemPaged.get_debug_info",
         )
         from azure.search.documents.models import DebugInfo
 

sdk/search/azure-search-documents/tests/test_search_field_helpers.py

@@ -17,18 +17,6 @@
     SimpleField,
 )
 
-CANONICAL_FIELD_TYPES = [
-    ("STRING", "Edm.String"),
-    ("INT32", "Edm.Int32"),
-    ("INT64", "Edm.Int64"),
-    ("SINGLE", "Edm.Single"),
-    ("DOUBLE", "Edm.Double"),
-    ("BOOLEAN", "Edm.Boolean"),
-    ("DATE_TIME_OFFSET", "Edm.DateTimeOffset"),
-    ("GEOGRAPHY_POINT", "Edm.GeographyPoint"),
-    ("COMPLEX", "Edm.ComplexType"),
-]
-
 
 def _assert_default_analyzer_settings(field):
     assert field.analyzer_name is None
@@ -38,10 +26,6 @@ def _assert_default_analyzer_settings(field):
 
 
 class TestSearchFieldDataType:
-    @pytest.mark.parametrize(("name", "value"), CANONICAL_FIELD_TYPES)
-    def test_canonical_members_keep_edm_values(self, name, value):
-        assert getattr(SearchFieldDataType, name) == value
-
     @pytest.mark.parametrize(
         ("alias", "canonical"),
         [

sdk/search/azure-search-documents/tests/test_search_index_client.py

@@ -86,6 +86,9 @@ def test_list_indexes_with_select_forwards_paging_kwargs(self, mock_list_select)
             "azure.search.documents.indexes.SearchIndexClient.list_indexes.top",
             "azure.search.documents.indexes.SearchIndexClient.list_indexes.skip",
             "azure.search.documents.indexes.SearchIndexClient.list_indexes.count",
+            "azure.search.documents.indexes.models.SearchIndex.cors_options",
+            "azure.search.documents.indexes.models.SearchIndex.permission_filter_option",
+            "azure.search.documents.indexes.models.SearchIndex.purview_enabled",
         )
 
         list(_client().list_indexes(select=["name"], top=3, skip=1, count=False))

sdk/search/azure-search-documents/tests/test_search_index_client_async.py

@@ -89,6 +89,9 @@ async def test_list_indexes_with_select_forwards_paging_kwargs(self):
             "azure.search.documents.indexes.aio.SearchIndexClient.list_indexes.top",
             "azure.search.documents.indexes.aio.SearchIndexClient.list_indexes.skip",
             "azure.search.documents.indexes.aio.SearchIndexClient.list_indexes.count",
+            "azure.search.documents.indexes.models.SearchIndex.cors_options",
+            "azure.search.documents.indexes.models.SearchIndex.permission_filter_option",
+            "azure.search.documents.indexes.models.SearchIndex.purview_enabled",
         )
 
         with mock.patch(

sdk/search/azure-search-documents/tests/test_search_indexer_models.py

@@ -3,7 +3,20 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 # ------------------------------------
-"""Unit tests for search indexer model helper serialization."""
+"""Unit tests for hand-written overload contracts on indexer models.
+
+These tests verify the public API promises declared by `@overload`
+signatures in `azure.search.documents.indexes.models._patch`:
+
+* `SearchIndexerDataSourceConnection(connection_string=...)` is a
+  hand-written alternative to passing `credentials=DataSourceCredentials(...)`.
+* `SearchResourceEncryptionKey()` accepts a no-arg construction and
+  exposes `is_service_level_key` as an optional preview-only field.
+
+If a future regeneration changes the generated parent so these
+constructions fail or serialize differently, these tests catch the
+silent regression before it reaches customers.
+"""
 
 from __future__ import annotations
 
@@ -16,13 +29,13 @@
 
 from _capabilities import require_capability
 
+
 DATA_SOURCE_NAME = "hotel-data-source"
 CONNECTION_STRING = (
     "ResourceId=/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/search/"
     "providers/Microsoft.Storage/storageAccounts/hotels"
 )
 CONTAINER_NAME = "hotel-documents"
-REPLACEMENT_CONNECTION_STRING = "<unchanged>"
 
 
 def create_data_source(connection_string=CONNECTION_STRING):
@@ -34,7 +47,7 @@ def create_data_source(connection_string=CONNECTION_STRING):
     )
 
 
-class TestSearchIndexerDataSourceConnectionSerialization:
+class TestSearchIndexerDataSourceConnectionOverloads:
     def test_connection_string_overload_serializes_as_nested_credentials(self):
         data_source = create_data_source()
 
@@ -47,17 +60,8 @@ def test_connection_string_overload_serializes_as_nested_credentials(self):
             "container": {"name": CONTAINER_NAME},
         }
 
-    def test_connection_string_property_round_trips_through_credentials(self):
-        data_source = create_data_source()
-
-        data_source.connection_string = REPLACEMENT_CONNECTION_STRING
-
-        assert data_source.connection_string == REPLACEMENT_CONNECTION_STRING
-        assert data_source.credentials.connection_string == REPLACEMENT_CONNECTION_STRING
-        assert data_source.as_dict()["credentials"] == {"connectionString": REPLACEMENT_CONNECTION_STRING}
-
 
-class TestSearchResourceEncryptionKey:
+class TestSearchResourceEncryptionKeyOverloads:
     def test_search_resource_encryption_key_allows_service_level_key_without_vault_details(self):
         require_capability("azure.search.documents.indexes.models.SearchResourceEncryptionKey.is_service_level_key")
 

sdk/search/azure-search-documents/tsp-location.yaml

@@ -1,4 +1,4 @@
 directory: specification/search/data-plane/Search
-commit: 4bb11e927c04ffcc6cb762e4f3374ffd6571590a
+commit: 8be8c75d9bb11ea95d8a7e251db74aa78b5cd76c
 repo: Azure/azure-rest-api-specs