Skip to content

Commit 972624e

Browse files
committed
Fix mypy errors in sample_get_device.py loop variable shadowing
Reusing the loop variable 'item' across four for-loops over different ItemPaged[T] types caused mypy to infer 'item' as Device from the first loop, then fail on each subsequent loop because Group / DeviceClass / DeviceClassSubgroupUpdatableDevices are not assignable to Device. Use distinct loop variable names (device, group_item, device_class, best_update) so each iteration is type-checked independently.
1 parent ec6abdb commit 972624e

1 file changed

Lines changed: 10 additions & 10 deletions

File tree

sdk/deviceupdate/azure-iot-deviceupdate/samples/GetDevice/sample_get_device.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -34,25 +34,25 @@
3434

3535
print("\nDevices:")
3636
devices = client.device_management.list_devices()
37-
for item in devices:
38-
print(f" {item['deviceId']}")
37+
for device in devices:
38+
print(f" {device['deviceId']}")
3939

4040
print("\nDevice groups:")
4141
groups = client.device_management.list_groups()
42-
for item in groups:
43-
print(f" {item['groupId']}")
42+
for group_item in groups:
43+
print(f" {group_item['groupId']}")
4444

4545
print("\nDevice classes:")
4646
device_classes = client.device_management.list_device_classes()
47-
for item in device_classes:
48-
print(f" {item['deviceClassId']}")
47+
for device_class in device_classes:
48+
print(f" {device_class['deviceClassId']}")
4949

5050
print(f"\nFor group '{group}', best updates are:")
5151
best_updates = client.device_management.list_best_updates_for_group(group)
52-
for item in best_updates:
53-
print(f" Device class '{item['deviceClassId']}':")
54-
print(f" {item['update']['updateId']['provider']}")
55-
print(f" {item['update']['updateId']['name']}")
52+
for best_update in best_updates:
53+
print(f" Device class '{best_update['deviceClassId']}':")
54+
print(f" {best_update['update']['updateId']['provider']}")
55+
print(f" {best_update['update']['updateId']['name']}")
5656
print(f" {item['update']['updateId']['version']}")
5757
except HttpResponseError as e:
5858
print("Failed to get device message: {}".format(e))

0 commit comments

Comments
 (0)