Replace broad except Exception with specific exceptions in test_policy_expected_errors_for_create_cert

Use except (HttpResponseError, ServiceRequestError) instead of bare except Exception
to avoid silently swallowing unexpected errors (AttributeError, TypeError, etc.)
that could indicate a regression in the validator or call signature.

Also add HttpResponseError and ServiceRequestError to azure.core.exceptions imports.

Author: singhalrohit4u

sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client.py

@@ -8,7 +8,7 @@
 import time
 from unittest.mock import Mock, patch
 
-from azure.core.exceptions import ResourceExistsError, ResourceNotFoundError
+from azure.core.exceptions import HttpResponseError, ResourceExistsError, ResourceNotFoundError, ServiceRequestError
 from azure.core.pipeline.policies import SansIOHTTPPolicy
 from devtools_testutils import recorded_by_proxy
 from azure.keyvault.certificates import (
@@ -845,7 +845,7 @@ def test_policy_expected_errors_for_create_cert():
         client.begin_create_certificate("...", policy=policy)
     except ValueError:
         pytest.fail("begin_create_certificate should not raise ValueError for san_ip_addresses-only policy")
-    except Exception:
+    except (HttpResponseError, ServiceRequestError):
         pass  # Expected: network/auth error since we are using a fake client
 
     # san_uris alone should be accepted (no ValueError)
@@ -854,7 +854,7 @@ def test_policy_expected_errors_for_create_cert():
         client.begin_create_certificate("...", policy=policy)
     except ValueError:
         pytest.fail("begin_create_certificate should not raise ValueError for san_uris-only policy")
-    except Exception:
+    except (HttpResponseError, ServiceRequestError):
         pass  # Expected: network/auth error since we are using a fake client
 
 

sdk/keyvault/azure-keyvault-certificates/tests/test_certificates_client_async.py

@@ -8,7 +8,7 @@
 import json
 from unittest.mock import Mock, patch
 
-from azure.core.exceptions import ResourceExistsError, ResourceNotFoundError
+from azure.core.exceptions import HttpResponseError, ResourceExistsError, ResourceNotFoundError, ServiceRequestError
 from azure.core.pipeline.policies import SansIOHTTPPolicy
 from devtools_testutils import set_bodiless_matcher, set_custom_default_matcher
 from devtools_testutils.aio import recorded_by_proxy_async
@@ -870,7 +870,7 @@ async def test_policy_expected_errors_for_create_cert():
         await client.create_certificate("...", policy=policy)
     except ValueError:
         pytest.fail("create_certificate should not raise ValueError for san_ip_addresses-only policy")
-    except Exception:
+    except (HttpResponseError, ServiceRequestError):
         pass  # Expected: network/auth error since we are using a fake client
 
     # san_uris alone should be accepted (no ValueError)
@@ -879,7 +879,7 @@ async def test_policy_expected_errors_for_create_cert():
         await client.create_certificate("...", policy=policy)
     except ValueError:
         pytest.fail("create_certificate should not raise ValueError for san_uris-only policy")
-    except Exception:
+    except (HttpResponseError, ServiceRequestError):
         pass  # Expected: network/auth error since we are using a fake client