shell quoting

Author: mikeharder

.github/workflows/azure-sdk-tools.yml

@@ -102,8 +102,8 @@ jobs:
 
       - name: Run all discovered checks against azure-template using uv as package manager
         run: |
-          sdk_build azure-template -d $(pwd)/wheels --build_id 20250101.1
-          python eng/scripts/dispatch_checks.py --checks "$AZPYSDK_CHECKS" --wheel_dir $(pwd)/wheels azure-template
+          sdk_build azure-template -d "$(pwd)/wheels" --build_id 20250101.1
+          python eng/scripts/dispatch_checks.py --checks "$AZPYSDK_CHECKS" --wheel_dir "$(pwd)/wheels" azure-template
         shell: bash
         env:
           AZPYSDK_PIP_IMPL: "uv"
@@ -115,7 +115,7 @@ jobs:
 
       - name: Run all discovered checks against azure-template using pip as package manager
         run: |
-          python eng/scripts/dispatch_checks.py --checks "$AZPYSDK_CHECKS" --wheel_dir $(pwd)/wheels azure-template
+          python eng/scripts/dispatch_checks.py --checks "$AZPYSDK_CHECKS" --wheel_dir "$(pwd)/wheels" azure-template
         shell: bash
         env:
           AZPYSDK_PIP_IMPL: "pip"

.github/workflows/typespec-python-regenerate.yml

@@ -80,11 +80,13 @@ jobs:
             exit 1
           fi
 
-          echo "typespec_repo=$REPO" >> $GITHUB_OUTPUT
-          echo "typespec_ref=$REF" >> $GITHUB_OUTPUT
-          echo "typespec_display_ref=$DISPLAY_REF" >> $GITHUB_OUTPUT
-          echo "typespec_ref_url=$REF_URL" >> $GITHUB_OUTPUT
-          echo "typespec_pr_number=$PR_NUMBER" >> $GITHUB_OUTPUT
+          {
+            echo "typespec_repo=$REPO"
+            echo "typespec_ref=$REF"
+            echo "typespec_display_ref=$DISPLAY_REF"
+            echo "typespec_ref_url=$REF_URL"
+            echo "typespec_pr_number=$PR_NUMBER"
+          } >> "$GITHUB_OUTPUT"
           echo "::notice::Regenerating from ${REPO}@${DISPLAY_REF}"
 
       - name: Checkout microsoft/typespec
@@ -206,7 +208,9 @@ jobs:
 
           # Restore regenerated files from the temp dir.
           mkdir -p "$GENERATED_DIR"
-          rm -rf "$GENERATED_DIR"/*
+          # Use ${var:?} so that if GENERATED_DIR is empty, the command aborts
+          # instead of expanding to "rm -rf /*" and deleting the filesystem.
+          rm -rf "${GENERATED_DIR:?}"/*
           cp -r "$TMPDIR"/. "$GENERATED_DIR"
           rm -rf "$TMPDIR"
           git add -f "$GENERATED_DIR"/