Sync eng/common directory with azure-sdk-tools for PR 15215 (#46495)

* Install PS modules from CFS

* Reverted change of adding auth in module installation command

* reverted quotation mark change

* Removed fallback logic of installation module

* Change installation to be required version

---------

Co-authored-by: Ray Chen <raychen@microsoft.com>

Author: azure-sdk

eng/common/pipelines/templates/steps/run-pester-tests.yml

@@ -14,7 +14,8 @@ parameters:
 steps:
 
   - pwsh: |
-       Install-Module -Name Pester -Force
+       . (Join-Path "$(Build.SourcesDirectory)" eng common scripts Helpers PSModule-Helpers.ps1)
+       Install-ModuleIfNotInstalled "Pester" "5.7.1" | Import-Module
     displayName: Install Pester
 
    # default test steps

eng/common/scripts/Helpers/PSModule-Helpers.ps1

@@ -46,23 +46,6 @@ function Update-PSModulePathForCI() {
   }
 }
 
-function Get-ModuleRepositories([string]$moduleName) {
-  $DefaultPSRepositoryUrl = "https://www.powershellgallery.com/api/v2"
-  # List of modules+versions we want to replace with internal feed sources for reliability, security, etc.
-  $packageFeedOverrides = @{
-    'powershell-yaml' = 'https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-tools/nuget/v2'
-  }
-
-  $repoUrls = if ($packageFeedOverrides.Contains("${moduleName}")) {
-    @($packageFeedOverrides["${moduleName}"], $DefaultPSRepositoryUrl)
-  }
-  else {
-    @($DefaultPSRepositoryUrl)
-  }
-
-  return $repoUrls
-}
-
 function moduleIsInstalled([string]$moduleName, [string]$version) {
   if (-not (Test-Path variable:script:InstalledModules)) {
     $script:InstalledModules = @{}
@@ -100,13 +83,13 @@ function installModule([string]$moduleName, [string]$version, $repoUrl) {
     Set-PSRepository -Name $repo.Name -InstallationPolicy "Trusted" | Out-Null
   }
 
-  Write-Verbose "Installing module $moduleName with min version $version from $repoUrl"
+  Write-Verbose "Installing module $moduleName with version $version from $repoUrl"
   # Install under CurrentUser scope so that the end up under $CurrentUserModulePath for caching
-  Install-Module $moduleName -MinimumVersion $version -Repository $repo.Name -Scope CurrentUser -Force -WhatIf:$false
+  Install-Module $moduleName -RequiredVersion $version -Repository $repo.Name -Scope CurrentUser -Force -WhatIf:$false
   # Ensure module installed
   $modules = (Get-Module -ListAvailable $moduleName)
   if ($version -as [Version]) {
-    $modules = $modules.Where({ [Version]$_.Version -ge [Version]$version })
+    $modules = $modules.Where({ [Version]$_.Version -eq [Version]$version })
   }
   if ($modules.Count -eq 0) {
     throw "Failed to install module $moduleName with version $version"
@@ -151,26 +134,11 @@ function Install-ModuleIfNotInstalled() {
     $module = moduleIsInstalled -moduleName $moduleName -version $version
     if ($module) { return $module }
 
-    $repoUrls = Get-ModuleRepositories $moduleName
-
-    foreach ($url in $repoUrls) {
-      try {
-        $module = installModule -moduleName $moduleName -version $version -repoUrl $url
-      }
-      catch {
-        if ($url -ne $repoUrls[-1]) {
-          Write-Warning "Failed to install powershell module from '$url'. Retrying with fallback repository"
-          Write-Warning $_
-          continue
-        }
-        else {
-          Write-Warning "Failed to install powershell module from $url"
-          throw
-        }
-      }
-      break
-    }
+    # Use internal Azure Artifacts feed only.
+    $repoUrl = "https://pkgs.dev.azure.com/azure-sdk/public/_packaging/azure-sdk-tools/nuget/v2"
+    Write-Host "Module '$moduleName' with version '$version' is not installed. Attempting to install from $repoUrl."
 
+    $module = installModule -moduleName $moduleName -version $version -repoUrl $repoUrl
     Write-Verbose "Using module '$($module.Name)' with version '$($module.Version)'."
   }
   finally {

eng/common/scripts/Verify-Resource-Ref.ps1

@@ -1,5 +1,6 @@
 . (Join-Path $PSScriptRoot common.ps1)
-Install-Module -Name powershell-yaml -RequiredVersion 0.4.7 -Force -Scope CurrentUser
+. (Join-Path $PSScriptRoot Helpers PSModule-Helpers.ps1)
+Install-ModuleIfNotInstalled "powershell-yaml" "0.4.7" | Import-Module
 $ymlfiles = Get-ChildItem $RepoRoot -recurse | Where-Object {$_ -like '*.yml'}
 $affectedRepos = [System.Collections.ArrayList]::new()