[Storage Files] Migrating to TypeSpec (#46929)

* Initial migration

* Refactor

* Update mock transport

* pylint

* adding accept sanitization to conftest

* pin new version of azure-core

* regen

* prpoject version

* remove

* patch remove fix

* fix client helpers

* regen

* pyproject

* pylint

* remove redudant lines

* tests all passing

* pylint

* regen

* pylint

* regen

* Apply suggestion from @l0lawrence

* Apply suggestion from @l0lawrence

* prproject

* Apply suggestion from @l0lawrence

* regen w new config

* Fix pylint errors in azure-storage-file-share

Move pylint disable comments to the correct lines where violations
occur (protected-access, unused-argument) and fix implicit string
concatenation in _parser.py.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix model subclasses to call super().__init__ and remove models _patch hacks

Refactor the 10 custom subclasses in azure/storage/fileshare/_models.py
(RetentionPolicy, Metrics, CorsRule, SmbMultichannel, SmbEncryptionInTransit,
ShareSmbSettings, NfsEncryptionInTransit, ShareNfsSettings,
ShareProtocolSettings, AccessPolicy) so they no longer shadow the parent
_RestField descriptors and properly delegate to super().__init__(**kwargs).

With the subclasses fixed at the source, the runtime monkey-patches in
_generated/models/_patch.py (_patched_getattr/setattr/getattribute/new) are
no longer needed; revert that file to the empty stock template.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* regen

* mypy/pylint fix

* regen

* regen renamed a param

Co-authored-by: Copilot <copilot@github.com>

* Align _shared upload helpers with azure-storage-blob TSP migration

Port changes from azure-storage-blob storageblob3 branch to keep _shared
files consistent across Storage packages:
- request_handlers.py: collapse split string literals
- uploads.py / uploads_async.py: switch BlockBlob/PageBlob/AppendBlob
  ChunkUploader callers to keyword args and to the new etag /
  match_condition / append_position kwarg names; pop those kwargs in
  upload_data_chunks and upload_substream_blocks when running in parallel.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix FileProperty datetime fields: declare as str, not RFC7231 datetime

The wire format for creationTime/lastAccessTime/lastWriteTime/changeTime
is ISO 8601, not RFC 7231 (only Last-Modified is RFC 7231). Declaring
them as Optional[datetime.datetime] with format="rfc7231" causes the
XML deserializer to fail and leave a raw xml.etree.ElementTree.Element
in _data, which crashes JSON serialization downstream (Azure CLI).

Match the legacy SDK behavior by declaring these fields as Optional[str].

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* wip changes from running against azure cli

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* also patch here for backcompat

* regen

* Fix pylint: relocate disable comments in _models.py

- Move 'protected-access' disables from closing-bracket lines onto the
  lines where '_from_generated' is actually accessed (Metrics,
  SharePropertiesPaged, HandlesPaged).
- Use scoped 'disable/enable=protected-access' block in
  DirectoryPropertiesPaged._extract_data_cb (two accesses too long to
  carry inline disables under the 120-char limit).
- Add 'unused-argument' disables to the backcompat **kwargs catch-all
  __init__ methods on SmbMultichannel, SmbEncryptionInTransit,
  ShareSmbSettings, NfsEncryptionInTransit, ShareNfsSettings, and
  ShareProtocolSettings.

No logic changes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* client docstring

* todo

* regen

* fixing up backcompat models for api parity

* update wrapper for iter_bytes

* tests/samples w/o formatting changes

* regen with newest emitter

* update policies

* regen

* pylint

* account for xml element

* add 3.14

* updates to models

* black

* linting

* blakc

* missing impl

* par with queue

* patch operation upload_range for parity

* map output to the public model

* add _validation

* add xml map name for backcompat

* black

* this

* this

* cleaning code

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* cleaning up

* here

* align _shared

* update iterator wrapper

* _shared parity

* _shared align

* pass metadata api check

* nit

* remove blob/datalake tsp changes

* rangepolicy (need to add to queue _shared)

* access_conditions -> lease_id

* remove useless-suppression

* dont need to strip here

* dont do strip_url, just dont pass snapshot explicitly

* regen

* update changelog

* changelog + readme 3.9

* api metadata

* publicly expose signedIdentifier

* simplify patch file

* update changelogs to catalog leaking

* clean up patches

* add back conftest

---------

Co-authored-by: antisch <antisch@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: l0lawrence <l0lawrence@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Author: 5 people

sdk/storage/azure-storage-file-share/CHANGELOG.md

@@ -4,6 +4,14 @@
 
 ### Features Added
 
+### Bugs Fixed
+- Return type of get_share_access_policies is now the publicly exposed SignedIdentifier model containing the publicly exposed AccessPolicy model. Previously we were leaking the internal generated SignedIdentifier model without exposing it in the api.
+
+
+### Other Changes
+- Custom transports that use legacy azure-core Request/Response types will not be supported moving forward
+- Removed support for Python 3.9, Python 3.10 or later is required to use this package
+
 ## 12.26.0 (2026-06-08)
 
 ### Features Added

sdk/storage/azure-storage-file-share/MANIFEST.in

@@ -1,7 +1,7 @@
 include *.md
-include azure/__init__.py
-include azure/storage/__init__.py
 include LICENSE
+include azure/storage/fileshare/py.typed
 recursive-include tests *.py
 recursive-include samples *.py *.md
-include azure/storage/fileshare/py.typed
+include azure/__init__.py
+include azure/storage/__init__.py

sdk/storage/azure-storage-file-share/README.md

@@ -17,7 +17,7 @@ Azure file shares can be used to:
 ## Getting started
 
 ### Prerequisites
-* Python 3.9 or later is required to use this package. For more details, please read our page on [Azure SDK for Python version support policy](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/python_version_support_policy.md).
+* Python 3.10 or later is required to use this package. For more details, please read our page on [Azure SDK for Python version support policy](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/python_version_support_policy.md).
 * You must have an [Azure subscription](https://azure.microsoft.com/free/) and an
 [Azure storage account](https://learn.microsoft.com/azure/storage/common/storage-account-overview) to use this package.
 

sdk/storage/azure-storage-file-share/_metadata.json

@@ -0,0 +1,6 @@
+{
+  "apiVersion": "2026-06-06",
+  "apiVersions": {
+    "Storage.File": "2026-06-06"
+  }
+}

sdk/storage/azure-storage-file-share/api.md

@@ -64,7 +64,7 @@ namespace azure.storage.fileshare
         ) -> str: ...
 
 
-    class azure.storage.fileshare.AccessPolicy(GenAccessPolicy):
+    class azure.storage.fileshare.AccessPolicy(_BackCompatMixin):
         expiry: Optional[Union[datetime, str]]
         permission: Optional[Union[ShareSasPermissions, str]]
         start: Optional[Union[datetime, str]]
@@ -219,7 +219,7 @@ namespace azure.storage.fileshare
         def values(self): ...
 
 
-    class azure.storage.fileshare.CorsRule(GeneratedCorsRule):
+    class azure.storage.fileshare.CorsRule(_BackCompatMixin):
         allowed_headers: str
         allowed_methods: str
         allowed_origins: str
@@ -585,7 +585,7 @@ namespace azure.storage.fileshare
         SECONDARY = secondary
 
 
-    class azure.storage.fileshare.Metrics(GeneratedMetrics):
+    class azure.storage.fileshare.Metrics(_BackCompatMixin):
         enabled: bool = False
         include_apis: bool
         retention_policy: RetentionPolicy
@@ -674,7 +674,7 @@ namespace azure.storage.fileshare
         def from_string(cls, string: str) -> Self: ...
 
 
-    class azure.storage.fileshare.NfsEncryptionInTransit(GeneratedNfsEncryptionInTransit):
+    class azure.storage.fileshare.NfsEncryptionInTransit(_BackCompatMixin):
         required: bool
 
         def __eq__(self, other: Any) -> bool: ...
@@ -743,7 +743,7 @@ namespace azure.storage.fileshare
         def from_string(cls, string: str) -> ResourceTypes: ...
 
 
-    class azure.storage.fileshare.RetentionPolicy(GeneratedRetentionPolicy):
+    class azure.storage.fileshare.RetentionPolicy(_BackCompatMixin):
         days: Optional[int]
         enabled: bool = False
 
@@ -1710,7 +1710,7 @@ namespace azure.storage.fileshare
             ) -> None: ...
 
 
-    class azure.storage.fileshare.ShareNfsSettings(GeneratedShareNfsSettings):
+    class azure.storage.fileshare.ShareNfsSettings(_BackCompatMixin):
         encryption_in_transit: NfsEncryptionInTransit
 
         def __eq__(self, other: Any) -> bool: ...
@@ -1833,7 +1833,7 @@ namespace azure.storage.fileshare
         def values(self): ...
 
 
-    class azure.storage.fileshare.ShareProtocolSettings(GeneratedShareProtocolSettings):
+    class azure.storage.fileshare.ShareProtocolSettings(_BackCompatMixin):
         nfs: Optional[ShareNfsSettings]
         smb: Optional[ShareSmbSettings]
 
@@ -2034,7 +2034,7 @@ namespace azure.storage.fileshare
             ) -> ShareClient: ...
 
 
-    class azure.storage.fileshare.ShareSmbSettings(GeneratedShareSmbSettings):
+    class azure.storage.fileshare.ShareSmbSettings(_BackCompatMixin):
         encryption_in_transit: Optional[SmbEncryptionInTransit]
         multichannel: Optional[SmbMultichannel]
 
@@ -2087,7 +2087,60 @@ namespace azure.storage.fileshare
             ) -> JSON: ...
 
 
-    class azure.storage.fileshare.SmbEncryptionInTransit(GeneratedSmbEncryptionInTransit):
+    class azure.storage.fileshare.SignedIdentifier(DictMixin):
+        access_policy: Optional[AccessPolicy]
+        id: str
+
+        def __contains__(self, key): ...
+
+        def __delitem__(self, key): ...
+
+        def __eq__(self, other): ...
+
+        def __getitem__(self, key): ...
+
+        def __init__(
+                self, 
+                id: str, 
+                access_policy: Optional[AccessPolicy] = None
+            ) -> None: ...
+
+        def __len__(self): ...
+
+        def __ne__(self, other): ...
+
+        def __repr__(self): ...
+
+        def __setitem__(
+                self, 
+                key, 
+                item
+            ): ...
+
+        def __str__(self): ...
+
+        def get(
+                self, 
+                key, 
+                default = None
+            ): ...
+
+        def has_key(self, k): ...
+
+        def items(self): ...
+
+        def keys(self): ...
+
+        def update(
+                self, 
+                *args, 
+                **kwargs
+            ): ...
+
+        def values(self): ...
+
+
+    class azure.storage.fileshare.SmbEncryptionInTransit(_BackCompatMixin):
         required: bool
 
         def __eq__(self, other: Any) -> bool: ...
@@ -2138,7 +2191,7 @@ namespace azure.storage.fileshare
             ) -> JSON: ...
 
 
-    class azure.storage.fileshare.SmbMultichannel(GeneratedSmbMultichannel):
+    class azure.storage.fileshare.SmbMultichannel(_BackCompatMixin):
         enabled: bool
 
         def __eq__(self, other: Any) -> bool: ...

sdk/storage/azure-storage-file-share/api.metadata.yml

@@ -1,3 +1,3 @@
-apiMdSha256: 3c2f71c139d0f1e3430e1f6802e9b27f9940c011b1da95748721350c53a0c6f8
+apiMdSha256: e5365af6aa894d319fb5d7552c4c61d2a91ec7bc761597ebc5b7bdb24049cf5e
 parserVersion: 0.3.28
-pythonVersion: 3.13.14
+pythonVersion: 3.10.20