Apply suggestions from code review

Co-authored-by: McCoy Patiño <39780829+mccoyp@users.noreply.github.com>

Author: scbedd

eng/tox/verify_sdist.py

@@ -156,10 +156,10 @@ def verify_sdist_pytyped(
         if verify_sdist_pytyped(pkg_dir, pkg_details.namespace, pkg_details.package_data, pkg_details.include_package_data):
             logging.info(f"Py.typed setup.py kwargs are set properly: {pkg_details.name}")
         else:
-            logging.error(f"Verified py.typed {pkg_details.name}. Check messages above.")
+            logging.error(f"Py.typed verification failed for package {pkg_details.name}. Check messages above.")
             error_occurred = True
 
-    if pkg_details.name in EXCLUDED_CLASSIFICATION_PACKAGES and "-nspkg" not in pkg_details.name:
+    if pkg_details.name not in EXCLUDED_CLASSIFICATION_PACKAGES and "-nspkg" not in pkg_details.name:
         logging.info(f"Verifying package classifiers: {pkg_details.name}")
 
         status, message = verify_package_classifiers(pkg_details.name, pkg_details.version, pkg_details.classifiers)

tools/azure-sdk-tools/ci_tools/functions.py

@@ -900,7 +900,7 @@ def verify_package_classifiers(package_name: str, package_version: str, package_
     :param str package_name: The name of the package being verified. Used for detail in the error response.
     :param str package_version: The version of the package being verified.
     :param List[str] package_classifiers: The classifiers of the package being verified.
-
+    :returns: A tuple, (x, y), where x is whether the package version matches its classifiers, and y is an error message or None.
     """
 
     dev_status = parse(package_version)
@@ -923,7 +923,7 @@ def verify_package_classifiers(package_name: str, package_version: str, package_
             # or Development Status :: 7 - Inactive
             num = int(c.split("::")[1].split("-")[0].strip())
         except (IndexError, ValueError):
-            return False, f"{package_name} has version {package_version} and is a GA release, but failed to pull a status number from status '{c}'. Expecting format identical to 'Development Status :: 5 - Production'."
+            return False, f"{package_name} has version {package_version} and is a GA release, but failed to pull a status number from status '{c}'. Expecting format identical to 'Development Status :: 5 - Production/Stable'."
         if num < 5:
-            return False, f"{package_name} has version {package_version} and is a GA release, but had development status '{c}'. Expecting a development classifier that is equal or greater than 'Development Status :: 5 - Production'."
+            return False, f"{package_name} has version {package_version} and is a GA release, but had development status '{c}'. Expecting a development classifier that is equal or greater than 'Development Status :: 5 - Production/Stable'."
     return True, None

tools/azure-sdk-tools/tests/test_classifier_checks.py

@@ -7,7 +7,7 @@
     "package_name, package_version, package_classifiers, expected_result",
     [
         ("a", "1.0.0", ["Development Status :: 4 - Beta"], False),
-        ("b", "1.0.0", ["Development Status :: 5 - Production"], True),
+        ("b", "1.0.0", ["Development Status :: 5 - Production/Stable"], True),
         ("b", "1.0.0a1", ["Development Status :: 5 - Production"], False),
         ("b", "1.0.0a1", ["Development Status :: 4 - Beta"], True),
         ("c", "1.0.0b1", ["Development Status :: 4 - Beta"], True),