file updates

Author: l0lawrence

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_client_constructor_takes_credential.py

@@ -1,9 +1,10 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
+from typing import Any
 # This code violates missing-client-constructor-parameter-credential
 class ClassNameClient():
-    def __init__(self, *, api_version:str = "2018", **kwargs) -> None:
+    def __init__(self, *, api_version: str = "2018", **kwargs: Any) -> None:
         """
         :keyword eight: The eighth parameter.
         :paramtype eight: str

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_client_method_missing_tracing.py

@@ -8,5 +8,5 @@
 class Some2Client():
 
     @distributed_trace_async
-    def get_thing(self) -> List[str]:
+    def get_thing(self, **kwargs) -> List[str]:
         return []

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_delete_wrong_return_type.py

@@ -9,4 +9,7 @@
 class MyClient():
     @distributed_trace
     def delete_some_function(self, **kwargs) -> str:
-        return kwargs.get("some_key")
+        client = kwargs.get("some_client")
+        client.delete()
+        # Do something with the key
+        return self

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_exception_log.py

@@ -6,12 +6,20 @@
 
 # This code violates do-not-log-exceptions-if-not-debug
 
-try:
-    a = "this is doing something here"
-except TypeError as e:
-    logging.info(
-        "This is a TypeError: %s",
-        e,
-    )
+def add(a, b):
+    """
+    Add two numbers together.
+    :param a: The first number.
+    :param b: The second number.
+    :return: The sum of the two numbers.
+    """
+    logging.debug("Adding %s and %s", a, b)
+    try:
+        return a + b
+    except TypeError as e:
+        logging.info(
+            "This is a TypeError: %s",
+            e,
+        )
 
 

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_exception_raise_log.py

@@ -6,13 +6,19 @@
 
 # This code violates do-not-log-raised-errors
 
-try:
-    a = "this is doing something here"
-    a.get("this")
-except TypeError as e:
-    logging.debug(
-        "This is a TypeError: %s",
-        e,
-    )
-    raise e
-
+def add(a, b):
+    """
+    Add two numbers together.
+    :param a: The first number.
+    :param b: The second number.
+    :return: The sum of the two numbers.
+    """
+    logging.debug("Adding %s and %s", a, b)
+    try:
+        return a + b
+    except TypeError as e:
+        logging.debug(
+            "This is a TypeError: %s",
+            e,
+        )
+        raise e

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_import_errors.py

@@ -2,22 +2,11 @@
 # Copyright (c) Microsoft Corporation. All rights reserved.
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
-import requests
-import httpx
-import aiohttp
 from azure.core.exceptions import raise_with_traceback
-# This code violates no-raise-with-traceback, networking-import-outside-azure-core-transport
+# This code violates no-raise-with-traceback
 
 
 async def main():
-    r = requests.get("http://localhost:8080/basic/string", timeout=0.1)
-    print(r.status_code)
-    r = httpx.get("http://localhost:8080/basic/string")
-    print(r.status_code)
-    async with aiohttp.ClientSession() as session:
-        async with session.get("http://localhost:8080/basic/string") as response:
-            print(response.status)
-
     l = {}
     try:
         l["a"].append(1)

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_no_typing_under_type_checking.py

@@ -10,5 +10,5 @@
     from typing import Any
 
 
-def foo() -> Any:
+def create_number() -> Any:
     return 42

tools/azure-sdk-tools/linting_tools/lint_test_bench/test_files/test_non_abstract_transport.py

@@ -3,20 +3,20 @@
 # Licensed under the MIT License. See License.txt in the project root for license information.
 # --------------------------------------------------------------------------------------------
 from azure.core.pipeline import AsyncPipeline
-from azure.core.pipeline.transport import HttpRequest as PipelineTransportHttpRequest
+from azure.core.pipeline.transport import HttpRequest
 from azure.core.pipeline.policies import (
     UserAgentPolicy,
     AsyncRedirectPolicy,
 )
 from azure.core.pipeline.transport import (
-    AioHttpTransport,
+    RequestsTransport,
 )
 # This code violates do-not-import-asyncio
 
 async def main():
     port = 8080
-    request = PipelineTransportHttpRequest("GET", "http://localhost:{}/basic/string".format(port))
-    policies = [UserAgentPolicy("myusergant"), AsyncRedirectPolicy()]
-    async with AsyncPipeline(AioHttpTransport(), policies=policies) as pipeline:
+    request = HttpRequest("GET", "http://localhost:{}/basic/string".format(port))
+    policies = [UserAgentPolicy("myuseragent"), AsyncRedirectPolicy()]
+    async with AsyncPipeline(RequestsTransport(), policies=policies) as pipeline:
         response = await pipeline.run(request)
         print(response.http_response.status_code)