Skip to content

Commit d0f2455

Browse files
authored
Remove Ruff support (#46578)
* remove * remove more * rm ruff toml
1 parent c14e6ba commit d0f2455

13 files changed

Lines changed: 1 addition & 208 deletions

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ We maintain an [additional document](https://github.com/Azure/azure-sdk-for-pyth
101101
- [Install and test checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#install-and-test-checks) (whl, sdist, mindependency, latestdependency, devtest, regression)
102102
- [PR validation](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#pr-validation) (subset that runs on every pull request)
103103
- [Nightly and release checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#nightly-and-release) (full check set including latestdependency, whl_no_aio, import_all)
104-
- [Weekly analyze checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#weekly-analyze-checks) (ruff, next-generation tool versions)
104+
- [Weekly analyze checks](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#weekly-analyze-checks) (next-generation tool versions)
105105
- [pyproject.toml configuration](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#the-pyprojecttoml) (enabling/disabling checks per package, analyze_python_version override)
106106
- [Skipping checks at queue time](https://github.com/Azure/azure-sdk-for-python/blob/main/doc/eng_sys_checks.md#skipping-checks-at-queue-time)
107107

doc/eng_sys_checks.md

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
- [Regression Test](#regression-test)
4141
- [Autorest Automation](#autorest-automation)
4242
- [Weekly Analyze Checks](#weekly-analyze-checks)
43-
- [Ruff](#ruff)
4443
- [Next-Generation Checks](#next-generation-checks)
4544

4645
This document describes every CI check run against Azure SDK for Python packages — what each one does, when it runs, and how to reproduce it locally.
@@ -590,18 +589,6 @@ python scripts/devops_tasks/verify_autorest.py --service_directory <your_service
590589

591590
The following checks run on a weekly cadence (not on every PR or nightly) via the `python-analyze-weekly` pipeline. They are exploratory/informational and use `continueOnError: true`, meaning failures are surfaced as warnings but do not block merges.
592591

593-
### Ruff
594-
595-
<a name="ruff"></a>
596-
597-
[`Ruff`](https://docs.astral.sh/ruff/) is a fast Python linter and formatter written in Rust. It runs only during the weekly analyze job, not on every PR.
598-
599-
To run locally:
600-
601-
```bash
602-
azpysdk ruff .
603-
```
604-
605592
### Next-Generation Checks
606593

607594
<a name="next-generation-checks"></a>

doc/tool_usage_guide.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ The following checks are available via the `azpysdk` entrypoint.
2121
|`pyright`| Runs `pyright` checks or `next-pyright` checks. (based on presence of `--next` argument) | `azpysdk pyright .` |
2222
|`black`| Runs `black` checks. | `azpysdk black .` |
2323
|`verifytypes`| Runs `verifytypes` checks. | `azpysdk verifytypes .` |
24-
|`ruff`| Runs `ruff` checks. | `azpysdk ruff .` |
2524
|`apistub`| Generates an api stub for the package. | `azpysdk apistub .` |
2625
|`bandit`| Runs `bandit` checks, which detect common security issues. | `azpysdk bandit .` |
2726
|`verifywhl`| Verifies that the root directory in whl is azure, and verifies manifest so that all directories in source are included in sdist. | `azpysdk verifywhl .` |

eng/pipelines/templates/stages/python-analyze-weekly.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -72,19 +72,6 @@ stages:
7272
env:
7373
GH_TOKEN: $(azuresdk-github-pat)
7474

75-
- task: PythonScript@0
76-
displayName: 'Run Ruff'
77-
continueOnError: true
78-
inputs:
79-
scriptPath: 'eng/scripts/dispatch_checks.py'
80-
arguments: >-
81-
${{ parameters.BuildTargetingString }}
82-
--service="${{ parameters.ServiceDirectory }}"
83-
--checks="ruff"
84-
--disablecov
85-
env:
86-
GH_TOKEN: $(azuresdk-github-pat)
87-
8875
- script: |
8976
python -m pip install PyGithub>=1.59.0
9077
python -m pip install requests>=2.0

eng/tools/azure-sdk-tools/azpysdk/main.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
from .black import black
2424
from .pyright import pyright
2525
from .next_pyright import next_pyright
26-
from .ruff import ruff
2726
from .verifytypes import verifytypes
2827
from .apistub import apistub
2928
from .verify_sdist import verify_sdist
@@ -138,7 +137,6 @@ def build_parser() -> argparse.ArgumentParser:
138137
black().register(subparsers, [common])
139138
pyright().register(subparsers, [common])
140139
next_pyright().register(subparsers, [common])
141-
ruff().register(subparsers, [common])
142140
verifytypes().register(subparsers, [common])
143141
apistub().register(subparsers, [common])
144142
verify_sdist().register(subparsers, [common])

eng/tools/azure-sdk-tools/azpysdk/ruff.py

Lines changed: 0 additions & 74 deletions
This file was deleted.

eng/tox/run_ruff.py

Lines changed: 0 additions & 42 deletions
This file was deleted.

eng/tox/tox.ini

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -144,25 +144,6 @@ commands =
144144
--package-type sdist
145145
python {repository_root}/eng/tox/run_pylint.py -t {tox_root} --next=True
146146

147-
[testenv:ruff]
148-
description=Lints a package with ruff
149-
skipsdist = true
150-
skip_install = true
151-
usedevelop = false
152-
setenv =
153-
{[testenv]setenv}
154-
PROXY_URL=http://localhost:5022
155-
deps =
156-
{[base]deps}
157-
ruff
158-
commands =
159-
python {repository_root}/eng/tox/create_package_and_install.py \
160-
-d {envtmpdir}/dist \
161-
-p {tox_root} \
162-
-w {envtmpdir} \
163-
--package-type sdist
164-
python {repository_root}/eng/tox/run_ruff.py -t {tox_root}
165-
166147
[testenv:mypy]
167148
description=Typechecks a package with mypy (version {[testenv:mypy]mypy_version})
168149
mypy_version=1.19.1

ruff.toml

Lines changed: 0 additions & 2 deletions
This file was deleted.

sdk/agentserver/azure-ai-agentserver-core/pyproject.toml

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,6 @@ readme = { file = ["README.md"], content-type = "text/markdown" }
5252
[tool.setuptools.package-data]
5353
"azure.ai.agentserver.core" = ["py.typed"]
5454

55-
[tool.ruff]
56-
line-length = 120
57-
target-version = "py310"
58-
lint.select = ["E", "F", "B", "I"]
59-
lint.ignore = []
60-
fix = false
61-
62-
[tool.ruff.lint.isort]
63-
known-first-party = ["azure.ai.agentserver.core"]
64-
combine-as-imports = true
65-
6655
[tool.azure-sdk-build]
6756
breaking = false
6857
mypy = true

0 commit comments

Comments
 (0)