Skip to content

Commit d960879

Browse files
authored
Remove unnecessary dev dependencies (#45097)
* Remove unnecessay dev dependencies The azure-mgmt-communication dependency is not used in the tests for these packages. They are removed, as their presence has been causing mindependency check failures. Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> * Fix typing in samples Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com> --------- Signed-off-by: Paul Van Eck <paulvaneck@microsoft.com>
1 parent 36b8f21 commit d960879

4 files changed

Lines changed: 3 additions & 5 deletions

File tree

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
-e ../../../eng/tools/azure-sdk-tools
22
../../identity/azure-identity
33
../../core/azure-core
4-
../azure-mgmt-communication
54
aiohttp>=3.0
6-
parameterized>=0.7.3
5+
parameterized>=0.7.3
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
-e ../../../eng/tools/azure-sdk-tools
22
../../identity/azure-identity
33
../../core/azure-core
4-
../azure-mgmt-communication
54
aiohttp

sdk/communication/azure-communication-phonenumbers/samples/siprouting/get_sip_routes_sample.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def get_sip_routes_sample():
3131
print(route.description)
3232
print(route.number_pattern)
3333

34-
for trunk_fqdn in route.trunks:
34+
for trunk_fqdn in route.trunks or []:
3535
print(trunk_fqdn)
3636

3737

sdk/communication/azure-communication-phonenumbers/samples/siprouting/get_sip_routes_sample_async.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ async def get_sip_routes_sample():
3333
print(route.description)
3434
print(route.number_pattern)
3535

36-
for trunk_fqdn in route.trunks:
36+
for trunk_fqdn in route.trunks or []:
3737
print(trunk_fqdn)
3838

3939

0 commit comments

Comments
 (0)