Skip to content

Commit df0f4e1

Browse files
committed
fix timeout
1 parent 3ea8d83 commit df0f4e1

3 files changed

Lines changed: 2 additions & 25 deletions

File tree

sdk/webpubsub/azure-messaging-webpubsubclient/tests/test_smoke_async.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,7 @@ async def on_stop():
100100

101101
# remove stopped event and close again
102102
await client.unsubscribe("stopped", on_stop)
103-
disconnected_event.clear()
104103
await client.close()
105-
await asyncio.wait_for(disconnected_event.wait(), timeout=30)
106104
assert not client.is_connected()
107105

108106
@WebpubsubClientPowerShellPreparer()

sdk/webpubsub/azure-messaging-webpubsubservice/tests/test_live_api_coverage.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ def _find_connection_id(self, client, group_name, user_id):
2525
time.sleep(1)
2626
return None
2727

28-
def _wait_for_server_cleanup(self, delay_seconds=2):
29-
time.sleep(delay_seconds)
30-
3128
def _wait_for_connection_removed(self, client, connection_id):
3229
for _ in range(30):
3330
if not client.connection_exists(connection_id=connection_id):
@@ -175,7 +172,7 @@ def test_live_api_coverage_all_apis_and_parameters(self, webpubsub_endpoint, web
175172

176173
# close_group_connections (connection auto-joins group_1 via token)
177174
ws.close()
178-
self._wait_for_server_cleanup()
175+
self._wait_for_connection_removed(client, connection_id)
179176
ws = ws_connect(access_token["url"], open_timeout=30)
180177
conn = self._find_connection_id(client, group_1, user_id)
181178
assert conn is not None
@@ -184,7 +181,6 @@ def test_live_api_coverage_all_apis_and_parameters(self, webpubsub_endpoint, web
184181
assert not client.connection_exists(connection_id=conn)
185182

186183
# close_user_connections
187-
self._wait_for_server_cleanup()
188184
ws = ws_connect(access_token["url"], open_timeout=30)
189185
conn = self._find_connection_id(client, group_1, user_id)
190186
assert conn is not None
@@ -193,7 +189,6 @@ def test_live_api_coverage_all_apis_and_parameters(self, webpubsub_endpoint, web
193189
assert not client.connection_exists(connection_id=conn)
194190

195191
# close_connection
196-
self._wait_for_server_cleanup()
197192
ws = ws_connect(access_token["url"], open_timeout=30)
198193
conn = self._find_connection_id(client, group_1, user_id)
199194
assert conn is not None
@@ -202,7 +197,6 @@ def test_live_api_coverage_all_apis_and_parameters(self, webpubsub_endpoint, web
202197
assert not client.connection_exists(connection_id=conn)
203198

204199
# close_all_connections
205-
self._wait_for_server_cleanup()
206200
ws = ws_connect(access_token["url"], open_timeout=30)
207201
conn = self._find_connection_id(client, group_1, user_id)
208202
assert conn is not None

sdk/webpubsub/azure-messaging-webpubsubservice/tests/test_live_api_coverage_async.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,6 @@ async def _find_connection_id(self, client, group_name, user_id):
2727
await asyncio.sleep(1)
2828
return None
2929

30-
async def _wait_for_server_cleanup(self, delay_seconds=2):
31-
"""
32-
Wait for server-side cleanup after closing a connection.
33-
34-
The server needs time to process the disconnection before accepting new connections.
35-
This is a pragmatic wait since we don't have a direct signal for when cleanup completes.
36-
37-
Args:
38-
delay_seconds: Time to wait in seconds (default 2 seconds for server cleanup)
39-
"""
40-
await asyncio.sleep(delay_seconds)
41-
4230
async def _wait_for_connection_removed(self, client, connection_id):
4331
for _ in range(30):
4432
if not await client.connection_exists(connection_id=connection_id):
@@ -214,7 +202,7 @@ async def test_live_api_coverage_all_apis_and_parameters_async(
214202

215203
# close_group_connections (connection auto-joins group_1 via token)
216204
await ws.close()
217-
await self._wait_for_server_cleanup()
205+
await self._wait_for_connection_removed(client, connection_id)
218206
ws = await ws_connect(access_token["url"], open_timeout=30)
219207
conn = await self._find_connection_id(client, group_1, user_id)
220208
assert conn is not None
@@ -223,7 +211,6 @@ async def test_live_api_coverage_all_apis_and_parameters_async(
223211
assert not await client.connection_exists(connection_id=conn)
224212

225213
# close_user_connections
226-
await self._wait_for_server_cleanup()
227214
ws = await ws_connect(access_token["url"], open_timeout=30)
228215
conn = await self._find_connection_id(client, group_1, user_id)
229216
assert conn is not None
@@ -232,7 +219,6 @@ async def test_live_api_coverage_all_apis_and_parameters_async(
232219
assert not await client.connection_exists(connection_id=conn)
233220

234221
# close_connection
235-
await self._wait_for_server_cleanup()
236222
ws = await ws_connect(access_token["url"], open_timeout=30)
237223
conn = await self._find_connection_id(client, group_1, user_id)
238224
assert conn is not None
@@ -241,7 +227,6 @@ async def test_live_api_coverage_all_apis_and_parameters_async(
241227
assert not await client.connection_exists(connection_id=conn)
242228

243229
# close_all_connections
244-
await self._wait_for_server_cleanup()
245230
ws = await ws_connect(access_token["url"], open_timeout=30)
246231
conn = await self._find_connection_id(client, group_1, user_id)
247232
assert conn is not None

0 commit comments

Comments
 (0)