Conversation
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| # token and DefaultAzureCredential picks it up automatically. | ||
| trigger: none | ||
|
|
||
| extends: |
There was a problem hiding this comment.
I think instead of creating a new pipeline. A new job in the existing pipeline would be better because this would require us triggering another pipeline per pr.
There was a problem hiding this comment.
I dont think it would be possible to fold the AAD lane into the existing pipeline because
EnvVars: on eng/pipelines/templates/stages/archetype-sdk-tests.yml is stage-level today: whatever we set there applies to every matrix entry generated by MatrixConfigs[]. Our AAD lane needs COSMOS_TEST_DATA_AUTH_MODE=aad set for one new matrix entry only — without leaking to the existing key-auth entries in the same stage (setting it stage-wide would swap our existing key-auth live coverage for AAD instead of adding AAD on top).
but I have also asked eng. team to confirm the same? just an FYI...
There was a problem hiding this comment.
You can pass in the env variable through the bicep file. We do it for keys or enabling ppcb for all the different job. The keys are different for each job as eachjob runs on a different account.
| "PythonVersion": "3.13", | ||
| "CoverageArg": "--disablecov", | ||
| "TestSamples": "false", | ||
| "TestMarkArgument": "cosmosAAD" |
There was a problem hiding this comment.
| "TestMarkArgument": "cosmosAAD" | |
| "TestMarkArgument": "cosmosAAD", | |
| "COSMOS_TEST_DATA_AUTH_MODE": "aad" |
…zure/azure-sdk-for-python into users/dibahl/aad-test-coverage # Conflicts: # sdk/cosmos/aad.tests.yml
|
/azp run python - cosmos - tests |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run python - cosmos - tests |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
This PR attempts to enhance the test coverage to include Data-plane user-data operations. It doesn't not cover ARM control plane or Data-plane resource management operations.
Currently there are 2 known gaps in the AAD workflow-
Known Issue — 403/5302 right after creating a new container under AAD - service side - there is a follow up going on.
403/5300 After Token Expiry - need to follow up with the client to see if they doing any custom work on Token Credential and have them provide more information if it happens next time - there is a separate thread around this.
Please note for now I have annotated the all the AAD tests with skip notation except one to ensure pipeline set up is correct. will enable all tests once this is confirmed.