[Pipeline] optimize for batch run in pipeline#40213
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the batch run in the pipeline by conditionally updating dependency installation and command flags for the Typespec generation.
- Modified the gen_typespec function in generate_utils.py to accept a new boolean parameter "run_in_pipeline" and update the command accordingly.
- Updated sdk_generator.py to extract the runInPipeline flag from the input data and pass it to gen_typespec.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/azure-sdk-tools/packaging_tools/generate_utils.py | Updated gen_typespec to conditionally install dependencies and append command flags based on run_in_pipeline. |
| tools/azure-sdk-tools/packaging_tools/sdk_generator.py | Added extraction of runInPipeline from input data and passed it to gen_typespec. |
Files not reviewed (1)
- scripts/automation_generate.sh: Language not supported
Comments suppressed due to low confidence (1)
tools/azure-sdk-tools/packaging_tools/generate_utils.py:448
- [nitpick] Consider defining the node_modules path as a constant to improve maintainability and ease future updates if the project structure changes.
if not os.path.exists("node_modules/@azure-tools/typespec-python"):
…into pipeline-batch-run-mode
msyyc
changed the title
msyyc
changed the title
ChenxiJiang333
approved these changes
Apr 11, 2025
Member
Author
|
/check-enforcer override |
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
* optimize for batch run * update * update * add log * fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix Azure/azure-sdk-tools#9877
pending on Azure/azure-sdk-tools#10075