[sdk generation pipeline] fix for data-plane SDK#40284
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues in the SDK generation pipeline with a focus on the data-plane SDK. The change adds a conditional check before calling check_file to handle packages based on their name.
- Added a condition to only call check_file for packages with names starting with "azure-mgmt-".
Comments suppressed due to low confidence (1)
tools/azure-sdk-tools/packaging_tools/sdk_package.py:103
- The variable 'package_name' is used but is not defined within this scope. It may be intended to use an existing variable or extract the package name from 'package'.
if package_name.startswith("azure-mgmt-"):
ChenxiJiang333
approved these changes
Mar 31, 2025
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix SDK generation failure for Azure/azure-rest-api-specs#33135