[bug] app config issue#40295
Merged
l0lawrence merged 1 commit intoAzure:mainfrom Mar 31, 2025
Merged
Conversation
Member
Author
|
/azp run python - appconfiguration - tests-weekly |
|
Command 'python' is not supported by Azure Pipelines. Supported commands
See additional documentation. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses a bug where duplicate error messages are posted due to the pipeline analyzing both the provider and app-config packages simultaneously. Key changes include:
- Updating the condition to append Pylint errors only if the issue body does not already include a "Pylint Errors:" section.
- Adding an inline comment clarifying the intention behind the conditional block in the issue edit logic.
Comments suppressed due to low confidence (1)
tools/azure-sdk-tools/gh_tools/update_issue.py:72
- Consider verifying that issue.body contains the delimiter 'How to fix:' before taking the second element of the split, to prevent a potential IndexError.
new_body = first_section + template + "\n" + issue.body.split("**How to fix:**")[1]
mccoyp
approved these changes
Mar 31, 2025
Member
mccoyp
left a comment
There was a problem hiding this comment.
Agreed that App Config might want to simplify their pipeline, but this solves the problem and doesn't hurt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#39274 the way the pipeline is set up for app config, analyze runs twice, once for provider and once for app-config, but analyze runs both packages so it duplicates the errors. Could also update its test.yml in addition since that seems excessive imo