[SDK generation pipeline] fix version logic#40305
Merged
Conversation
Member
msyyc
commented
Apr 1, 2025
- remove unused code
- update version with next version if next version is valid
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses improvements in the SDK generation pipeline by removing unused code and ensuring that the package version is updated to the next valid version when applicable. Key changes include:
- Removal of an obsolete built package block in sdk_package.py.
- Reordering the code in sdk_package.py to update the package version from check_file before building the package.
- Modifications in package_utils.py to allow check_file to update the package version based on the next valid version.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/azure-sdk-tools/packaging_tools/sdk_package.py | Reordered built package calls and updated version logic for azure-mgmt- packages. |
| tools/azure-sdk-tools/packaging_tools/package_utils.py | Removed unused package getters and updated check_file to modify the package version when applicable. |
ChenxiJiang333
approved these changes
Apr 1, 2025
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.