[SDK generation pipeline] add logic to count time for main steps#40456
Merged
[SDK generation pipeline] add logic to count time for main steps#40456
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (4)
tools/azure-sdk-tools/packaging_tools/sdk_package.py:57
- [nitpick] Consider revising the log message wording to 'Changelog generation took {int(time.time() - changelog_generation_start_time)} seconds' for improved clarity.
_LOGGER.info(f"changelog generation cost time: {int(time.time() - changelog_generation_start_time)} seconds")
tools/azure-sdk-tools/packaging_tools/sdk_package.py:54
- [nitpick] Consider using a more neutral and professional error message, such as 'Changelog generation timed out.'
md_output = "change log generation was timeout!!!"
tools/azure-sdk-tools/packaging_tools/sdk_package.py:90
- [nitpick] Consider updating the log message wording to 'ApiView generation took {int(time.time() - apiview_start_time)} seconds' for improved clarity.
_LOGGER.info(f"apiview generation cost time: {int(time.time() - apiview_start_time)} seconds")
tools/azure-sdk-tools/packaging_tools/sdk_generator.py:249
- [nitpick] Consider revising the log message to 'Code generation took {int(time.time() - code_generation_start_time)} seconds' for clearer communication.
_LOGGER.info(f"code generation cost time: {int(time.time() - code_generation_start_time)} seconds")
ChenxiJiang333
approved these changes
Apr 10, 2025
Member
Author
|
/check-enforcer override |
cRui861
pushed a commit
that referenced
this pull request
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.