Skip to content

[SDK generation pipeline] add logic to count time for main steps#40456

Merged
msyyc merged 1 commit intomainfrom
pipeline-count-time
Apr 10, 2025
Merged

[SDK generation pipeline] add logic to count time for main steps#40456
msyyc merged 1 commit intomainfrom
pipeline-count-time

Conversation

@msyyc
Copy link
Copy Markdown
Member

@msyyc msyyc commented Apr 10, 2025

No description provided.

Copilot AI review requested due to automatic review settings April 10, 2025 09:30
@msyyc msyyc requested review from mccoyp and scbedd as code owners April 10, 2025 09:30
@msyyc msyyc changed the title [SDK generation pipeline] add count time logic [SDK generation pipeline] add logic to count time for main steps Apr 10, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

tools/azure-sdk-tools/packaging_tools/sdk_package.py:57

  • [nitpick] Consider revising the log message wording to 'Changelog generation took {int(time.time() - changelog_generation_start_time)} seconds' for improved clarity.
_LOGGER.info(f"changelog generation cost time: {int(time.time() - changelog_generation_start_time)} seconds")

tools/azure-sdk-tools/packaging_tools/sdk_package.py:54

  • [nitpick] Consider using a more neutral and professional error message, such as 'Changelog generation timed out.'
md_output = "change log generation was timeout!!!"

tools/azure-sdk-tools/packaging_tools/sdk_package.py:90

  • [nitpick] Consider updating the log message wording to 'ApiView generation took {int(time.time() - apiview_start_time)} seconds' for improved clarity.
_LOGGER.info(f"apiview generation cost time: {int(time.time() - apiview_start_time)} seconds")

tools/azure-sdk-tools/packaging_tools/sdk_generator.py:249

  • [nitpick] Consider revising the log message to 'Code generation took {int(time.time() - code_generation_start_time)} seconds' for clearer communication.
_LOGGER.info(f"code generation cost time: {int(time.time() - code_generation_start_time)} seconds")

@msyyc
Copy link
Copy Markdown
Member Author

msyyc commented Apr 10, 2025

/check-enforcer override

@msyyc msyyc merged commit c8edb4a into main Apr 10, 2025
21 of 33 checks passed
@msyyc msyyc deleted the pipeline-count-time branch April 10, 2025 09:59
cRui861 pushed a commit that referenced this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants