Skip to content

Remove dead test code#44762

Open
akx wants to merge 1 commit into
Azure:mainfrom
akx:remove-dead-test-code
Open

Remove dead test code#44762
akx wants to merge 1 commit into
Azure:mainfrom
akx:remove-dead-test-code

Conversation

@akx

@akx akx commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes test code that has been disabled in:

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
    • Removing code that is never run is unlikely to break things.
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
    • I don't think changelogs need to be updated here?
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.
    • Test coverage over test files will improve with this. :)

Copilot AI review requested due to automatic review settings January 20, 2026 12:43
@github-actions github-actions Bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution @akx! We will review the pull request and get back to you soon.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes disabled test files that have been inactive since 2018-2023. All files are clearly marked as disabled through either disable_ filename prefixes, @unittest.skip/@pytest.mark.skip decorators, or raise unittest.SkipTest() statements at module level.

Changes:

  • Removes 8 disabled test files from the Service Bus management SDK
  • Removes 1 disabled test file from Resource Graph SDK
  • Removes 1 disabled test file from Media Services SDK
  • Removes 1 disabled test file from Event Grid SDK
  • Removes 1 disabled test file from Consumption SDK

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_cli_mgmt_servicebus_namespace.py Removed disabled namespace tests with @unittest.skip decorators
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_cli_mgmt_servicebus.py Removed disabled CLI management tests with disable_ prefix
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic_subscription_rule.py Removed disabled topic subscription rule tests with disable_ prefix
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic_subscription.py Removed disabled topic subscription tests with disable_ prefix
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic.py Removed disabled topic tests with disable_ prefix
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_queue.py Removed disabled queue tests with disable_ prefix
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_namespace.py Removed disabled namespace tests with disable_ prefix
sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_check_name_availability.py Removed disabled name availability check tests with disable_ prefix
sdk/resources/azure-mgmt-resourcegraph/tests/test_mgmt_resourcegraph.py Removed resource graph tests skipped with @pytest.mark.skip
sdk/media/azure-mgmt-media/tests/test_mgmt_media.py Removed media tests with raise unittest.SkipTest
sdk/eventgrid/azure-mgmt-eventgrid/tests/test_azure_mgmt_eventgrid_test.py Removed event grid tests with raise unittest.SkipTest
sdk/consumption/azure-mgmt-consumption/tests/test_mgmt_consumption.py Removed consumption tests with raise unittest.SkipTest

@github-actions

Copy link
Copy Markdown
Contributor

Hi @akx. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Mar 27, 2026
@akx akx force-pushed the remove-dead-test-code branch from 838319f to 12a51f4 Compare March 27, 2026 07:52
@github-actions github-actions Bot removed the no-recent-activity There has been no recent activity on this issue. label Mar 27, 2026
@akx akx force-pushed the remove-dead-test-code branch from 12a51f4 to adfdd82 Compare March 30, 2026 08:06
@akx akx force-pushed the remove-dead-test-code branch from adfdd82 to f07bd92 Compare May 28, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants