Remove dead test code#44762
Conversation
|
Thank you for your contribution @akx! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
This PR removes disabled test files that have been inactive since 2018-2023. All files are clearly marked as disabled through either disable_ filename prefixes, @unittest.skip/@pytest.mark.skip decorators, or raise unittest.SkipTest() statements at module level.
Changes:
- Removes 8 disabled test files from the Service Bus management SDK
- Removes 1 disabled test file from Resource Graph SDK
- Removes 1 disabled test file from Media Services SDK
- Removes 1 disabled test file from Event Grid SDK
- Removes 1 disabled test file from Consumption SDK
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_cli_mgmt_servicebus_namespace.py | Removed disabled namespace tests with @unittest.skip decorators |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_cli_mgmt_servicebus.py | Removed disabled CLI management tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic_subscription_rule.py | Removed disabled topic subscription rule tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic_subscription.py | Removed disabled topic subscription tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_topic.py | Removed disabled topic tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_queue.py | Removed disabled queue tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_namespace.py | Removed disabled namespace tests with disable_ prefix |
| sdk/servicebus/azure-mgmt-servicebus/tests/disable_test_azure_mgmt_servicebus_check_name_availability.py | Removed disabled name availability check tests with disable_ prefix |
| sdk/resources/azure-mgmt-resourcegraph/tests/test_mgmt_resourcegraph.py | Removed resource graph tests skipped with @pytest.mark.skip |
| sdk/media/azure-mgmt-media/tests/test_mgmt_media.py | Removed media tests with raise unittest.SkipTest |
| sdk/eventgrid/azure-mgmt-eventgrid/tests/test_azure_mgmt_eventgrid_test.py | Removed event grid tests with raise unittest.SkipTest |
| sdk/consumption/azure-mgmt-consumption/tests/test_mgmt_consumption.py | Removed consumption tests with raise unittest.SkipTest |
|
Hi @akx. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
838319f to
12a51f4
Compare
12a51f4 to
adfdd82
Compare
adfdd82 to
f07bd92
Compare
Description
This PR removes test code that has been disabled in:
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines