-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[App Configuration] - Head request support #45858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrm9084
wants to merge
16
commits into
Azure:main
Choose a base branch
from
mrm9084:appconfigHeadRequests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
44ca57d
Watch Head Requests
mrm9084 2d96ab0
removed duplicate code
mrm9084 ab457af
test recording + formatting
mrm9084 7f60cba
Apply suggestions from code review
mrm9084 953c232
fix tests
mrm9084 2f29374
formatting fix
mrm9084 2e5d88c
Merge remote-tracking branch 'upstream/main' into appconfigHeadRequests
mrm9084 3c14950
fixing after merge
mrm9084 234501b
Merge branch 'main' into appconfigHeadRequests
mrm9084 496d0b6
review comments
mrm9084 729bf75
Merge remote-tracking branch 'upstream/main' into appconfigHeadRequests
mrm9084 197919c
review comments
mrm9084 d90a34c
undo
mrm9084 7ad4571
Update _patch.py
mrm9084 ed5255a
review items
mrm9084 fd7298d
More review changes + exposing ConfigurationSettingsPage
mrm9084 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect we return the same thing that list does, callers just need to know that the iterable will be empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return
ItemPaged[ConfigurationSetting]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jimmyca15 I actually looked into this a bit more and we need to return
ConfigurationSettingPagedor we/our customers will have typing issues. This includes updating list to also return this. Note this isn't a breaking change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain the problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type checking fails on
iterator = items.by_page(match_conditions=etags)as it doesn't seematch_conditionsas a valid input.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we need to make
ConfigurationSettingPagedpublic?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if you look at the diff since your last review you should see me making it public.