Skip to content

Migrate task_navigation_efficiency test assertions to standardized output schema#46475

Merged
m7md7sien merged 1 commit intomohessie/standradize_output/task_navigation_efficiencyfrom
copilot/migrate-tests-task-navigation
Apr 22, 2026
Merged

Migrate task_navigation_efficiency test assertions to standardized output schema#46475
m7md7sien merged 1 commit intomohessie/standradize_output/task_navigation_efficiencyfrom
copilot/migrate-tests-task-navigation

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 22, 2026

The task_navigation_efficiency evaluator's output keys were renamed in this branch (_details_properties, added _passed), but the unit tests still asserted against the old schema, leaving them broken. This ports the corresponding test-only edits from #46436 (scoped strictly to this evaluator; no source/prompty/other evaluator changes pulled in).

  • tests/unittests/test_task_navigation_efficiency_evaluators.py — update assertion keys:
    • result["task_navigation_efficiency_result"] == "pass"/"fail"result["task_navigation_efficiency_passed"] is True/False
    • task_navigation_efficiency_detailstask_navigation_efficiency_properties

The migrated file is byte-identical to its counterpart in #46436. Source in this branch already emits _passed (bool) and _properties (dict), so assertions line up without any source edits.

@m7md7sien m7md7sien marked this pull request as ready for review April 22, 2026 22:09
@m7md7sien m7md7sien requested a review from a team as a code owner April 22, 2026 22:09
@m7md7sien m7md7sien merged commit 92cb5ab into mohessie/standradize_output/task_navigation_efficiency Apr 22, 2026
2 checks passed
@m7md7sien m7md7sien deleted the copilot/migrate-tests-task-navigation branch April 22, 2026 22:09
m7md7sien added a commit that referenced this pull request Apr 26, 2026
* Standradize Task Navigation Efficiency Output

* Update task_navigation_efficiency unit tests to new output schema (#46475)

Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/af7ce3e2-8f3b-425a-85fd-d9dcfd79552d

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: m7md7sien <16615690+m7md7sien@users.noreply.github.com>

* Change task navigation efficiency threshold to None

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: m7md7sien <16615690+m7md7sien@users.noreply.github.com>
fafhrd91 pushed a commit to fafhrd91/azure-sdk-for-python that referenced this pull request Apr 28, 2026
* Standradize Task Navigation Efficiency Output

* Update task_navigation_efficiency unit tests to new output schema (Azure#46475)

Agent-Logs-Url: https://github.com/Azure/azure-sdk-for-python/sessions/af7ce3e2-8f3b-425a-85fd-d9dcfd79552d

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: m7md7sien <16615690+m7md7sien@users.noreply.github.com>

* Change task navigation efficiency threshold to None

---------

Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: m7md7sien <16615690+m7md7sien@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants